You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@yetus.apache.org by GitBox <gi...@apache.org> on 2022/04/06 16:16:21 UTC
[GitHub] [yetus] omalley opened a new pull request, #251: YETUS-1155: Fix site:site treeset problem
omalley opened a new pull request, #251:
URL: https://github.com/apache/yetus/pull/251
Fixes the first problem that was caused because the yetus options weren't comparable to the standard option objects. I changed the TreeSet to a HashSet, which does not require more than hashCode & equals.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@yetus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yetus] omalley commented on pull request #251: YETUS-1155: Fix site:site treeset problem
Posted by GitBox <gi...@apache.org>.
omalley commented on PR #251:
URL: https://github.com/apache/yetus/pull/251#issuecomment-1091933117
The remaining problem is filed as a wont_fix bug on java. https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8203045
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@yetus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yetus] aw-was-here commented on pull request #251: YETUS-1155: Fix site:site treeset problem
Posted by GitBox <gi...@apache.org>.
aw-was-here commented on PR #251:
URL: https://github.com/apache/yetus/pull/251#issuecomment-1099280890
Actually, I take that back. I am going to go ahead and close the JIRA. I didn't realize you put the internal impl in place. :dancers:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@yetus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yetus] aajisaka commented on pull request #251: YETUS-1155: Fix site:site treeset problem
Posted by GitBox <gi...@apache.org>.
aajisaka commented on PR #251:
URL: https://github.com/apache/yetus/pull/251#issuecomment-1091148379
Thank you @omalley for the PR. I tried the same thing and faced the class cast exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@yetus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yetus] aw-was-here commented on pull request #251: YETUS-1155: Fix site:site treeset problem
Posted by GitBox <gi...@apache.org>.
aw-was-here commented on PR #251:
URL: https://github.com/apache/yetus/pull/251#issuecomment-1099277927
I'm going to go ahead and merge this but not close the JIRA since we still need to make a decision on what to do with the full functionality.
Thanks @omalley !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@yetus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yetus] omalley commented on pull request #251: YETUS-1155: Fix site:site treeset problem
Posted by GitBox <gi...@apache.org>.
omalley commented on PR #251:
URL: https://github.com/apache/yetus/pull/251#issuecomment-1090460024
This fixes the first problem, but another class cast exception remains.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@yetus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yetus] aw-was-here commented on pull request #251: YETUS-1155: Fix site:site treeset problem
Posted by GitBox <gi...@apache.org>.
aw-was-here commented on PR #251:
URL: https://github.com/apache/yetus/pull/251#issuecomment-1094575545
I've started a DISCUSS thread on the mailing list. I think we need to figure out what the long term plan should be with community input. All of the options are pretty awful. 😦
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@yetus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yetus] omalley commented on pull request #251: YETUS-1155: Fix site:site treeset problem
Posted by GitBox <gi...@apache.org>.
omalley commented on PR #251:
URL: https://github.com/apache/yetus/pull/251#issuecomment-1090496261
Ugh, the javadoc api is really bad. It is downcasting from the interface in the parameter list (DocletEnvironment) to a specific class (DocEnvImpl) that is private inside of the javadoc jar. I'm not sure how we can fix that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@yetus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yetus] aw-was-here merged pull request #251: YETUS-1155: Fix site:site treeset problem
Posted by GitBox <gi...@apache.org>.
aw-was-here merged PR #251:
URL: https://github.com/apache/yetus/pull/251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@yetus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org