[GitHub] [hudi] prashantwason commented on a change in pull request #3079: [HUDI-2013] Removed option to fallback to file listing when Metadata Table is enabled.

[GitBox <gi...@apache.org>]

prashantwason commented on a change in pull request #3079:
URL: https://github.com/apache/hudi/pull/3079#discussion_r652145709



##########
File path: hudi-common/src/main/java/org/apache/hudi/metadata/BaseTableMetadata.java
##########
@@ -101,11 +101,7 @@ protected BaseTableMetadata(HoodieEngineContext engineContext, HoodieMetadataCon
       try {
         return fetchAllPartitionPaths();
       } catch (Exception e) {
-        if (metadataConfig.enableFallback()) {
-          LOG.error("Failed to retrieve list of partition from metadata", e);
-        } else {
-          throw new HoodieMetadataException("Failed to retrieve list of partition from metadata", e);
-        }
+        throw new HoodieMetadataException("Failed to retrieve list of partition from metadata", e);

Review comment:
       To make lookups from metadata table fail fast. 
   
   When fallback was enabled, any errors in lookups from metadata table are logged and file-listing from file system is used instead. 
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org