You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/22 02:45:55 UTC

[GitHub] [flink] Vancior opened a new pull request, #19551: [FLINK-22984][python] Disable PushWatermarkIntoTableSourceScanAcrossCalcRule when having Python UDF

Vancior opened a new pull request, #19551:
URL: https://github.com/apache/flink/pull/19551

   ## What is the purpose of the change
   
   This pr fixes [FLINK-22984](https://issues.apache.org/jira/browse/FLINK-22984), which is caused by `PushWatermarkIntoTableSourceScanAcrossCalcRule` pushing Python UDF in computed column into the table source, so that Python UDF cannot be converted to PythonCalc node and later `PythonScalarFunctionOperator`.
   
   
   ## Brief change log
   
   - add `containsPythonCall` condition in `PushWatermarkIntoTableSourceScanAcrossCalcRule`
   
   
   ## Verifying this change
   
   
   This change added tests and can be verified as follows:
   
   - Added rule test `testWatermarkWithPythonFunctionInComputedColumn`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dianfu closed pull request #19551: [FLINK-22984][python] Disable PushWatermarkIntoTableSourceScanAcrossCalcRule when having Python UDF

Posted by GitBox <gi...@apache.org>.
dianfu closed pull request #19551: [FLINK-22984][python] Disable PushWatermarkIntoTableSourceScanAcrossCalcRule when having Python UDF
URL: https://github.com/apache/flink/pull/19551


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19551: [FLINK-22984][python] Disable PushWatermarkIntoTableSourceScanAcrossCalcRule when having Python UDF

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19551:
URL: https://github.com/apache/flink/pull/19551#issuecomment-1105949634

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "dc7975ca6151d42ffb059621c8a8cc6be8ccfdc6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dc7975ca6151d42ffb059621c8a8cc6be8ccfdc6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dc7975ca6151d42ffb059621c8a8cc6be8ccfdc6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org