You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Sreekanth Ramakrishnan (JIRA)" <ji...@apache.org> on 2009/06/05 11:16:07 UTC
[jira] Created: (HADOOP-5980) LD_LIBRARY_PATH not passed to tasks
spawned off by LinuxTaskController
LD_LIBRARY_PATH not passed to tasks spawned off by LinuxTaskController
----------------------------------------------------------------------
Key: HADOOP-5980
URL: https://issues.apache.org/jira/browse/HADOOP-5980
Project: Hadoop Core
Issue Type: Bug
Components: mapred
Reporter: Sreekanth Ramakrishnan
Currently, task spawned off by {{LinuxTaskController}} don't get LD_LIBRARY_PATH in their environment. The tasks should get same LD_LIBRARY_PATH value as when spawned off by {{DefaultTaskController}}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5980) LD_LIBRARY_PATH not passed to tasks
spawned off by LinuxTaskController
Posted by "Sreekanth Ramakrishnan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sreekanth Ramakrishnan updated HADOOP-5980:
-------------------------------------------
Attachment: HADOOP-5980-2.patch
Attaching patch merging with lastest patch on HADOOP-5981
> LD_LIBRARY_PATH not passed to tasks spawned off by LinuxTaskController
> ----------------------------------------------------------------------
>
> Key: HADOOP-5980
> URL: https://issues.apache.org/jira/browse/HADOOP-5980
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Sreekanth Ramakrishnan
> Assignee: Sreekanth Ramakrishnan
> Attachments: HADOOP-5980-1.patch, HADOOP-5980-2.patch
>
>
> Currently, task spawned off by {{LinuxTaskController}} don't get LD_LIBRARY_PATH in their environment. The tasks should get same LD_LIBRARY_PATH value as when spawned off by {{DefaultTaskController}}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5980) LD_LIBRARY_PATH not passed to tasks
spawned off by LinuxTaskController
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718710#action_12718710 ]
Hemanth Yamijala commented on HADOOP-5980:
------------------------------------------
Looks fine to me. +1.
> LD_LIBRARY_PATH not passed to tasks spawned off by LinuxTaskController
> ----------------------------------------------------------------------
>
> Key: HADOOP-5980
> URL: https://issues.apache.org/jira/browse/HADOOP-5980
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Sreekanth Ramakrishnan
> Assignee: Sreekanth Ramakrishnan
> Attachments: HADOOP-5980-1.patch, HADOOP-5980-2.patch, HADOOP-5980-3.patch
>
>
> Currently, task spawned off by {{LinuxTaskController}} don't get LD_LIBRARY_PATH in their environment. The tasks should get same LD_LIBRARY_PATH value as when spawned off by {{DefaultTaskController}}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5980) LD_LIBRARY_PATH not passed to tasks
spawned off by LinuxTaskController
Posted by "Sreekanth Ramakrishnan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718714#action_12718714 ]
Sreekanth Ramakrishnan commented on HADOOP-5980:
------------------------------------------------
Result from ant test-patch
{noformat}
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 6 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
{noformat}
> LD_LIBRARY_PATH not passed to tasks spawned off by LinuxTaskController
> ----------------------------------------------------------------------
>
> Key: HADOOP-5980
> URL: https://issues.apache.org/jira/browse/HADOOP-5980
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Sreekanth Ramakrishnan
> Assignee: Sreekanth Ramakrishnan
> Attachments: HADOOP-5980-1.patch, HADOOP-5980-2.patch, HADOOP-5980-3.patch
>
>
> Currently, task spawned off by {{LinuxTaskController}} don't get LD_LIBRARY_PATH in their environment. The tasks should get same LD_LIBRARY_PATH value as when spawned off by {{DefaultTaskController}}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5980) LD_LIBRARY_PATH not passed to tasks
spawned off by LinuxTaskController
Posted by "Sreekanth Ramakrishnan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719077#action_12719077 ]
Sreekanth Ramakrishnan commented on HADOOP-5980:
------------------------------------------------
Ant test passed locally.
> LD_LIBRARY_PATH not passed to tasks spawned off by LinuxTaskController
> ----------------------------------------------------------------------
>
> Key: HADOOP-5980
> URL: https://issues.apache.org/jira/browse/HADOOP-5980
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Sreekanth Ramakrishnan
> Assignee: Sreekanth Ramakrishnan
> Attachments: HADOOP-5980-1.patch, HADOOP-5980-2.patch, HADOOP-5980-3.patch
>
>
> Currently, task spawned off by {{LinuxTaskController}} don't get LD_LIBRARY_PATH in their environment. The tasks should get same LD_LIBRARY_PATH value as when spawned off by {{DefaultTaskController}}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5980) LD_LIBRARY_PATH not passed to tasks
spawned off by LinuxTaskController
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hemanth Yamijala updated HADOOP-5980:
-------------------------------------
Attachment: hadoop-5980-v20.patch
This patch is for earlier version of Hadoop. Not to be committed.
> LD_LIBRARY_PATH not passed to tasks spawned off by LinuxTaskController
> ----------------------------------------------------------------------
>
> Key: HADOOP-5980
> URL: https://issues.apache.org/jira/browse/HADOOP-5980
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Sreekanth Ramakrishnan
> Assignee: Sreekanth Ramakrishnan
> Fix For: 0.21.0
>
> Attachments: HADOOP-5980-1.patch, HADOOP-5980-2.patch, HADOOP-5980-3.patch, hadoop-5980-v20.patch
>
>
> Currently, task spawned off by {{LinuxTaskController}} don't get LD_LIBRARY_PATH in their environment. The tasks should get same LD_LIBRARY_PATH value as when spawned off by {{DefaultTaskController}}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5980) LD_LIBRARY_PATH not passed to tasks
spawned off by LinuxTaskController
Posted by "Sreekanth Ramakrishnan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716545#action_12716545 ]
Sreekanth Ramakrishnan commented on HADOOP-5980:
------------------------------------------------
The issue is because linux does not pass LD_LIBRARY_PATH in list of environment to setuid/setgid executables.
> LD_LIBRARY_PATH not passed to tasks spawned off by LinuxTaskController
> ----------------------------------------------------------------------
>
> Key: HADOOP-5980
> URL: https://issues.apache.org/jira/browse/HADOOP-5980
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Sreekanth Ramakrishnan
> Assignee: Sreekanth Ramakrishnan
>
> Currently, task spawned off by {{LinuxTaskController}} don't get LD_LIBRARY_PATH in their environment. The tasks should get same LD_LIBRARY_PATH value as when spawned off by {{DefaultTaskController}}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5980) LD_LIBRARY_PATH not passed to tasks
spawned off by LinuxTaskController
Posted by "Sreekanth Ramakrishnan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sreekanth Ramakrishnan updated HADOOP-5980:
-------------------------------------------
Attachment: HADOOP-5980-3.patch
Attaching a patch incorporating Hemanths comments.
> LD_LIBRARY_PATH not passed to tasks spawned off by LinuxTaskController
> ----------------------------------------------------------------------
>
> Key: HADOOP-5980
> URL: https://issues.apache.org/jira/browse/HADOOP-5980
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Sreekanth Ramakrishnan
> Assignee: Sreekanth Ramakrishnan
> Attachments: HADOOP-5980-1.patch, HADOOP-5980-2.patch, HADOOP-5980-3.patch
>
>
> Currently, task spawned off by {{LinuxTaskController}} don't get LD_LIBRARY_PATH in their environment. The tasks should get same LD_LIBRARY_PATH value as when spawned off by {{DefaultTaskController}}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5980) LD_LIBRARY_PATH not passed to tasks
spawned off by LinuxTaskController
Posted by "Sreekanth Ramakrishnan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sreekanth Ramakrishnan updated HADOOP-5980:
-------------------------------------------
Status: Patch Available (was: Open)
> LD_LIBRARY_PATH not passed to tasks spawned off by LinuxTaskController
> ----------------------------------------------------------------------
>
> Key: HADOOP-5980
> URL: https://issues.apache.org/jira/browse/HADOOP-5980
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Sreekanth Ramakrishnan
> Assignee: Sreekanth Ramakrishnan
> Attachments: HADOOP-5980-1.patch, HADOOP-5980-2.patch, HADOOP-5980-3.patch
>
>
> Currently, task spawned off by {{LinuxTaskController}} don't get LD_LIBRARY_PATH in their environment. The tasks should get same LD_LIBRARY_PATH value as when spawned off by {{DefaultTaskController}}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5980) LD_LIBRARY_PATH not passed to tasks
spawned off by LinuxTaskController
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719591#action_12719591 ]
Hudson commented on HADOOP-5980:
--------------------------------
Integrated in Hadoop-trunk #867 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/867/])
> LD_LIBRARY_PATH not passed to tasks spawned off by LinuxTaskController
> ----------------------------------------------------------------------
>
> Key: HADOOP-5980
> URL: https://issues.apache.org/jira/browse/HADOOP-5980
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Sreekanth Ramakrishnan
> Assignee: Sreekanth Ramakrishnan
> Fix For: 0.21.0
>
> Attachments: HADOOP-5980-1.patch, HADOOP-5980-2.patch, HADOOP-5980-3.patch
>
>
> Currently, task spawned off by {{LinuxTaskController}} don't get LD_LIBRARY_PATH in their environment. The tasks should get same LD_LIBRARY_PATH value as when spawned off by {{DefaultTaskController}}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5980) LD_LIBRARY_PATH not passed to tasks
spawned off by LinuxTaskController
Posted by "Sreekanth Ramakrishnan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sreekanth Ramakrishnan updated HADOOP-5980:
-------------------------------------------
Attachment: HADOOP-5980-1.patch
Attaching a patch which fixes this issue. This patch can be applied after HADOOP-5981 patch has been applied.
> LD_LIBRARY_PATH not passed to tasks spawned off by LinuxTaskController
> ----------------------------------------------------------------------
>
> Key: HADOOP-5980
> URL: https://issues.apache.org/jira/browse/HADOOP-5980
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Sreekanth Ramakrishnan
> Assignee: Sreekanth Ramakrishnan
> Attachments: HADOOP-5980-1.patch
>
>
> Currently, task spawned off by {{LinuxTaskController}} don't get LD_LIBRARY_PATH in their environment. The tasks should get same LD_LIBRARY_PATH value as when spawned off by {{DefaultTaskController}}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-5980) LD_LIBRARY_PATH not passed to tasks
spawned off by LinuxTaskController
Posted by "Sreekanth Ramakrishnan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sreekanth Ramakrishnan reassigned HADOOP-5980:
----------------------------------------------
Assignee: Sreekanth Ramakrishnan
> LD_LIBRARY_PATH not passed to tasks spawned off by LinuxTaskController
> ----------------------------------------------------------------------
>
> Key: HADOOP-5980
> URL: https://issues.apache.org/jira/browse/HADOOP-5980
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Sreekanth Ramakrishnan
> Assignee: Sreekanth Ramakrishnan
>
> Currently, task spawned off by {{LinuxTaskController}} don't get LD_LIBRARY_PATH in their environment. The tasks should get same LD_LIBRARY_PATH value as when spawned off by {{DefaultTaskController}}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5980) LD_LIBRARY_PATH not passed to tasks
spawned off by LinuxTaskController
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718411#action_12718411 ]
Hemanth Yamijala commented on HADOOP-5980:
------------------------------------------
Code changes look ok. We are not adding newlines to the exported environment. Is this OK ?
Some comments on the test case:
- testEnvironment: The test shouldRun() should be made.
- If the test in TestMiniMRChildTask fails, we will not do cleanup operations like deleting the outDir. I think we should call the runTestTaskEnv method in a try...catch...finally block and in the finally, do cleanup.
- Do we need to check if the job execution fails ?
> LD_LIBRARY_PATH not passed to tasks spawned off by LinuxTaskController
> ----------------------------------------------------------------------
>
> Key: HADOOP-5980
> URL: https://issues.apache.org/jira/browse/HADOOP-5980
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Sreekanth Ramakrishnan
> Assignee: Sreekanth Ramakrishnan
> Attachments: HADOOP-5980-1.patch, HADOOP-5980-2.patch
>
>
> Currently, task spawned off by {{LinuxTaskController}} don't get LD_LIBRARY_PATH in their environment. The tasks should get same LD_LIBRARY_PATH value as when spawned off by {{DefaultTaskController}}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5980) LD_LIBRARY_PATH not passed to tasks
spawned off by LinuxTaskController
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hemanth Yamijala updated HADOOP-5980:
-------------------------------------
Resolution: Fixed
Fix Version/s: 0.21.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Sreekanth !
> LD_LIBRARY_PATH not passed to tasks spawned off by LinuxTaskController
> ----------------------------------------------------------------------
>
> Key: HADOOP-5980
> URL: https://issues.apache.org/jira/browse/HADOOP-5980
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Sreekanth Ramakrishnan
> Assignee: Sreekanth Ramakrishnan
> Fix For: 0.21.0
>
> Attachments: HADOOP-5980-1.patch, HADOOP-5980-2.patch, HADOOP-5980-3.patch
>
>
> Currently, task spawned off by {{LinuxTaskController}} don't get LD_LIBRARY_PATH in their environment. The tasks should get same LD_LIBRARY_PATH value as when spawned off by {{DefaultTaskController}}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.