You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/08/10 01:19:50 UTC

[GitHub] [flink] sunjincheng121 commented on a change in pull request #9396: [FLINK-13473][table-blink] Add stream Windowed FlatAggregate support for blink planner

sunjincheng121 commented on a change in pull request #9396: [FLINK-13473][table-blink] Add stream Windowed FlatAggregate support for blink planner
URL: https://github.com/apache/flink/pull/9396#discussion_r312684777
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/agg/AggsHandlerCodeGenerator.scala
 ##########
 @@ -906,6 +1088,7 @@ object AggsHandlerCodeGenerator {
   val COLLECTOR_TERM = "out"
   val MEMBER_COLLECTOR_TERM = "convertCollector"
   val CONVERT_COLLECTOR_TYPE_TERM = "ConvertCollector"
+  val KEY_TERM = "groupKey"
 
 Review comment:
   Sounds good, and how about NAMESPACE_TABLE_AGG_KEY_TERM. It looks more consistent with other variables which end with _TERM. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services