You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/10 09:43:59 UTC
[GitHub] [apisix-dashboard] nic-chen opened a new issue #1468: discuss: When import routes, whether duplicate routes should be allowed to be imported
nic-chen opened a new issue #1468:
URL: https://github.com/apache/apisix-dashboard/issues/1468
The current practice is to directly reject duplicate routes
The reason for this is that users may import many routes at once.
It may even import the same file multiple times due to misoperation
This will result in a lot of useless data.
But on the other hand, manually creating routes can create duplicate routes.
Welcome discuss.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #1468: discuss: When import routes, whether duplicate routes should be allowed to be imported
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1468:
URL: https://github.com/apache/apisix-dashboard/issues/1468#issuecomment-804156876
> Why the duplicate also needs to be updated? IMO, if the duplicate route is not updated, they are two different routes.
that is why I think it'll cause a but. because there are two different routes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #1468: discuss: When import routes, whether duplicate routes should be allowed to be imported
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1468:
URL: https://github.com/apache/apisix-dashboard/issues/1468#issuecomment-781023656
> I think the routing conditions are exactly the same, it can be regarded as duplicate. Condition fields include uri, uris, host, hosts, vars, remote_addr, remote_addrs and priority etc.
It is not a good way.
> it does not have to be an ID, as long as it can identify the uniqueness, and if the uniqueness is repeated, it can be de duplicated
this way is better
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1468: discuss: When import routes, whether duplicate routes should be allowed to be imported
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1468:
URL: https://github.com/apache/apisix-dashboard/issues/1468#issuecomment-780976576
@membphis @Jaycean
I think the routing conditions are exactly the same, it can be regarded as duplicate. Condition fields include uri, uris, host, hosts, vars, remote_addr, remote_addrs and priority etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #1468: discuss: When import routes, whether duplicate routes should be allowed to be imported
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1468:
URL: https://github.com/apache/apisix-dashboard/issues/1468#issuecomment-803594493
> I think it's good. Because the duplicate route is harmless, we can keep it.
When the user needs to update the route, this duplicate route also needs to be updated.
If the duplicate route is not updated, the new route will not take effect and cause bugs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] batman-ezio commented on issue #1468: discuss: When import routes, whether duplicate routes should be allowed to be imported
Posted by GitBox <gi...@apache.org>.
batman-ezio commented on issue #1468:
URL: https://github.com/apache/apisix-dashboard/issues/1468#issuecomment-800875254
I see this PR https://github.com/apache/apisix-dashboard/pull/1606/files
so now `duplicate is not allowed`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1468: discuss: When import routes, whether duplicate routes should be allowed to be imported
Posted by GitBox <gi...@apache.org>.
starsz commented on issue #1468:
URL: https://github.com/apache/apisix-dashboard/issues/1468#issuecomment-778801897
> How to know that the two imported routes are the same? Is there a unique field like ID?
Maybe we need to compare the field and value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] github-actions[bot] closed issue #1468: discuss: When import routes, whether duplicate routes should be allowed to be imported
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed issue #1468:
URL: https://github.com/apache/apisix-dashboard/issues/1468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #1468: discuss: When import routes, whether duplicate routes should be allowed to be imported
Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #1468:
URL: https://github.com/apache/apisix-dashboard/issues/1468#issuecomment-781184877
How about leave the choice to users? which means when users import route, they can choose
* `duplicate is allowed`: that means any routes in right configuration can be imported, no matter it is duplicate or not, as APISIX allows to create the same route, IMHO, this operation is reasonable
* `Cover the duplicate data`: that means if the route to be imported is duplicate with the one already in APISIX, we will use the latest one to cover the old one. and we can set this option as a default one. Then what is a duplicate route? Maybe we can circle a minimum set
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis edited a comment on issue #1468: discuss: When import routes, whether duplicate routes should be allowed to be imported
Posted by GitBox <gi...@apache.org>.
membphis edited a comment on issue #1468:
URL: https://github.com/apache/apisix-dashboard/issues/1468#issuecomment-804156876
> Why the duplicate also needs to be updated? IMO, if the duplicate route is not updated, they are two different routes.
that is why I think it'll cause a bug. because there are two different routes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1468: discuss: When import routes, whether duplicate routes should be allowed to be imported
Posted by GitBox <gi...@apache.org>.
starsz commented on issue #1468:
URL: https://github.com/apache/apisix-dashboard/issues/1468#issuecomment-803600513
> I see this PR https://github.com/apache/apisix-dashboard/pull/1606/files
> so now `duplicate is not allowed`?
This issue is for the situation when we import routes.
> When the user needs to update the route, this duplicate route also needs to be updated.
If the duplicate route is not updated, the new route will not take effect and cause bugs.
Why the duplicate also needs to be updated? IMO, if the duplicate route is not updated, they are two different routes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on issue #1468: discuss: When import routes, whether duplicate routes should be allowed to be imported
Posted by GitBox <gi...@apache.org>.
Jaycean commented on issue #1468:
URL: https://github.com/apache/apisix-dashboard/issues/1468#issuecomment-780970940
Yes, when I finished importing and exporting, I discussed this problem with @liuxiran @imjoey
Apisix allows users to create multiple duplicate routes, which adds more flexibility.
If the import does not remove the duplicate data, it is necessary to add the unique identification of the route (it does not have to be an ID, as long as it can identify the uniqueness, and if the uniqueness is repeated, it can be de duplicated), so that the dirty data of the imported route can not be generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] github-actions[bot] commented on issue #1468: discuss: When import routes, whether duplicate routes should be allowed to be imported
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #1468:
URL: https://github.com/apache/apisix-dashboard/issues/1468#issuecomment-943208870
This issue has been marked as stale due to 30 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #1468: discuss: When import routes, whether duplicate routes should be allowed to be imported
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1468:
URL: https://github.com/apache/apisix-dashboard/issues/1468#issuecomment-777222892
How to know that the two imported routes are the same? Is there a unique field like ID?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1468: discuss: When import routes, whether duplicate routes should be allowed to be imported
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1468:
URL: https://github.com/apache/apisix-dashboard/issues/1468#issuecomment-782792334
> * duplicate is allowed
`duplicate is allowed` is good. but I'm not sure about `Cover the duplicate data`, there are certain risks in doing so.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #1468: discuss: When import routes, whether duplicate routes should be allowed to be imported
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1468:
URL: https://github.com/apache/apisix-dashboard/issues/1468#issuecomment-782814027
> duplicate is allowed
> Cover the duplicate data
they are both not good.
Are there any fields like ID to identify a specific object (such as route, upstream, etc.)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #1468: discuss: When import routes, whether duplicate routes should be allowed to be imported
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1468:
URL: https://github.com/apache/apisix-dashboard/issues/1468#issuecomment-807012310
I think everyone is right, sorry for causing you trouble.
https://github.com/apache/apisix-dashboard/issues/1468#issuecomment-781184877 is a good way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1468: discuss: When import routes, whether duplicate routes should be allowed to be imported
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1468:
URL: https://github.com/apache/apisix-dashboard/issues/1468#issuecomment-782820288
> Are there any fields like ID to identify a specific object (such as route, upstream, etc.)?
the data exported from APISIX have ID for routes, but data generated from code or other sources may not have
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1468: discuss: When import routes, whether duplicate routes should be allowed to be imported
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1468:
URL: https://github.com/apache/apisix-dashboard/issues/1468#issuecomment-776582212
cc @liuxiran @imjoey @Jaycean @juzhiyuan @membphis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1468: discuss: When import routes, whether duplicate routes should be allowed to be imported
Posted by GitBox <gi...@apache.org>.
starsz commented on issue #1468:
URL: https://github.com/apache/apisix-dashboard/issues/1468#issuecomment-782858798
`duplicate is allowed`
I think it's good. Because the duplicate route is harmless, we can keep it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] github-actions[bot] commented on issue #1468: discuss: When import routes, whether duplicate routes should be allowed to be imported
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #1468:
URL: https://github.com/apache/apisix-dashboard/issues/1468#issuecomment-954620671
This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org