[GitHub] ccollins476ad commented on a change in pull request #1593: console newtmgr coexistance

[GitBox <gi...@apache.org>]

ccollins476ad commented on a change in pull request #1593: console newtmgr coexistance
URL: https://github.com/apache/mynewt-core/pull/1593#discussion_r247291516
 
 

 ##########
 File path: sys/console/full/syscfg.yml
 ##########
 @@ -93,6 +93,10 @@ syscfg.defs:
             affect device performance due to more frequent polling.
         value: 250
 
+    CONSOLE_DEFAULT_LOCK_TIMEOUT:
+        description: 'Default timeout (int ticks) for console_lock() function.'
+        value: 10
 
 Review comment:
   10 is <=100ms on most systems. This feels a bit short to me.  Console output is slow, and I can imagine this timeout expiring when multiple tasks want to write.  Do you think something longer, such as 1 second, would be better?
   
   Also, I would not use OS ticks are the units here.  Since OS ticks vary by platform, the default is not consistent.  I would use milliseconds here, and define a `CONSOLE_LOCK_TIMEOUT_TICKS` macro in the code.
   
   Finally, this is a bit of a nitpick, but I don't think this setting name should contain `DEFAULT`.  It is not possible to override this setting at runtime, so it is more than just a default; it is the setting value itself!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services