You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2017/07/20 21:16:07 UTC
Review Request 61007: [ATLAS-1979]: Update storm model relationship
category and fix for UT and Coverity scan issues
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61007/
-----------------------------------------------------------
Review request for atlas and Madhan Neethiraj.
Bugs: ATLAS-1979
https://issues.apache.org/jira/browse/ATLAS-1979
Repository: atlas
Description
-------
Update storm_topology_nodes relationshipCategory from ASSOCIATION to AGGREGATION
Fix the following UT failures:
_Failed tests:
AtlasRelationshipStoreHardDeleteV1Test>AtlasRelationshipStoreV1Test.testDepartmentEmployeeEntitiesUsingRelationship:172 expected:<null> but was:<[]>
AtlasRelationshipStoreSoftDeleteV1Test>AtlasRelationshipStoreV1Test.testDepartmentEmployeeEntitiesUsingRelationship:172 expected:<null> but was:<[]>_
Fix coverity scan issues flagged in last report related to ATLAS-1959
Diffs
-----
addons/models/0080-storm_model.json b008c7ab
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 1282be5e
repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateSoftDeleteTest.java c5eda370
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1Test.java 31efe868
Diff: https://reviews.apache.org/r/61007/diff/1/
Testing
-------
mvn clean package succeeded
Thanks,
Sarath Subramanian
Re: Review Request 61007: [ATLAS-1979]: Update storm model
relationship category and fix for UT and Coverity scan issues
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61007/#review181089
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On July 20, 2017, 9:16 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61007/
> -----------------------------------------------------------
>
> (Updated July 20, 2017, 9:16 p.m.)
>
>
> Review request for atlas and Madhan Neethiraj.
>
>
> Bugs: ATLAS-1979
> https://issues.apache.org/jira/browse/ATLAS-1979
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Update storm_topology_nodes relationshipCategory from ASSOCIATION to AGGREGATION
> Fix the following UT failures:
> _Failed tests:
> AtlasRelationshipStoreHardDeleteV1Test>AtlasRelationshipStoreV1Test.testDepartmentEmployeeEntitiesUsingRelationship:172 expected:<null> but was:<[]>
> AtlasRelationshipStoreSoftDeleteV1Test>AtlasRelationshipStoreV1Test.testDepartmentEmployeeEntitiesUsingRelationship:172 expected:<null> but was:<[]>_
> Fix coverity scan issues flagged in last report related to ATLAS-1959
>
>
> Diffs
> -----
>
> addons/models/0080-storm_model.json b008c7ab
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 1282be5e
> repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateSoftDeleteTest.java c5eda370
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1Test.java 31efe868
>
>
> Diff: https://reviews.apache.org/r/61007/diff/1/
>
>
> Testing
> -------
>
> mvn clean package succeeded
>
>
> Thanks,
>
> Sarath Subramanian
>
>