You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/02/09 23:11:20 UTC
[GitHub] [arrow] bjchambers opened a new pull request #9460: ARROW-11577: [Rust] Fix Array transform on strings
bjchambers opened a new pull request #9460:
URL: https://github.com/apache/arrow/pull/9460
Specifically, this fixes a bug found when applying `concat` to slices of
input `StringArray`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb closed pull request #9460: ARROW-11577: [Rust] Fix Array transform on strings
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #9460:
URL: https://github.com/apache/arrow/pull/9460
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on a change in pull request #9460: ARROW-11577: [Rust] Fix Array transform on strings
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #9460:
URL: https://github.com/apache/arrow/pull/9460#discussion_r573652531
##########
File path: rust/arrow/src/compute/kernels/concat.rs
##########
@@ -390,4 +390,35 @@ mod tests {
Ok(())
}
+
+ #[test]
+ fn test_string_array_slices() -> Result<()> {
Review comment:
I ran these tests without the fix and they fail in this way:
```
---- compute::kernels::concat::tests::test_string_array_slices stdout ----
thread 'compute::kernels::concat::tests::test_string_array_slices' panicked at 'range end index 8 out of range for slice of length 7', arrow/src/array/transform/variable_size.rs:38:23
---- compute::kernels::concat::tests::test_string_array_with_null_slices stdout ----
thread 'compute::kernels::concat::tests::test_string_array_with_null_slices' panicked at 'range end index 6 out of range for slice of length 5', arrow/src/array/transform/variable_size.rs:38:23
```
👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] bjchambers commented on pull request #9460: ARROW-11577: [Rust] Fix Array transform on strings
Posted by GitBox <gi...@apache.org>.
bjchambers commented on pull request #9460:
URL: https://github.com/apache/arrow/pull/9460#issuecomment-776306723
https://issues.apache.org/jira/projects/ARROW/issues/ARROW-11577
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9460: ARROW-11577: [Rust] Fix Array transform on strings
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9460:
URL: https://github.com/apache/arrow/pull/9460#issuecomment-776306763
https://issues.apache.org/jira/browse/ARROW-11577
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org