[jira] [Commented] (AIRFLOW-1772) Google Updated Sensor doesnt work with CRON expressions

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16739838#comment-16739838 ] 

ASF GitHub Bot commented on AIRFLOW-1772:
-----------------------------------------

stale[bot] commented on pull request #2747: AIRFLOW-1772: Fix bug with handling cron expressions as an schedule i…
URL: https://github.com/apache/airflow/pull/2747
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Google Updated Sensor doesnt work with CRON expressions 
> --------------------------------------------------------
>
>                 Key: AIRFLOW-1772
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-1772
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: gcp
>            Reporter: sam elamin
>            Priority: Major
>
> Hi
> I noticed that the [Update Sensor|https://github.com/apache/incubator-airflow/blob/master/airflow/contrib/sensors/gcs_sensor.py#L73] does not work with a cron expression set as the schedule interval
> According to the airflow docs a scheduler interval can be a timedelta or a string
> When its a cron expression the schedule is a string and hence this [line | https://github.com/apache/incubator-airflow/blob/master/airflow/contrib/sensors/gcs_sensor.py#L70] breaks 
> the error is below
> ''str' object is not callable'
> Ideally that line should check if the interval is a cron expression and if it is convert it to a time delta 
> Also as a side note i noticed that the update sensor doesnt match regex and has to be exact, surly adding regex support here would make sense since the gsutil cli does this as well



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)