You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/29 11:01:41 UTC

[GitHub] [beam] RustedBones commented on pull request #16271: [BEAM-8388] Make sdk-java-core compatible with avro 1.8 & 1.9

RustedBones commented on PR #16271:
URL: https://github.com/apache/beam/pull/16271#issuecomment-1113175873

   I've addressed the last comments. Is there anything else you'd want to be improved ?
   I still think this is a relevant change to enable users to move to avro 1.9 if they want to. Then it is up to the maintainer to see if it is fine to:
   - drop the `timestamp-millis` logical type conversion on avro reflect (will require custom factories and coders).
   - Avro 1.9 users should manually add the Joda `DateTime` conversion since Beam's copy is removed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org