You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@crail.apache.org by pe...@apache.org on 2018/04/10 11:19:50 UTC

[11/16] incubator-crail git commit: NvmfStorageClient: isValid -> isAlive

NvmfStorageClient: isValid -> isAlive

Change method name from isValid to isAlive. isValid can be
misinterpreted by the users that he misconfigured the system.

Signed-off-by: Jonas Pfefferle <pe...@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/incubator-crail/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-crail/commit/a9162a28
Tree: http://git-wip-us.apache.org/repos/asf/incubator-crail/tree/a9162a28
Diff: http://git-wip-us.apache.org/repos/asf/incubator-crail/diff/a9162a28

Branch: refs/heads/master
Commit: a9162a28a6e189a0c56f4916d0f3f63dec59dfdf
Parents: 4caf5a0
Author: Jonas Pfefferle <pe...@apache.org>
Authored: Tue Apr 10 10:51:08 2018 +0200
Committer: Jonas Pfefferle <pe...@apache.org>
Committed: Tue Apr 10 13:19:03 2018 +0200

----------------------------------------------------------------------
 .../java/org/apache/crail/storage/nvmf/NvmfStorageClient.java  | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-crail/blob/a9162a28/storage-nvmf/src/main/java/org/apache/crail/storage/nvmf/NvmfStorageClient.java
----------------------------------------------------------------------
diff --git a/storage-nvmf/src/main/java/org/apache/crail/storage/nvmf/NvmfStorageClient.java b/storage-nvmf/src/main/java/org/apache/crail/storage/nvmf/NvmfStorageClient.java
index 1cec887..09a8048 100644
--- a/storage-nvmf/src/main/java/org/apache/crail/storage/nvmf/NvmfStorageClient.java
+++ b/storage-nvmf/src/main/java/org/apache/crail/storage/nvmf/NvmfStorageClient.java
@@ -68,7 +68,7 @@ public class NvmfStorageClient implements StorageClient {
 		});
 	}
 
-	boolean isValid() {
+	boolean isAlive() {
 		return keepAliveThread.isAlive();
 	}
 
@@ -97,8 +97,8 @@ public class NvmfStorageClient implements StorageClient {
 	}
 
 	public synchronized StorageEndpoint createEndpoint(DataNodeInfo info) throws IOException {
-		if (!isValid()) {
-			throw new IOException("Storage client state not valid");
+		if (!isAlive()) {
+			throw new IOException("Storage client is not alive");
 		}
 		NvmfStorageEndpoint endpoint = new NvmfStorageEndpoint(getEndpointGroup(), info, statistics, bufferCache);
 		endpoints.add(endpoint);