You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by "angela (Resolved) (JIRA)" <ji...@apache.org> on 2012/04/10 15:31:17 UTC
[jira] [Resolved] (OAK-55) Provide reasonable way to set property
on NodeStateEditor
[ https://issues.apache.org/jira/browse/OAK-55?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
angela resolved OAK-55.
-----------------------
Resolution: Fixed
fixed as suggested and adjusted all usages.
i was a little bit surprised in how many places we already had
that setProperty(new KernelPropertyState(name, value)).
> Provide reasonable way to set property on NodeStateEditor
> ---------------------------------------------------------
>
> Key: OAK-55
> URL: https://issues.apache.org/jira/browse/OAK-55
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Reporter: angela
> Assignee: angela
>
> currently properties are add/modified on the NodeStateEditor using: void setProperty(PropertyState state);
> the consequence of that is that every single usage of that method needs to know the details
> of how to create a property state. IMO that's really bad practice and should be refactored.
> i would suggest to change it to something like
> - setProperty(String name, Scalar value)
> - setProperty(String name, List<Scalar> values)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Resolved] (OAK-55) Provide reasonable way to set property
on NodeStateEditor
Posted by Michael Dürig <md...@apache.org>.
On 10.4.12 14:31, angela (Resolved) (JIRA) wrote:
>
> [ https://issues.apache.org/jira/browse/OAK-55?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> angela resolved OAK-55.
> -----------------------
>
> Resolution: Fixed
>
> fixed as suggested and adjusted all usages.
> i was a little bit surprised in how many places we already had
> that setProperty(new KernelPropertyState(name, value)).
Half of the usages is from test cases.
Michael