You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/08/19 17:07:01 UTC
[GitHub] [hbase] bharathv opened a new pull request #2280: HBASE-18095 branch-1 backport (WIP)
bharathv opened a new pull request #2280:
URL: https://github.com/apache/hbase/pull/2280
Will keep piling on commits on to this PR in the coming days as and when I find time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2280: HBASE-18095 branch-1 umbrella PR
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2280:
URL: https://github.com/apache/hbase/pull/2280#issuecomment-693758866
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 39s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 2s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 37 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 49s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 7m 50s | branch-1 passed |
| +1 :green_heart: | compile | 1m 39s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 1m 45s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 13m 15s | branch-1 passed |
| +1 :green_heart: | shadedjars | 2m 57s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 49s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 5m 44s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 2m 43s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 18m 17s | branch-1 passed |
| -0 :warning: | patch | 3m 30s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 25s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 53s | the patch passed |
| +1 :green_heart: | compile | 1m 39s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | cc | 1m 39s | the patch passed |
| +1 :green_heart: | javac | 1m 39s | the patch passed |
| +1 :green_heart: | compile | 1m 46s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | cc | 1m 46s | the patch passed |
| +1 :green_heart: | javac | 1m 46s | the patch passed |
| -1 :x: | checkstyle | 0m 56s | hbase-client: The patch generated 20 new + 737 unchanged - 34 fixed = 757 total (was 771) |
| -1 :x: | checkstyle | 2m 31s | hbase-server: The patch generated 99 new + 2098 unchanged - 51 fixed = 2197 total (was 2149) |
| -1 :x: | checkstyle | 6m 23s | root: The patch generated 117 new + 2851 unchanged - 83 fixed = 2968 total (was 2934) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 1s | The patch has 1 ill-formed XML file(s). |
| +1 :green_heart: | shadedjars | 2m 49s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 4m 40s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | hbaseprotoc | 4m 20s | the patch passed |
| +1 :green_heart: | javadoc | 3m 40s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 5m 42s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 19m 44s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 156m 47s | root in the patch failed. |
| +1 :green_heart: | asflicense | 2m 46s | The patch does not generate ASF License warnings. |
| | | 285m 51s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | pom.xml |
| Failed junit tests | hadoop.hbase.client.TestFromClientSide |
| | hadoop.hbase.util.TestHBaseFsck |
| | hadoop.hbase.snapshot.TestExportSnapshotWithTemporaryDirectory |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/23/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2280 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool xml |
| uname | Linux 42fcbcee26ea 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2280/out/precommit/personality/provided.sh |
| git revision | branch-1 / 7801b45 |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/23/artifact/out/diff-checkstyle-hbase-client.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/23/artifact/out/diff-checkstyle-hbase-server.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/23/artifact/out/diff-checkstyle-root.txt |
| xml | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/23/artifact/out/xml.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/23/artifact/out/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/23/testReport/ |
| Max. process+thread count | 4205 (vs. ulimit of 10000) |
| modules | C: hbase-protocol hbase-common hbase-client hbase-server hbase-rsgroup . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/23/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell commented on a change in pull request #2280: HBASE-18095 branch-1 umbrella PR
Posted by GitBox <gi...@apache.org>.
apurtell commented on a change in pull request #2280:
URL: https://github.com/apache/hbase/pull/2280#discussion_r489026637
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterRegistry.java
##########
@@ -0,0 +1,266 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.client;
+
+import static org.apache.hadoop.hbase.util.DNS.getMasterHostname;
+import com.google.common.base.Preconditions;
+import com.google.common.base.Strings;
+import com.google.common.collect.ImmutableMap;
+import com.google.common.collect.ImmutableSet;
+import com.google.common.net.HostAndPort;
+import com.google.protobuf.Message;
+import com.google.protobuf.RpcController;
+import java.io.IOException;
+import java.net.UnknownHostException;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+import java.util.concurrent.ThreadLocalRandom;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseIOException;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.HRegionLocation;
+import org.apache.hadoop.hbase.RegionLocations;
+import org.apache.hadoop.hbase.ServerName;
+import org.apache.hadoop.hbase.classification.InterfaceAudience;
+import org.apache.hadoop.hbase.exceptions.ClientExceptionsUtil;
+import org.apache.hadoop.hbase.exceptions.MasterRegistryFetchException;
+import org.apache.hadoop.hbase.ipc.BlockingRpcCallback;
+import org.apache.hadoop.hbase.ipc.HBaseRpcController;
+import org.apache.hadoop.hbase.ipc.RpcClient;
+import org.apache.hadoop.hbase.ipc.RpcClientFactory;
+import org.apache.hadoop.hbase.ipc.RpcControllerFactory;
+import org.apache.hadoop.hbase.protobuf.ProtobufUtil;
+import org.apache.hadoop.hbase.protobuf.generated.HBaseProtos;
+import org.apache.hadoop.hbase.security.User;
+
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.ClientMetaService;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetClusterIdRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetClusterIdResponse;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMastersRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMastersResponse;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMastersResponseEntry;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMetaRegionLocationsRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMetaRegionLocationsResponse;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetNumLiveRSRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetNumLiveRSResponse;
+
+/**
+ * Master based registry implementation. Makes RPCs to the configured master addresses from config
+ * {@value org.apache.hadoop.hbase.HConstants#MASTER_ADDRS_KEY}. All the registry methods are
+ * blocking unlike implementations in other branches.
+ */
+@InterfaceAudience.Private
+public class MasterRegistry implements ConnectionRegistry {
+ private static final String MASTER_ADDRS_CONF_SEPARATOR = ",";
+
+ private volatile ImmutableMap<String, ClientMetaService.Interface> masterAddr2Stub;
+
+ // RPC client used to talk to the masters.
+ private RpcClient rpcClient;
+ private RpcControllerFactory rpcControllerFactory;
+ private int rpcTimeoutMs;
+
+ protected MasterAddressRefresher masterAddressRefresher;
+
+ @Override
+ public void init(Connection connection) throws IOException {
+ Configuration conf = connection.getConfiguration();
+ rpcTimeoutMs = (int) Math.min(Integer.MAX_VALUE,
+ conf.getLong(HConstants.HBASE_RPC_TIMEOUT_KEY, HConstants.DEFAULT_HBASE_RPC_TIMEOUT));
+ // XXX: we pass cluster id as null here since we do not have a cluster id yet, we have to fetch
Review comment:
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2280: HBASE-18095 branch-1 backport (WIP)
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2280:
URL: https://github.com/apache/hbase/pull/2280#issuecomment-686898811
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 37s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 1s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 31 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 47s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 7m 54s | branch-1 passed |
| +1 :green_heart: | compile | 1m 39s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 1m 43s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 12m 17s | branch-1 passed |
| +1 :green_heart: | shadedjars | 2m 59s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 29s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 5m 16s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 2m 42s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 17m 18s | branch-1 passed |
| -0 :warning: | patch | 3m 21s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 57s | the patch passed |
| +1 :green_heart: | compile | 1m 43s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | cc | 1m 43s | the patch passed |
| +1 :green_heart: | javac | 1m 43s | the patch passed |
| +1 :green_heart: | compile | 1m 45s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | cc | 1m 45s | the patch passed |
| +1 :green_heart: | javac | 1m 45s | the patch passed |
| -1 :x: | checkstyle | 0m 54s | hbase-client: The patch generated 10 new + 683 unchanged - 31 fixed = 693 total (was 714) |
| -1 :x: | checkstyle | 2m 23s | hbase-server: The patch generated 96 new + 1861 unchanged - 48 fixed = 1957 total (was 1909) |
| -1 :x: | checkstyle | 6m 15s | root: The patch generated 107 new + 2545 unchanged - 80 fixed = 2652 total (was 2625) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 0s | The patch has 1 ill-formed XML file(s). |
| +1 :green_heart: | shadedjars | 2m 46s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 4m 43s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | hbaseprotoc | 3m 55s | the patch passed |
| +1 :green_heart: | javadoc | 3m 23s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 5m 20s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 18m 25s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 154m 50s | root in the patch failed. |
| +1 :green_heart: | asflicense | 2m 19s | The patch does not generate ASF License warnings. |
| | | 276m 57s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | pom.xml |
| Failed junit tests | hadoop.hbase.snapshot.TestExportSnapshotWithTemporaryDirectory |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/14/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2280 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool xml |
| uname | Linux 6e25f9df539c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2280/out/precommit/personality/provided.sh |
| git revision | branch-1 / 76db1e1 |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/14/artifact/out/diff-checkstyle-hbase-client.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/14/artifact/out/diff-checkstyle-hbase-server.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/14/artifact/out/diff-checkstyle-root.txt |
| xml | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/14/artifact/out/xml.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/14/artifact/out/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/14/testReport/ |
| Max. process+thread count | 4443 (vs. ulimit of 10000) |
| modules | C: hbase-protocol hbase-client hbase-server hbase-rsgroup . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/14/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell commented on a change in pull request #2280: HBASE-18095 branch-1 umbrella PR
Posted by GitBox <gi...@apache.org>.
apurtell commented on a change in pull request #2280:
URL: https://github.com/apache/hbase/pull/2280#discussion_r487313143
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
##########
@@ -56,6 +56,7 @@
/** Set this key to {@code true} to enable metrics collection of client requests. */
public static final String CLIENT_SIDE_METRICS_ENABLED_KEY = "hbase.client.metrics.enable";
+ private static final String CNT_BASE = "rpcCount_";
Review comment:
Is this an unrelated change?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java
##########
@@ -1571,43 +1573,31 @@ boolean isMasterRunning() throws ServiceException {
* @throws KeeperException
* @throws ServiceException
*/
- private Object makeStubNoRetries() throws IOException, KeeperException, ServiceException {
- ZooKeeperKeepAliveConnection zkw;
- try {
- zkw = getKeepAliveZooKeeperWatcher();
- } catch (IOException e) {
- ExceptionUtil.rethrowIfInterrupt(e);
- throw new ZooKeeperConnectionException("Can't connect to ZooKeeper", e);
- }
- try {
- checkIfBaseNodeAvailable(zkw);
- ServerName sn = MasterAddressTracker.getMasterAddress(zkw);
- if (sn == null) {
- String msg = "ZooKeeper available but no active master location found";
- LOG.info(msg);
- throw new MasterNotRunningException(msg);
- }
- if (isDeadServer(sn)) {
- throw new MasterNotRunningException(sn + " is dead.");
+ private Object makeStubNoRetries() throws IOException, ServiceException {
+ ServerName sn = registry.getActiveMaster();
+ if (sn == null) {
+ String msg = "ZooKeeper available but no active master location found";
Review comment:
Is this still the correct exception text to emit?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterRegistry.java
##########
@@ -0,0 +1,266 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.client;
+
+import static org.apache.hadoop.hbase.util.DNS.getMasterHostname;
+import com.google.common.base.Preconditions;
+import com.google.common.base.Strings;
+import com.google.common.collect.ImmutableMap;
+import com.google.common.collect.ImmutableSet;
+import com.google.common.net.HostAndPort;
+import com.google.protobuf.Message;
+import com.google.protobuf.RpcController;
+import java.io.IOException;
+import java.net.UnknownHostException;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+import java.util.concurrent.ThreadLocalRandom;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseIOException;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.HRegionLocation;
+import org.apache.hadoop.hbase.RegionLocations;
+import org.apache.hadoop.hbase.ServerName;
+import org.apache.hadoop.hbase.classification.InterfaceAudience;
+import org.apache.hadoop.hbase.exceptions.ClientExceptionsUtil;
+import org.apache.hadoop.hbase.exceptions.MasterRegistryFetchException;
+import org.apache.hadoop.hbase.ipc.BlockingRpcCallback;
+import org.apache.hadoop.hbase.ipc.HBaseRpcController;
+import org.apache.hadoop.hbase.ipc.RpcClient;
+import org.apache.hadoop.hbase.ipc.RpcClientFactory;
+import org.apache.hadoop.hbase.ipc.RpcControllerFactory;
+import org.apache.hadoop.hbase.protobuf.ProtobufUtil;
+import org.apache.hadoop.hbase.protobuf.generated.HBaseProtos;
+import org.apache.hadoop.hbase.security.User;
+
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.ClientMetaService;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetClusterIdRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetClusterIdResponse;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMastersRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMastersResponse;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMastersResponseEntry;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMetaRegionLocationsRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMetaRegionLocationsResponse;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetNumLiveRSRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetNumLiveRSResponse;
+
+/**
+ * Master based registry implementation. Makes RPCs to the configured master addresses from config
+ * {@value org.apache.hadoop.hbase.HConstants#MASTER_ADDRS_KEY}. All the registry methods are
+ * blocking unlike implementations in other branches.
+ */
+@InterfaceAudience.Private
+public class MasterRegistry implements ConnectionRegistry {
+ private static final String MASTER_ADDRS_CONF_SEPARATOR = ",";
+
+ private volatile ImmutableMap<String, ClientMetaService.Interface> masterAddr2Stub;
+
+ // RPC client used to talk to the masters.
+ private RpcClient rpcClient;
+ private RpcControllerFactory rpcControllerFactory;
+ private int rpcTimeoutMs;
+
+ protected MasterAddressRefresher masterAddressRefresher;
+
+ @Override
+ public void init(Connection connection) throws IOException {
+ Configuration conf = connection.getConfiguration();
+ rpcTimeoutMs = (int) Math.min(Integer.MAX_VALUE,
+ conf.getLong(HConstants.HBASE_RPC_TIMEOUT_KEY, HConstants.DEFAULT_HBASE_RPC_TIMEOUT));
+ // XXX: we pass cluster id as null here since we do not have a cluster id yet, we have to fetch
Review comment:
Hmm.
Is there a planned follow up?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
##########
@@ -466,6 +468,9 @@ public void updateRpc(MethodDescriptor method, Message param, CallStats stats) {
if (callsPerServer > 0) {
concurrentCallsPerServerHist.update(callsPerServer);
}
+ // Update the counter that tracks RPCs by type.
+ final String methodName = method.getService().getName() + "_" + method.getName();
Review comment:
Can we break out this change? Metrics are special. They are a separate dimension of compatibility. Having them in a separate commit allows them to get noticed. They should have their own release note. Etc.
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
##########
@@ -466,6 +468,9 @@ public void updateRpc(MethodDescriptor method, Message param, CallStats stats) {
if (callsPerServer > 0) {
concurrentCallsPerServerHist.update(callsPerServer);
}
+ // Update the counter that tracks RPCs by type.
+ final String methodName = method.getService().getName() + "_" + method.getName();
Review comment:
Neat idea but it's coming in from some other work?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
##########
@@ -56,6 +56,7 @@
/** Set this key to {@code true} to enable metrics collection of client requests. */
public static final String CLIENT_SIDE_METRICS_ENABLED_KEY = "hbase.client.metrics.enable";
+ private static final String CNT_BASE = "rpcCount_";
Review comment:
Is this an unrelated change?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java
##########
@@ -1571,43 +1573,31 @@ boolean isMasterRunning() throws ServiceException {
* @throws KeeperException
* @throws ServiceException
*/
- private Object makeStubNoRetries() throws IOException, KeeperException, ServiceException {
- ZooKeeperKeepAliveConnection zkw;
- try {
- zkw = getKeepAliveZooKeeperWatcher();
- } catch (IOException e) {
- ExceptionUtil.rethrowIfInterrupt(e);
- throw new ZooKeeperConnectionException("Can't connect to ZooKeeper", e);
- }
- try {
- checkIfBaseNodeAvailable(zkw);
- ServerName sn = MasterAddressTracker.getMasterAddress(zkw);
- if (sn == null) {
- String msg = "ZooKeeper available but no active master location found";
- LOG.info(msg);
- throw new MasterNotRunningException(msg);
- }
- if (isDeadServer(sn)) {
- throw new MasterNotRunningException(sn + " is dead.");
+ private Object makeStubNoRetries() throws IOException, ServiceException {
+ ServerName sn = registry.getActiveMaster();
+ if (sn == null) {
+ String msg = "ZooKeeper available but no active master location found";
Review comment:
Is this still the correct exception text to emit?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterRegistry.java
##########
@@ -0,0 +1,266 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.client;
+
+import static org.apache.hadoop.hbase.util.DNS.getMasterHostname;
+import com.google.common.base.Preconditions;
+import com.google.common.base.Strings;
+import com.google.common.collect.ImmutableMap;
+import com.google.common.collect.ImmutableSet;
+import com.google.common.net.HostAndPort;
+import com.google.protobuf.Message;
+import com.google.protobuf.RpcController;
+import java.io.IOException;
+import java.net.UnknownHostException;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+import java.util.concurrent.ThreadLocalRandom;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseIOException;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.HRegionLocation;
+import org.apache.hadoop.hbase.RegionLocations;
+import org.apache.hadoop.hbase.ServerName;
+import org.apache.hadoop.hbase.classification.InterfaceAudience;
+import org.apache.hadoop.hbase.exceptions.ClientExceptionsUtil;
+import org.apache.hadoop.hbase.exceptions.MasterRegistryFetchException;
+import org.apache.hadoop.hbase.ipc.BlockingRpcCallback;
+import org.apache.hadoop.hbase.ipc.HBaseRpcController;
+import org.apache.hadoop.hbase.ipc.RpcClient;
+import org.apache.hadoop.hbase.ipc.RpcClientFactory;
+import org.apache.hadoop.hbase.ipc.RpcControllerFactory;
+import org.apache.hadoop.hbase.protobuf.ProtobufUtil;
+import org.apache.hadoop.hbase.protobuf.generated.HBaseProtos;
+import org.apache.hadoop.hbase.security.User;
+
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.ClientMetaService;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetClusterIdRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetClusterIdResponse;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMastersRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMastersResponse;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMastersResponseEntry;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMetaRegionLocationsRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMetaRegionLocationsResponse;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetNumLiveRSRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetNumLiveRSResponse;
+
+/**
+ * Master based registry implementation. Makes RPCs to the configured master addresses from config
+ * {@value org.apache.hadoop.hbase.HConstants#MASTER_ADDRS_KEY}. All the registry methods are
+ * blocking unlike implementations in other branches.
+ */
+@InterfaceAudience.Private
+public class MasterRegistry implements ConnectionRegistry {
+ private static final String MASTER_ADDRS_CONF_SEPARATOR = ",";
+
+ private volatile ImmutableMap<String, ClientMetaService.Interface> masterAddr2Stub;
+
+ // RPC client used to talk to the masters.
+ private RpcClient rpcClient;
+ private RpcControllerFactory rpcControllerFactory;
+ private int rpcTimeoutMs;
+
+ protected MasterAddressRefresher masterAddressRefresher;
+
+ @Override
+ public void init(Connection connection) throws IOException {
+ Configuration conf = connection.getConfiguration();
+ rpcTimeoutMs = (int) Math.min(Integer.MAX_VALUE,
+ conf.getLong(HConstants.HBASE_RPC_TIMEOUT_KEY, HConstants.DEFAULT_HBASE_RPC_TIMEOUT));
+ // XXX: we pass cluster id as null here since we do not have a cluster id yet, we have to fetch
Review comment:
Hmm.
Is there a planned follow up?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
##########
@@ -466,6 +468,9 @@ public void updateRpc(MethodDescriptor method, Message param, CallStats stats) {
if (callsPerServer > 0) {
concurrentCallsPerServerHist.update(callsPerServer);
}
+ // Update the counter that tracks RPCs by type.
+ final String methodName = method.getService().getName() + "_" + method.getName();
Review comment:
Can we break out this change? Metrics are special. They are a separate dimension of compatibility. Having them in a separate commit allows them to get noticed. They should have their own release note. Etc.
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
##########
@@ -466,6 +468,9 @@ public void updateRpc(MethodDescriptor method, Message param, CallStats stats) {
if (callsPerServer > 0) {
concurrentCallsPerServerHist.update(callsPerServer);
}
+ // Update the counter that tracks RPCs by type.
+ final String methodName = method.getService().getName() + "_" + method.getName();
Review comment:
Neat idea but it's coming in from some other work?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
##########
@@ -56,6 +56,7 @@
/** Set this key to {@code true} to enable metrics collection of client requests. */
public static final String CLIENT_SIDE_METRICS_ENABLED_KEY = "hbase.client.metrics.enable";
+ private static final String CNT_BASE = "rpcCount_";
Review comment:
Is this an unrelated change?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java
##########
@@ -1571,43 +1573,31 @@ boolean isMasterRunning() throws ServiceException {
* @throws KeeperException
* @throws ServiceException
*/
- private Object makeStubNoRetries() throws IOException, KeeperException, ServiceException {
- ZooKeeperKeepAliveConnection zkw;
- try {
- zkw = getKeepAliveZooKeeperWatcher();
- } catch (IOException e) {
- ExceptionUtil.rethrowIfInterrupt(e);
- throw new ZooKeeperConnectionException("Can't connect to ZooKeeper", e);
- }
- try {
- checkIfBaseNodeAvailable(zkw);
- ServerName sn = MasterAddressTracker.getMasterAddress(zkw);
- if (sn == null) {
- String msg = "ZooKeeper available but no active master location found";
- LOG.info(msg);
- throw new MasterNotRunningException(msg);
- }
- if (isDeadServer(sn)) {
- throw new MasterNotRunningException(sn + " is dead.");
+ private Object makeStubNoRetries() throws IOException, ServiceException {
+ ServerName sn = registry.getActiveMaster();
+ if (sn == null) {
+ String msg = "ZooKeeper available but no active master location found";
Review comment:
Is this still the correct exception text to emit?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterRegistry.java
##########
@@ -0,0 +1,266 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.client;
+
+import static org.apache.hadoop.hbase.util.DNS.getMasterHostname;
+import com.google.common.base.Preconditions;
+import com.google.common.base.Strings;
+import com.google.common.collect.ImmutableMap;
+import com.google.common.collect.ImmutableSet;
+import com.google.common.net.HostAndPort;
+import com.google.protobuf.Message;
+import com.google.protobuf.RpcController;
+import java.io.IOException;
+import java.net.UnknownHostException;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+import java.util.concurrent.ThreadLocalRandom;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseIOException;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.HRegionLocation;
+import org.apache.hadoop.hbase.RegionLocations;
+import org.apache.hadoop.hbase.ServerName;
+import org.apache.hadoop.hbase.classification.InterfaceAudience;
+import org.apache.hadoop.hbase.exceptions.ClientExceptionsUtil;
+import org.apache.hadoop.hbase.exceptions.MasterRegistryFetchException;
+import org.apache.hadoop.hbase.ipc.BlockingRpcCallback;
+import org.apache.hadoop.hbase.ipc.HBaseRpcController;
+import org.apache.hadoop.hbase.ipc.RpcClient;
+import org.apache.hadoop.hbase.ipc.RpcClientFactory;
+import org.apache.hadoop.hbase.ipc.RpcControllerFactory;
+import org.apache.hadoop.hbase.protobuf.ProtobufUtil;
+import org.apache.hadoop.hbase.protobuf.generated.HBaseProtos;
+import org.apache.hadoop.hbase.security.User;
+
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.ClientMetaService;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetClusterIdRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetClusterIdResponse;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMastersRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMastersResponse;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMastersResponseEntry;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMetaRegionLocationsRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMetaRegionLocationsResponse;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetNumLiveRSRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetNumLiveRSResponse;
+
+/**
+ * Master based registry implementation. Makes RPCs to the configured master addresses from config
+ * {@value org.apache.hadoop.hbase.HConstants#MASTER_ADDRS_KEY}. All the registry methods are
+ * blocking unlike implementations in other branches.
+ */
+@InterfaceAudience.Private
+public class MasterRegistry implements ConnectionRegistry {
+ private static final String MASTER_ADDRS_CONF_SEPARATOR = ",";
+
+ private volatile ImmutableMap<String, ClientMetaService.Interface> masterAddr2Stub;
+
+ // RPC client used to talk to the masters.
+ private RpcClient rpcClient;
+ private RpcControllerFactory rpcControllerFactory;
+ private int rpcTimeoutMs;
+
+ protected MasterAddressRefresher masterAddressRefresher;
+
+ @Override
+ public void init(Connection connection) throws IOException {
+ Configuration conf = connection.getConfiguration();
+ rpcTimeoutMs = (int) Math.min(Integer.MAX_VALUE,
+ conf.getLong(HConstants.HBASE_RPC_TIMEOUT_KEY, HConstants.DEFAULT_HBASE_RPC_TIMEOUT));
+ // XXX: we pass cluster id as null here since we do not have a cluster id yet, we have to fetch
Review comment:
Hmm.
Is there a planned follow up?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
##########
@@ -466,6 +468,9 @@ public void updateRpc(MethodDescriptor method, Message param, CallStats stats) {
if (callsPerServer > 0) {
concurrentCallsPerServerHist.update(callsPerServer);
}
+ // Update the counter that tracks RPCs by type.
+ final String methodName = method.getService().getName() + "_" + method.getName();
Review comment:
Can we break out this change? Metrics are special. They are a separate dimension of compatibility. Having them in a separate commit allows them to get noticed. They should have their own release note. Etc.
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
##########
@@ -466,6 +468,9 @@ public void updateRpc(MethodDescriptor method, Message param, CallStats stats) {
if (callsPerServer > 0) {
concurrentCallsPerServerHist.update(callsPerServer);
}
+ // Update the counter that tracks RPCs by type.
+ final String methodName = method.getService().getName() + "_" + method.getName();
Review comment:
Neat idea but it's coming in from some other work?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
##########
@@ -56,6 +56,7 @@
/** Set this key to {@code true} to enable metrics collection of client requests. */
public static final String CLIENT_SIDE_METRICS_ENABLED_KEY = "hbase.client.metrics.enable";
+ private static final String CNT_BASE = "rpcCount_";
Review comment:
Is this an unrelated change?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java
##########
@@ -1571,43 +1573,31 @@ boolean isMasterRunning() throws ServiceException {
* @throws KeeperException
* @throws ServiceException
*/
- private Object makeStubNoRetries() throws IOException, KeeperException, ServiceException {
- ZooKeeperKeepAliveConnection zkw;
- try {
- zkw = getKeepAliveZooKeeperWatcher();
- } catch (IOException e) {
- ExceptionUtil.rethrowIfInterrupt(e);
- throw new ZooKeeperConnectionException("Can't connect to ZooKeeper", e);
- }
- try {
- checkIfBaseNodeAvailable(zkw);
- ServerName sn = MasterAddressTracker.getMasterAddress(zkw);
- if (sn == null) {
- String msg = "ZooKeeper available but no active master location found";
- LOG.info(msg);
- throw new MasterNotRunningException(msg);
- }
- if (isDeadServer(sn)) {
- throw new MasterNotRunningException(sn + " is dead.");
+ private Object makeStubNoRetries() throws IOException, ServiceException {
+ ServerName sn = registry.getActiveMaster();
+ if (sn == null) {
+ String msg = "ZooKeeper available but no active master location found";
Review comment:
Is this still the correct exception text to emit?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterRegistry.java
##########
@@ -0,0 +1,266 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.client;
+
+import static org.apache.hadoop.hbase.util.DNS.getMasterHostname;
+import com.google.common.base.Preconditions;
+import com.google.common.base.Strings;
+import com.google.common.collect.ImmutableMap;
+import com.google.common.collect.ImmutableSet;
+import com.google.common.net.HostAndPort;
+import com.google.protobuf.Message;
+import com.google.protobuf.RpcController;
+import java.io.IOException;
+import java.net.UnknownHostException;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+import java.util.concurrent.ThreadLocalRandom;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseIOException;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.HRegionLocation;
+import org.apache.hadoop.hbase.RegionLocations;
+import org.apache.hadoop.hbase.ServerName;
+import org.apache.hadoop.hbase.classification.InterfaceAudience;
+import org.apache.hadoop.hbase.exceptions.ClientExceptionsUtil;
+import org.apache.hadoop.hbase.exceptions.MasterRegistryFetchException;
+import org.apache.hadoop.hbase.ipc.BlockingRpcCallback;
+import org.apache.hadoop.hbase.ipc.HBaseRpcController;
+import org.apache.hadoop.hbase.ipc.RpcClient;
+import org.apache.hadoop.hbase.ipc.RpcClientFactory;
+import org.apache.hadoop.hbase.ipc.RpcControllerFactory;
+import org.apache.hadoop.hbase.protobuf.ProtobufUtil;
+import org.apache.hadoop.hbase.protobuf.generated.HBaseProtos;
+import org.apache.hadoop.hbase.security.User;
+
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.ClientMetaService;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetClusterIdRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetClusterIdResponse;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMastersRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMastersResponse;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMastersResponseEntry;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMetaRegionLocationsRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMetaRegionLocationsResponse;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetNumLiveRSRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetNumLiveRSResponse;
+
+/**
+ * Master based registry implementation. Makes RPCs to the configured master addresses from config
+ * {@value org.apache.hadoop.hbase.HConstants#MASTER_ADDRS_KEY}. All the registry methods are
+ * blocking unlike implementations in other branches.
+ */
+@InterfaceAudience.Private
+public class MasterRegistry implements ConnectionRegistry {
+ private static final String MASTER_ADDRS_CONF_SEPARATOR = ",";
+
+ private volatile ImmutableMap<String, ClientMetaService.Interface> masterAddr2Stub;
+
+ // RPC client used to talk to the masters.
+ private RpcClient rpcClient;
+ private RpcControllerFactory rpcControllerFactory;
+ private int rpcTimeoutMs;
+
+ protected MasterAddressRefresher masterAddressRefresher;
+
+ @Override
+ public void init(Connection connection) throws IOException {
+ Configuration conf = connection.getConfiguration();
+ rpcTimeoutMs = (int) Math.min(Integer.MAX_VALUE,
+ conf.getLong(HConstants.HBASE_RPC_TIMEOUT_KEY, HConstants.DEFAULT_HBASE_RPC_TIMEOUT));
+ // XXX: we pass cluster id as null here since we do not have a cluster id yet, we have to fetch
Review comment:
Hmm.
Is there a planned follow up?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
##########
@@ -466,6 +468,9 @@ public void updateRpc(MethodDescriptor method, Message param, CallStats stats) {
if (callsPerServer > 0) {
concurrentCallsPerServerHist.update(callsPerServer);
}
+ // Update the counter that tracks RPCs by type.
+ final String methodName = method.getService().getName() + "_" + method.getName();
Review comment:
Can we break out this change? Metrics are special. They are a separate dimension of compatibility. Having them in a separate commit allows them to get noticed. They should have their own release note. Etc.
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
##########
@@ -466,6 +468,9 @@ public void updateRpc(MethodDescriptor method, Message param, CallStats stats) {
if (callsPerServer > 0) {
concurrentCallsPerServerHist.update(callsPerServer);
}
+ // Update the counter that tracks RPCs by type.
+ final String methodName = method.getService().getName() + "_" + method.getName();
Review comment:
Neat idea but it's coming in from some other work?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
##########
@@ -56,6 +56,7 @@
/** Set this key to {@code true} to enable metrics collection of client requests. */
public static final String CLIENT_SIDE_METRICS_ENABLED_KEY = "hbase.client.metrics.enable";
+ private static final String CNT_BASE = "rpcCount_";
Review comment:
Is this an unrelated change?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java
##########
@@ -1571,43 +1573,31 @@ boolean isMasterRunning() throws ServiceException {
* @throws KeeperException
* @throws ServiceException
*/
- private Object makeStubNoRetries() throws IOException, KeeperException, ServiceException {
- ZooKeeperKeepAliveConnection zkw;
- try {
- zkw = getKeepAliveZooKeeperWatcher();
- } catch (IOException e) {
- ExceptionUtil.rethrowIfInterrupt(e);
- throw new ZooKeeperConnectionException("Can't connect to ZooKeeper", e);
- }
- try {
- checkIfBaseNodeAvailable(zkw);
- ServerName sn = MasterAddressTracker.getMasterAddress(zkw);
- if (sn == null) {
- String msg = "ZooKeeper available but no active master location found";
- LOG.info(msg);
- throw new MasterNotRunningException(msg);
- }
- if (isDeadServer(sn)) {
- throw new MasterNotRunningException(sn + " is dead.");
+ private Object makeStubNoRetries() throws IOException, ServiceException {
+ ServerName sn = registry.getActiveMaster();
+ if (sn == null) {
+ String msg = "ZooKeeper available but no active master location found";
Review comment:
Is this still the correct exception text to emit?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterRegistry.java
##########
@@ -0,0 +1,266 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.client;
+
+import static org.apache.hadoop.hbase.util.DNS.getMasterHostname;
+import com.google.common.base.Preconditions;
+import com.google.common.base.Strings;
+import com.google.common.collect.ImmutableMap;
+import com.google.common.collect.ImmutableSet;
+import com.google.common.net.HostAndPort;
+import com.google.protobuf.Message;
+import com.google.protobuf.RpcController;
+import java.io.IOException;
+import java.net.UnknownHostException;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+import java.util.concurrent.ThreadLocalRandom;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseIOException;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.HRegionLocation;
+import org.apache.hadoop.hbase.RegionLocations;
+import org.apache.hadoop.hbase.ServerName;
+import org.apache.hadoop.hbase.classification.InterfaceAudience;
+import org.apache.hadoop.hbase.exceptions.ClientExceptionsUtil;
+import org.apache.hadoop.hbase.exceptions.MasterRegistryFetchException;
+import org.apache.hadoop.hbase.ipc.BlockingRpcCallback;
+import org.apache.hadoop.hbase.ipc.HBaseRpcController;
+import org.apache.hadoop.hbase.ipc.RpcClient;
+import org.apache.hadoop.hbase.ipc.RpcClientFactory;
+import org.apache.hadoop.hbase.ipc.RpcControllerFactory;
+import org.apache.hadoop.hbase.protobuf.ProtobufUtil;
+import org.apache.hadoop.hbase.protobuf.generated.HBaseProtos;
+import org.apache.hadoop.hbase.security.User;
+
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.ClientMetaService;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetClusterIdRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetClusterIdResponse;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMastersRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMastersResponse;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMastersResponseEntry;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMetaRegionLocationsRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMetaRegionLocationsResponse;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetNumLiveRSRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetNumLiveRSResponse;
+
+/**
+ * Master based registry implementation. Makes RPCs to the configured master addresses from config
+ * {@value org.apache.hadoop.hbase.HConstants#MASTER_ADDRS_KEY}. All the registry methods are
+ * blocking unlike implementations in other branches.
+ */
+@InterfaceAudience.Private
+public class MasterRegistry implements ConnectionRegistry {
+ private static final String MASTER_ADDRS_CONF_SEPARATOR = ",";
+
+ private volatile ImmutableMap<String, ClientMetaService.Interface> masterAddr2Stub;
+
+ // RPC client used to talk to the masters.
+ private RpcClient rpcClient;
+ private RpcControllerFactory rpcControllerFactory;
+ private int rpcTimeoutMs;
+
+ protected MasterAddressRefresher masterAddressRefresher;
+
+ @Override
+ public void init(Connection connection) throws IOException {
+ Configuration conf = connection.getConfiguration();
+ rpcTimeoutMs = (int) Math.min(Integer.MAX_VALUE,
+ conf.getLong(HConstants.HBASE_RPC_TIMEOUT_KEY, HConstants.DEFAULT_HBASE_RPC_TIMEOUT));
+ // XXX: we pass cluster id as null here since we do not have a cluster id yet, we have to fetch
Review comment:
Hmm.
Is there a planned follow up?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
##########
@@ -466,6 +468,9 @@ public void updateRpc(MethodDescriptor method, Message param, CallStats stats) {
if (callsPerServer > 0) {
concurrentCallsPerServerHist.update(callsPerServer);
}
+ // Update the counter that tracks RPCs by type.
+ final String methodName = method.getService().getName() + "_" + method.getName();
Review comment:
Can we break out this change? Metrics are special. They are a separate dimension of compatibility. Having them in a separate commit allows them to get noticed. They should have their own release note. Etc.
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
##########
@@ -466,6 +468,9 @@ public void updateRpc(MethodDescriptor method, Message param, CallStats stats) {
if (callsPerServer > 0) {
concurrentCallsPerServerHist.update(callsPerServer);
}
+ // Update the counter that tracks RPCs by type.
+ final String methodName = method.getService().getName() + "_" + method.getName();
Review comment:
Neat idea but it's coming in from some other work?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
##########
@@ -56,6 +56,7 @@
/** Set this key to {@code true} to enable metrics collection of client requests. */
public static final String CLIENT_SIDE_METRICS_ENABLED_KEY = "hbase.client.metrics.enable";
+ private static final String CNT_BASE = "rpcCount_";
Review comment:
Is this an unrelated change?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java
##########
@@ -1571,43 +1573,31 @@ boolean isMasterRunning() throws ServiceException {
* @throws KeeperException
* @throws ServiceException
*/
- private Object makeStubNoRetries() throws IOException, KeeperException, ServiceException {
- ZooKeeperKeepAliveConnection zkw;
- try {
- zkw = getKeepAliveZooKeeperWatcher();
- } catch (IOException e) {
- ExceptionUtil.rethrowIfInterrupt(e);
- throw new ZooKeeperConnectionException("Can't connect to ZooKeeper", e);
- }
- try {
- checkIfBaseNodeAvailable(zkw);
- ServerName sn = MasterAddressTracker.getMasterAddress(zkw);
- if (sn == null) {
- String msg = "ZooKeeper available but no active master location found";
- LOG.info(msg);
- throw new MasterNotRunningException(msg);
- }
- if (isDeadServer(sn)) {
- throw new MasterNotRunningException(sn + " is dead.");
+ private Object makeStubNoRetries() throws IOException, ServiceException {
+ ServerName sn = registry.getActiveMaster();
+ if (sn == null) {
+ String msg = "ZooKeeper available but no active master location found";
Review comment:
Is this still the correct exception text to emit?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterRegistry.java
##########
@@ -0,0 +1,266 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.client;
+
+import static org.apache.hadoop.hbase.util.DNS.getMasterHostname;
+import com.google.common.base.Preconditions;
+import com.google.common.base.Strings;
+import com.google.common.collect.ImmutableMap;
+import com.google.common.collect.ImmutableSet;
+import com.google.common.net.HostAndPort;
+import com.google.protobuf.Message;
+import com.google.protobuf.RpcController;
+import java.io.IOException;
+import java.net.UnknownHostException;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+import java.util.concurrent.ThreadLocalRandom;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseIOException;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.HRegionLocation;
+import org.apache.hadoop.hbase.RegionLocations;
+import org.apache.hadoop.hbase.ServerName;
+import org.apache.hadoop.hbase.classification.InterfaceAudience;
+import org.apache.hadoop.hbase.exceptions.ClientExceptionsUtil;
+import org.apache.hadoop.hbase.exceptions.MasterRegistryFetchException;
+import org.apache.hadoop.hbase.ipc.BlockingRpcCallback;
+import org.apache.hadoop.hbase.ipc.HBaseRpcController;
+import org.apache.hadoop.hbase.ipc.RpcClient;
+import org.apache.hadoop.hbase.ipc.RpcClientFactory;
+import org.apache.hadoop.hbase.ipc.RpcControllerFactory;
+import org.apache.hadoop.hbase.protobuf.ProtobufUtil;
+import org.apache.hadoop.hbase.protobuf.generated.HBaseProtos;
+import org.apache.hadoop.hbase.security.User;
+
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.ClientMetaService;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetClusterIdRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetClusterIdResponse;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMastersRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMastersResponse;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMastersResponseEntry;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMetaRegionLocationsRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMetaRegionLocationsResponse;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetNumLiveRSRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetNumLiveRSResponse;
+
+/**
+ * Master based registry implementation. Makes RPCs to the configured master addresses from config
+ * {@value org.apache.hadoop.hbase.HConstants#MASTER_ADDRS_KEY}. All the registry methods are
+ * blocking unlike implementations in other branches.
+ */
+@InterfaceAudience.Private
+public class MasterRegistry implements ConnectionRegistry {
+ private static final String MASTER_ADDRS_CONF_SEPARATOR = ",";
+
+ private volatile ImmutableMap<String, ClientMetaService.Interface> masterAddr2Stub;
+
+ // RPC client used to talk to the masters.
+ private RpcClient rpcClient;
+ private RpcControllerFactory rpcControllerFactory;
+ private int rpcTimeoutMs;
+
+ protected MasterAddressRefresher masterAddressRefresher;
+
+ @Override
+ public void init(Connection connection) throws IOException {
+ Configuration conf = connection.getConfiguration();
+ rpcTimeoutMs = (int) Math.min(Integer.MAX_VALUE,
+ conf.getLong(HConstants.HBASE_RPC_TIMEOUT_KEY, HConstants.DEFAULT_HBASE_RPC_TIMEOUT));
+ // XXX: we pass cluster id as null here since we do not have a cluster id yet, we have to fetch
Review comment:
Hmm.
Is there a planned follow up?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
##########
@@ -466,6 +468,9 @@ public void updateRpc(MethodDescriptor method, Message param, CallStats stats) {
if (callsPerServer > 0) {
concurrentCallsPerServerHist.update(callsPerServer);
}
+ // Update the counter that tracks RPCs by type.
+ final String methodName = method.getService().getName() + "_" + method.getName();
Review comment:
Can we break out this change? Metrics are special. They are a separate dimension of compatibility. Having them in a separate commit allows them to get noticed. They should have their own release note. Etc.
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
##########
@@ -466,6 +468,9 @@ public void updateRpc(MethodDescriptor method, Message param, CallStats stats) {
if (callsPerServer > 0) {
concurrentCallsPerServerHist.update(callsPerServer);
}
+ // Update the counter that tracks RPCs by type.
+ final String methodName = method.getService().getName() + "_" + method.getName();
Review comment:
Neat idea but it's coming in from some other work?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
##########
@@ -56,6 +56,7 @@
/** Set this key to {@code true} to enable metrics collection of client requests. */
public static final String CLIENT_SIDE_METRICS_ENABLED_KEY = "hbase.client.metrics.enable";
+ private static final String CNT_BASE = "rpcCount_";
Review comment:
Is this an unrelated change?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java
##########
@@ -1571,43 +1573,31 @@ boolean isMasterRunning() throws ServiceException {
* @throws KeeperException
* @throws ServiceException
*/
- private Object makeStubNoRetries() throws IOException, KeeperException, ServiceException {
- ZooKeeperKeepAliveConnection zkw;
- try {
- zkw = getKeepAliveZooKeeperWatcher();
- } catch (IOException e) {
- ExceptionUtil.rethrowIfInterrupt(e);
- throw new ZooKeeperConnectionException("Can't connect to ZooKeeper", e);
- }
- try {
- checkIfBaseNodeAvailable(zkw);
- ServerName sn = MasterAddressTracker.getMasterAddress(zkw);
- if (sn == null) {
- String msg = "ZooKeeper available but no active master location found";
- LOG.info(msg);
- throw new MasterNotRunningException(msg);
- }
- if (isDeadServer(sn)) {
- throw new MasterNotRunningException(sn + " is dead.");
+ private Object makeStubNoRetries() throws IOException, ServiceException {
+ ServerName sn = registry.getActiveMaster();
+ if (sn == null) {
+ String msg = "ZooKeeper available but no active master location found";
Review comment:
Is this still the correct exception text to emit?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterRegistry.java
##########
@@ -0,0 +1,266 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.client;
+
+import static org.apache.hadoop.hbase.util.DNS.getMasterHostname;
+import com.google.common.base.Preconditions;
+import com.google.common.base.Strings;
+import com.google.common.collect.ImmutableMap;
+import com.google.common.collect.ImmutableSet;
+import com.google.common.net.HostAndPort;
+import com.google.protobuf.Message;
+import com.google.protobuf.RpcController;
+import java.io.IOException;
+import java.net.UnknownHostException;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+import java.util.concurrent.ThreadLocalRandom;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseIOException;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.HRegionLocation;
+import org.apache.hadoop.hbase.RegionLocations;
+import org.apache.hadoop.hbase.ServerName;
+import org.apache.hadoop.hbase.classification.InterfaceAudience;
+import org.apache.hadoop.hbase.exceptions.ClientExceptionsUtil;
+import org.apache.hadoop.hbase.exceptions.MasterRegistryFetchException;
+import org.apache.hadoop.hbase.ipc.BlockingRpcCallback;
+import org.apache.hadoop.hbase.ipc.HBaseRpcController;
+import org.apache.hadoop.hbase.ipc.RpcClient;
+import org.apache.hadoop.hbase.ipc.RpcClientFactory;
+import org.apache.hadoop.hbase.ipc.RpcControllerFactory;
+import org.apache.hadoop.hbase.protobuf.ProtobufUtil;
+import org.apache.hadoop.hbase.protobuf.generated.HBaseProtos;
+import org.apache.hadoop.hbase.security.User;
+
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.ClientMetaService;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetClusterIdRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetClusterIdResponse;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMastersRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMastersResponse;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMastersResponseEntry;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMetaRegionLocationsRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMetaRegionLocationsResponse;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetNumLiveRSRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetNumLiveRSResponse;
+
+/**
+ * Master based registry implementation. Makes RPCs to the configured master addresses from config
+ * {@value org.apache.hadoop.hbase.HConstants#MASTER_ADDRS_KEY}. All the registry methods are
+ * blocking unlike implementations in other branches.
+ */
+@InterfaceAudience.Private
+public class MasterRegistry implements ConnectionRegistry {
+ private static final String MASTER_ADDRS_CONF_SEPARATOR = ",";
+
+ private volatile ImmutableMap<String, ClientMetaService.Interface> masterAddr2Stub;
+
+ // RPC client used to talk to the masters.
+ private RpcClient rpcClient;
+ private RpcControllerFactory rpcControllerFactory;
+ private int rpcTimeoutMs;
+
+ protected MasterAddressRefresher masterAddressRefresher;
+
+ @Override
+ public void init(Connection connection) throws IOException {
+ Configuration conf = connection.getConfiguration();
+ rpcTimeoutMs = (int) Math.min(Integer.MAX_VALUE,
+ conf.getLong(HConstants.HBASE_RPC_TIMEOUT_KEY, HConstants.DEFAULT_HBASE_RPC_TIMEOUT));
+ // XXX: we pass cluster id as null here since we do not have a cluster id yet, we have to fetch
Review comment:
Hmm.
Is there a planned follow up?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
##########
@@ -466,6 +468,9 @@ public void updateRpc(MethodDescriptor method, Message param, CallStats stats) {
if (callsPerServer > 0) {
concurrentCallsPerServerHist.update(callsPerServer);
}
+ // Update the counter that tracks RPCs by type.
+ final String methodName = method.getService().getName() + "_" + method.getName();
Review comment:
Can we break out this change? Metrics are special. They are a separate dimension of compatibility. Having them in a separate commit allows them to get noticed. They should have their own release note. Etc.
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
##########
@@ -466,6 +468,9 @@ public void updateRpc(MethodDescriptor method, Message param, CallStats stats) {
if (callsPerServer > 0) {
concurrentCallsPerServerHist.update(callsPerServer);
}
+ // Update the counter that tracks RPCs by type.
+ final String methodName = method.getService().getName() + "_" + method.getName();
Review comment:
Neat idea but it's coming in from some other work?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
##########
@@ -56,6 +56,7 @@
/** Set this key to {@code true} to enable metrics collection of client requests. */
public static final String CLIENT_SIDE_METRICS_ENABLED_KEY = "hbase.client.metrics.enable";
+ private static final String CNT_BASE = "rpcCount_";
Review comment:
Is this an unrelated change?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java
##########
@@ -1571,43 +1573,31 @@ boolean isMasterRunning() throws ServiceException {
* @throws KeeperException
* @throws ServiceException
*/
- private Object makeStubNoRetries() throws IOException, KeeperException, ServiceException {
- ZooKeeperKeepAliveConnection zkw;
- try {
- zkw = getKeepAliveZooKeeperWatcher();
- } catch (IOException e) {
- ExceptionUtil.rethrowIfInterrupt(e);
- throw new ZooKeeperConnectionException("Can't connect to ZooKeeper", e);
- }
- try {
- checkIfBaseNodeAvailable(zkw);
- ServerName sn = MasterAddressTracker.getMasterAddress(zkw);
- if (sn == null) {
- String msg = "ZooKeeper available but no active master location found";
- LOG.info(msg);
- throw new MasterNotRunningException(msg);
- }
- if (isDeadServer(sn)) {
- throw new MasterNotRunningException(sn + " is dead.");
+ private Object makeStubNoRetries() throws IOException, ServiceException {
+ ServerName sn = registry.getActiveMaster();
+ if (sn == null) {
+ String msg = "ZooKeeper available but no active master location found";
Review comment:
Is this still the correct exception text to emit?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterRegistry.java
##########
@@ -0,0 +1,266 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.client;
+
+import static org.apache.hadoop.hbase.util.DNS.getMasterHostname;
+import com.google.common.base.Preconditions;
+import com.google.common.base.Strings;
+import com.google.common.collect.ImmutableMap;
+import com.google.common.collect.ImmutableSet;
+import com.google.common.net.HostAndPort;
+import com.google.protobuf.Message;
+import com.google.protobuf.RpcController;
+import java.io.IOException;
+import java.net.UnknownHostException;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+import java.util.concurrent.ThreadLocalRandom;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseIOException;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.HRegionLocation;
+import org.apache.hadoop.hbase.RegionLocations;
+import org.apache.hadoop.hbase.ServerName;
+import org.apache.hadoop.hbase.classification.InterfaceAudience;
+import org.apache.hadoop.hbase.exceptions.ClientExceptionsUtil;
+import org.apache.hadoop.hbase.exceptions.MasterRegistryFetchException;
+import org.apache.hadoop.hbase.ipc.BlockingRpcCallback;
+import org.apache.hadoop.hbase.ipc.HBaseRpcController;
+import org.apache.hadoop.hbase.ipc.RpcClient;
+import org.apache.hadoop.hbase.ipc.RpcClientFactory;
+import org.apache.hadoop.hbase.ipc.RpcControllerFactory;
+import org.apache.hadoop.hbase.protobuf.ProtobufUtil;
+import org.apache.hadoop.hbase.protobuf.generated.HBaseProtos;
+import org.apache.hadoop.hbase.security.User;
+
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.ClientMetaService;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetClusterIdRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetClusterIdResponse;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMastersRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMastersResponse;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMastersResponseEntry;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMetaRegionLocationsRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMetaRegionLocationsResponse;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetNumLiveRSRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetNumLiveRSResponse;
+
+/**
+ * Master based registry implementation. Makes RPCs to the configured master addresses from config
+ * {@value org.apache.hadoop.hbase.HConstants#MASTER_ADDRS_KEY}. All the registry methods are
+ * blocking unlike implementations in other branches.
+ */
+@InterfaceAudience.Private
+public class MasterRegistry implements ConnectionRegistry {
+ private static final String MASTER_ADDRS_CONF_SEPARATOR = ",";
+
+ private volatile ImmutableMap<String, ClientMetaService.Interface> masterAddr2Stub;
+
+ // RPC client used to talk to the masters.
+ private RpcClient rpcClient;
+ private RpcControllerFactory rpcControllerFactory;
+ private int rpcTimeoutMs;
+
+ protected MasterAddressRefresher masterAddressRefresher;
+
+ @Override
+ public void init(Connection connection) throws IOException {
+ Configuration conf = connection.getConfiguration();
+ rpcTimeoutMs = (int) Math.min(Integer.MAX_VALUE,
+ conf.getLong(HConstants.HBASE_RPC_TIMEOUT_KEY, HConstants.DEFAULT_HBASE_RPC_TIMEOUT));
+ // XXX: we pass cluster id as null here since we do not have a cluster id yet, we have to fetch
Review comment:
Hmm.
Is there a planned follow up?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
##########
@@ -466,6 +468,9 @@ public void updateRpc(MethodDescriptor method, Message param, CallStats stats) {
if (callsPerServer > 0) {
concurrentCallsPerServerHist.update(callsPerServer);
}
+ // Update the counter that tracks RPCs by type.
+ final String methodName = method.getService().getName() + "_" + method.getName();
Review comment:
Can we break out this change? Metrics are special. They are a separate dimension of compatibility. Having them in a separate commit allows them to get noticed. They should have their own release note. Etc.
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
##########
@@ -466,6 +468,9 @@ public void updateRpc(MethodDescriptor method, Message param, CallStats stats) {
if (callsPerServer > 0) {
concurrentCallsPerServerHist.update(callsPerServer);
}
+ // Update the counter that tracks RPCs by type.
+ final String methodName = method.getService().getName() + "_" + method.getName();
Review comment:
Neat idea but it's coming in from some other work?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2280: HBASE-18095 branch-1 backport (WIP)
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2280:
URL: https://github.com/apache/hbase/pull/2280#issuecomment-677319783
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 6m 54s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 5 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 24s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 8m 8s | branch-1 passed |
| +1 :green_heart: | compile | 1m 3s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 1m 11s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 2m 29s | branch-1 passed |
| +1 :green_heart: | shadedjars | 3m 10s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 3s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 1m 10s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 2m 54s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 4m 35s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 54s | root in the patch failed. |
| -1 :x: | compile | 0m 28s | hbase-server in the patch failed with JDK v1.8.0_262. |
| -1 :x: | javac | 0m 28s | hbase-server in the patch failed with JDK v1.8.0_262. |
| -1 :x: | compile | 0m 21s | hbase-client in the patch failed with JDK v1.7.0_272. |
| -1 :x: | compile | 0m 35s | hbase-server in the patch failed with JDK v1.7.0_272. |
| -1 :x: | javac | 0m 21s | hbase-client in the patch failed with JDK v1.7.0_272. |
| -1 :x: | javac | 0m 35s | hbase-server in the patch failed with JDK v1.7.0_272. |
| -1 :x: | checkstyle | 0m 43s | hbase-client: The patch generated 11 new + 279 unchanged - 3 fixed = 290 total (was 282) |
| -1 :x: | checkstyle | 1m 35s | hbase-server: The patch generated 3 new + 226 unchanged - 5 fixed = 229 total (was 231) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | shadedjars | 1m 12s | patch has 14 errors when building our shaded downstream artifacts. |
| -1 :x: | hadoopcheck | 0m 56s | The patch causes 14 errors with Hadoop v2.8.5. |
| -1 :x: | hadoopcheck | 2m 8s | The patch causes 14 errors with Hadoop v2.9.2. |
| +1 :green_heart: | javadoc | 0m 57s | the patch passed with JDK v1.8.0_262 |
| -1 :x: | javadoc | 0m 28s | hbase-client-jdk1.7.0_272 with JDK v1.7.0_272 generated 1 new + 14 unchanged - 0 fixed = 15 total (was 14) |
| -1 :x: | findbugs | 0m 24s | hbase-client in the patch failed. |
| -1 :x: | findbugs | 0m 40s | hbase-server in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 25s | hbase-client in the patch failed. |
| -1 :x: | unit | 0m 40s | hbase-server in the patch failed. |
| +1 :green_heart: | asflicense | 0m 26s | The patch does not generate ASF License warnings. |
| | | 47m 16s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2280 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 3edb0bdbbd1e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-2280/out/precommit/personality/provided.sh |
| git revision | branch-1 / c2e0cf9 |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/3/artifact/out/patch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/3/artifact/out/patch-compile-hbase-server-jdk1.8.0_262.txt |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/3/artifact/out/patch-compile-hbase-server-jdk1.8.0_262.txt |
| compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/3/artifact/out/patch-compile-hbase-client-jdk1.7.0_272.txt |
| compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/3/artifact/out/patch-compile-hbase-server-jdk1.7.0_272.txt |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/3/artifact/out/patch-compile-hbase-client-jdk1.7.0_272.txt |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/3/artifact/out/patch-compile-hbase-server-jdk1.7.0_272.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/3/artifact/out/diff-checkstyle-hbase-client.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/3/artifact/out/diff-checkstyle-hbase-server.txt |
| shadedjars | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/3/artifact/out/patch-shadedjars.txt |
| hadoopcheck | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/3/artifact/out/patch-javac-2.8.5.txt |
| hadoopcheck | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/3/artifact/out/patch-javac-2.9.2.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/3/artifact/out/diff-javadoc-javadoc-hbase-client-jdk1.7.0_272.txt |
| findbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/3/artifact/out/patch-findbugs-hbase-client.txt |
| findbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/3/artifact/out/patch-findbugs-hbase-server.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/3/artifact/out/patch-unit-hbase-client.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/3/artifact/out/patch-unit-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/3/testReport/ |
| Max. process+thread count | 87 (vs. ulimit of 10000) |
| modules | C: hbase-client hbase-server U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/3/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bharathv closed pull request #2280: HBASE-18095 branch-1 umbrella PR
Posted by GitBox <gi...@apache.org>.
bharathv closed pull request #2280:
URL: https://github.com/apache/hbase/pull/2280
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell commented on a change in pull request #2280: HBASE-18095 branch-1 umbrella PR
Posted by GitBox <gi...@apache.org>.
apurtell commented on a change in pull request #2280:
URL: https://github.com/apache/hbase/pull/2280#discussion_r489027430
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
##########
@@ -56,6 +56,7 @@
/** Set this key to {@code true} to enable metrics collection of client requests. */
public static final String CLIENT_SIDE_METRICS_ENABLED_KEY = "hbase.client.metrics.enable";
+ private static final String CNT_BASE = "rpcCount_";
Review comment:
I see. Would be weird to do different. Thought it was its own commit in master history. np.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2280: HBASE-18095 branch-1 backport (WIP)
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2280:
URL: https://github.com/apache/hbase/pull/2280#issuecomment-687693948
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 36s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 2s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 34 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 48s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 7m 58s | branch-1 passed |
| +1 :green_heart: | compile | 1m 39s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 1m 41s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 13m 2s | branch-1 passed |
| +1 :green_heart: | shadedjars | 2m 59s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 45s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 5m 39s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 2m 44s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 18m 18s | branch-1 passed |
| -0 :warning: | patch | 3m 29s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 56s | the patch passed |
| +1 :green_heart: | compile | 1m 39s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | cc | 1m 39s | the patch passed |
| +1 :green_heart: | javac | 1m 39s | the patch passed |
| +1 :green_heart: | compile | 1m 46s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | cc | 1m 46s | the patch passed |
| +1 :green_heart: | javac | 1m 46s | the patch passed |
| -1 :x: | checkstyle | 0m 53s | hbase-client: The patch generated 11 new + 683 unchanged - 31 fixed = 694 total (was 714) |
| -1 :x: | checkstyle | 2m 27s | hbase-server: The patch generated 97 new + 2094 unchanged - 51 fixed = 2191 total (was 2145) |
| -1 :x: | checkstyle | 6m 36s | root: The patch generated 109 new + 2790 unchanged - 83 fixed = 2899 total (was 2873) |
| +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 0s | The patch has 1 ill-formed XML file(s). |
| +1 :green_heart: | shadedjars | 2m 46s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 4m 33s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | hbaseprotoc | 4m 22s | the patch passed |
| +1 :green_heart: | javadoc | 3m 39s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 5m 41s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 19m 37s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 155m 19s | root in the patch failed. |
| +1 :green_heart: | asflicense | 2m 47s | The patch does not generate ASF License warnings. |
| | | 283m 51s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | pom.xml |
| Failed junit tests | hadoop.hbase.client.TestFromClientSide |
| | hadoop.hbase.snapshot.TestExportSnapshotWithTemporaryDirectory |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/17/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2280 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool xml |
| uname | Linux f7678a0a2192 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2280/out/precommit/personality/provided.sh |
| git revision | branch-1 / 76db1e1 |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/17/artifact/out/diff-checkstyle-hbase-client.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/17/artifact/out/diff-checkstyle-hbase-server.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/17/artifact/out/diff-checkstyle-root.txt |
| xml | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/17/artifact/out/xml.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/17/artifact/out/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/17/testReport/ |
| Max. process+thread count | 4360 (vs. ulimit of 10000) |
| modules | C: hbase-protocol hbase-common hbase-client hbase-server hbase-rsgroup . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/17/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2280: HBASE-18095 branch-1 umbrella PR
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2280:
URL: https://github.com/apache/hbase/pull/2280#issuecomment-695145810
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 36s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 2s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 1s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 37 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 47s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 7m 49s | branch-1 passed |
| +1 :green_heart: | compile | 1m 36s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 1m 46s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 13m 7s | branch-1 passed |
| +1 :green_heart: | shadedjars | 2m 58s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 47s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 5m 31s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 2m 42s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 18m 16s | branch-1 passed |
| -0 :warning: | patch | 3m 28s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 56s | the patch passed |
| +1 :green_heart: | compile | 1m 39s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | cc | 1m 39s | the patch passed |
| +1 :green_heart: | javac | 1m 40s | the patch passed |
| +1 :green_heart: | compile | 1m 42s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | cc | 1m 42s | the patch passed |
| +1 :green_heart: | javac | 1m 42s | the patch passed |
| -1 :x: | checkstyle | 0m 56s | hbase-client: The patch generated 17 new + 740 unchanged - 31 fixed = 757 total (was 771) |
| -1 :x: | checkstyle | 2m 25s | hbase-server: The patch generated 99 new + 2098 unchanged - 51 fixed = 2197 total (was 2149) |
| -1 :x: | checkstyle | 6m 30s | root: The patch generated 119 new + 2849 unchanged - 85 fixed = 2968 total (was 2934) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 1s | The patch has 1 ill-formed XML file(s). |
| +1 :green_heart: | shadedjars | 2m 51s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 4m 37s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | hbaseprotoc | 4m 19s | the patch passed |
| +1 :green_heart: | javadoc | 3m 41s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 5m 43s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 19m 40s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 157m 35s | root in the patch failed. |
| +1 :green_heart: | asflicense | 2m 43s | The patch does not generate ASF License warnings. |
| | | 286m 20s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | pom.xml |
| Failed junit tests | hadoop.hbase.client.TestFromClientSide |
| | hadoop.hbase.snapshot.TestExportSnapshotWithTemporaryDirectory |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/24/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2280 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool xml |
| uname | Linux c816c44d69b9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2280/out/precommit/personality/provided.sh |
| git revision | branch-1 / f0acafc |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/24/artifact/out/diff-checkstyle-hbase-client.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/24/artifact/out/diff-checkstyle-hbase-server.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/24/artifact/out/diff-checkstyle-root.txt |
| xml | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/24/artifact/out/xml.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/24/artifact/out/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/24/testReport/ |
| Max. process+thread count | 4246 (vs. ulimit of 10000) |
| modules | C: hbase-protocol hbase-common hbase-client hbase-server hbase-rsgroup . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/24/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2280: HBASE-18095 branch-1 backport (WIP)
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2280:
URL: https://github.com/apache/hbase/pull/2280#issuecomment-678461940
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 45s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 1s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 6 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 24s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 8m 28s | branch-1 passed |
| +1 :green_heart: | compile | 1m 39s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 1m 44s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 4m 56s | branch-1 passed |
| +1 :green_heart: | shadedjars | 3m 7s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 15s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 1m 20s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 2m 40s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 6m 25s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 53s | the patch passed |
| +1 :green_heart: | compile | 1m 29s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | cc | 1m 29s | the patch passed |
| +1 :green_heart: | javac | 1m 29s | the patch passed |
| +1 :green_heart: | compile | 1m 36s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | cc | 1m 36s | the patch passed |
| +1 :green_heart: | javac | 1m 36s | the patch passed |
| -1 :x: | checkstyle | 0m 43s | hbase-client: The patch generated 2 new + 279 unchanged - 3 fixed = 281 total (was 282) |
| -1 :x: | checkstyle | 1m 37s | hbase-server: The patch generated 2 new + 243 unchanged - 5 fixed = 245 total (was 248) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 2m 51s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 4m 37s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | hbaseprotoc | 1m 51s | the patch passed |
| +1 :green_heart: | javadoc | 1m 1s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 1m 18s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 6m 41s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 28s | hbase-protocol in the patch passed. |
| +1 :green_heart: | unit | 2m 42s | hbase-client in the patch passed. |
| +1 :green_heart: | unit | 124m 29s | hbase-server in the patch passed. |
| +1 :green_heart: | asflicense | 1m 21s | The patch does not generate ASF License warnings. |
| | | 193m 49s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/6/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2280 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool |
| uname | Linux 13fc6b1117bd 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2280/out/precommit/personality/provided.sh |
| git revision | branch-1 / c2e0cf9 |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/6/artifact/out/diff-checkstyle-hbase-client.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/6/artifact/out/diff-checkstyle-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/6/testReport/ |
| Max. process+thread count | 4366 (vs. ulimit of 10000) |
| modules | C: hbase-protocol hbase-client hbase-server U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/6/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2280: HBASE-18095 branch-1 backport (WIP)
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2280:
URL: https://github.com/apache/hbase/pull/2280#issuecomment-685350857
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 35s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 2s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 31 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 47s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 7m 54s | branch-1 passed |
| +1 :green_heart: | compile | 1m 40s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 1m 44s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 12m 11s | branch-1 passed |
| +1 :green_heart: | shadedjars | 2m 59s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 28s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 5m 12s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 2m 43s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 17m 17s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 56s | the patch passed |
| +1 :green_heart: | compile | 1m 41s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | cc | 1m 41s | the patch passed |
| +1 :green_heart: | javac | 1m 41s | the patch passed |
| +1 :green_heart: | compile | 1m 43s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | cc | 1m 43s | the patch passed |
| +1 :green_heart: | javac | 1m 43s | the patch passed |
| -1 :x: | checkstyle | 0m 53s | hbase-client: The patch generated 1 new + 691 unchanged - 21 fixed = 692 total (was 712) |
| -1 :x: | checkstyle | 2m 23s | hbase-server: The patch generated 94 new + 1863 unchanged - 46 fixed = 1957 total (was 1909) |
| -1 :x: | checkstyle | 6m 15s | root: The patch generated 98 new + 2553 unchanged - 70 fixed = 2651 total (was 2623) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 0s | The patch has 1 ill-formed XML file(s). |
| +1 :green_heart: | shadedjars | 2m 52s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 4m 36s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | hbaseprotoc | 3m 54s | the patch passed |
| +1 :green_heart: | javadoc | 3m 20s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 5m 18s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 18m 31s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 154m 19s | root in the patch failed. |
| +1 :green_heart: | asflicense | 2m 24s | The patch does not generate ASF License warnings. |
| | | 276m 35s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | pom.xml |
| Failed junit tests | hadoop.hbase.client.TestAdmin1 |
| | hadoop.hbase.master.TestMasterFailover |
| | hadoop.hbase.snapshot.TestExportSnapshotWithTemporaryDirectory |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/11/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2280 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool xml |
| uname | Linux ead348373232 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2280/out/precommit/personality/provided.sh |
| git revision | branch-1 / 1dc75e7 |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/11/artifact/out/diff-checkstyle-hbase-client.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/11/artifact/out/diff-checkstyle-hbase-server.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/11/artifact/out/diff-checkstyle-root.txt |
| xml | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/11/artifact/out/xml.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/11/artifact/out/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/11/testReport/ |
| Max. process+thread count | 4325 (vs. ulimit of 10000) |
| modules | C: hbase-protocol hbase-client hbase-server hbase-rsgroup . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/11/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2280: HBASE-18095 branch-1 backport (WIP)
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2280:
URL: https://github.com/apache/hbase/pull/2280#issuecomment-686039122
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 33s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 2s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 31 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 55s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 8m 40s | branch-1 passed |
| +1 :green_heart: | compile | 1m 39s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 1m 44s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 12m 23s | branch-1 passed |
| +1 :green_heart: | shadedjars | 2m 58s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 32s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 5m 18s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 2m 41s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 17m 10s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 56s | the patch passed |
| +1 :green_heart: | compile | 1m 41s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | cc | 1m 41s | the patch passed |
| +1 :green_heart: | javac | 1m 41s | the patch passed |
| +1 :green_heart: | compile | 1m 42s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | cc | 1m 42s | the patch passed |
| +1 :green_heart: | javac | 1m 42s | the patch passed |
| -1 :x: | checkstyle | 0m 52s | hbase-client: The patch generated 1 new + 691 unchanged - 21 fixed = 692 total (was 712) |
| -1 :x: | checkstyle | 2m 23s | hbase-server: The patch generated 95 new + 1861 unchanged - 48 fixed = 1956 total (was 1909) |
| -1 :x: | checkstyle | 6m 11s | root: The patch generated 100 new + 2550 unchanged - 73 fixed = 2650 total (was 2623) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 0s | The patch has 1 ill-formed XML file(s). |
| +1 :green_heart: | shadedjars | 2m 48s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 4m 48s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | hbaseprotoc | 3m 51s | the patch passed |
| +1 :green_heart: | javadoc | 3m 19s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 5m 11s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 18m 23s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 154m 31s | root in the patch failed. |
| +1 :green_heart: | asflicense | 2m 19s | The patch does not generate ASF License warnings. |
| | | 277m 28s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | pom.xml |
| Failed junit tests | hadoop.hbase.snapshot.TestExportSnapshotWithTemporaryDirectory |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/12/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2280 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool xml |
| uname | Linux d2fd6e0c523a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2280/out/precommit/personality/provided.sh |
| git revision | branch-1 / 1dc75e7 |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/12/artifact/out/diff-checkstyle-hbase-client.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/12/artifact/out/diff-checkstyle-hbase-server.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/12/artifact/out/diff-checkstyle-root.txt |
| xml | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/12/artifact/out/xml.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/12/artifact/out/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/12/testReport/ |
| Max. process+thread count | 4266 (vs. ulimit of 10000) |
| modules | C: hbase-protocol hbase-client hbase-server hbase-rsgroup . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/12/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2280: HBASE-18095 branch-1 backport (WIP)
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2280:
URL: https://github.com/apache/hbase/pull/2280#issuecomment-687722360
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 40s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 2s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 34 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 48s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 7m 51s | branch-1 passed |
| +1 :green_heart: | compile | 1m 37s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 1m 44s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 12m 56s | branch-1 passed |
| +1 :green_heart: | shadedjars | 2m 59s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 47s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 5m 38s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 2m 40s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 18m 22s | branch-1 passed |
| -0 :warning: | patch | 3m 27s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 54s | the patch passed |
| +1 :green_heart: | compile | 1m 37s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | cc | 1m 37s | the patch passed |
| +1 :green_heart: | javac | 1m 37s | the patch passed |
| +1 :green_heart: | compile | 1m 43s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | cc | 1m 43s | the patch passed |
| +1 :green_heart: | javac | 1m 43s | the patch passed |
| -1 :x: | checkstyle | 0m 53s | hbase-client: The patch generated 11 new + 683 unchanged - 31 fixed = 694 total (was 714) |
| -1 :x: | checkstyle | 2m 28s | hbase-server: The patch generated 97 new + 2094 unchanged - 51 fixed = 2191 total (was 2145) |
| -1 :x: | checkstyle | 6m 27s | root: The patch generated 109 new + 2790 unchanged - 83 fixed = 2899 total (was 2873) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 0s | The patch has 1 ill-formed XML file(s). |
| +1 :green_heart: | shadedjars | 2m 45s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 4m 46s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | hbaseprotoc | 4m 19s | the patch passed |
| +1 :green_heart: | javadoc | 3m 41s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 5m 39s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 19m 36s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 157m 45s | root in the patch failed. |
| +1 :green_heart: | asflicense | 2m 46s | The patch does not generate ASF License warnings. |
| | | 285m 55s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | pom.xml |
| Failed junit tests | hadoop.hbase.master.TestWarmupRegion |
| | hadoop.hbase.client.TestFromClientSide |
| | hadoop.hbase.mapreduce.TestLoadIncrementalHFiles |
| | hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles |
| | hadoop.hbase.snapshot.TestExportSnapshotWithTemporaryDirectory |
| | hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/18/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2280 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool xml |
| uname | Linux eaad8d884bdd 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2280/out/precommit/personality/provided.sh |
| git revision | branch-1 / 76db1e1 |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/18/artifact/out/diff-checkstyle-hbase-client.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/18/artifact/out/diff-checkstyle-hbase-server.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/18/artifact/out/diff-checkstyle-root.txt |
| xml | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/18/artifact/out/xml.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/18/artifact/out/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/18/testReport/ |
| Max. process+thread count | 4262 (vs. ulimit of 10000) |
| modules | C: hbase-protocol hbase-common hbase-client hbase-server hbase-rsgroup . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/18/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2280: HBASE-18095 branch-1 backport (WIP)
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2280:
URL: https://github.com/apache/hbase/pull/2280#issuecomment-684224901
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 49s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| -1 :x: | hbaseanti | 0m 0s | The patch appears use Hadoop classification instead of HBase. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 31 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 25s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 8m 41s | branch-1 passed |
| +1 :green_heart: | compile | 1m 55s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 2m 15s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 6m 49s | branch-1 passed |
| +1 :green_heart: | shadedjars | 3m 40s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 35s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 1m 39s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 2m 42s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 7m 7s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 56s | the patch passed |
| +1 :green_heart: | compile | 1m 46s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | cc | 1m 46s | the patch passed |
| +1 :green_heart: | javac | 1m 46s | the patch passed |
| +1 :green_heart: | compile | 2m 1s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | cc | 2m 1s | the patch passed |
| +1 :green_heart: | javac | 2m 1s | the patch passed |
| -1 :x: | checkstyle | 0m 54s | hbase-client: The patch generated 37 new + 691 unchanged - 22 fixed = 728 total (was 713) |
| -1 :x: | checkstyle | 2m 25s | hbase-server: The patch generated 95 new + 1877 unchanged - 44 fixed = 1972 total (was 1921) |
| -1 :x: | checkstyle | 0m 17s | hbase-rsgroup: The patch generated 2 new + 2 unchanged - 0 fixed = 4 total (was 2) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 2m 49s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 4m 35s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | hbaseprotoc | 2m 12s | the patch passed |
| +1 :green_heart: | javadoc | 1m 16s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 1m 37s | the patch passed with JDK v1.7.0_272 |
| -1 :x: | findbugs | 2m 55s | hbase-server generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 28s | hbase-protocol in the patch passed. |
| -1 :x: | unit | 2m 44s | hbase-client in the patch failed. |
| -1 :x: | unit | 131m 27s | hbase-server in the patch failed. |
| -1 :x: | unit | 13m 11s | hbase-rsgroup in the patch failed. |
| +1 :green_heart: | asflicense | 1m 51s | The patch does not generate ASF License warnings. |
| | | 225m 46s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:hbase-server |
| | Call to org.apache.hadoop.hbase.client.TableState.equals(org.apache.hadoop.hbase.protobuf.generated.HBaseProtos$TableState$State) in org.apache.hadoop.hbase.util.HBaseFsck.checkAndFixOrphanedTableZNodes() At HBaseFsck.java: At HBaseFsck.java:[line 3553] |
| | Null pointer dereference of enablingTables in org.apache.hadoop.hbase.util.HBaseFsck.checkAndFixOrphanedTableZNodes() Dereferenced at HBaseFsck.java:in org.apache.hadoop.hbase.util.HBaseFsck.checkAndFixOrphanedTableZNodes() Dereferenced at HBaseFsck.java:[line 3554] |
| | Null pointer dereference of enablingTables in org.apache.hadoop.hbase.util.HBaseFsck.checkAndFixOrphanedTableZNodes() Dereferenced at HBaseFsck.java:in org.apache.hadoop.hbase.util.HBaseFsck.checkAndFixOrphanedTableZNodes() Dereferenced at HBaseFsck.java:[line 3560] |
| Failed junit tests | hadoop.hbase.TestInterfaceAudienceAnnotations |
| | hadoop.hbase.master.cleaner.TestSnapshotFromMaster |
| | hadoop.hbase.client.TestSnapshotCloneIndependence |
| | hadoop.hbase.client.TestSnapshotWithAcl |
| | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
| | hadoop.hbase.util.hbck.TestOfflineMetaRebuildBase |
| | hadoop.hbase.client.TestMetaWithReplicas |
| | hadoop.hbase.client.TestRestoreSnapshotFromClient |
| | hadoop.hbase.client.TestSnapshotTemporaryDirectory |
| | hadoop.hbase.namespace.TestZKLessNamespaceAuditor |
| | hadoop.hbase.master.snapshot.TestSnapshotFileCache |
| | hadoop.hbase.util.hbck.TestOfflineMetaRebuildOverlap |
| | hadoop.hbase.master.procedure.TestCreateTableProcedure2 |
| | hadoop.hbase.TestDrainingServer |
| | hadoop.hbase.client.TestSnapshotMetadata |
| | hadoop.hbase.snapshot.TestConcurrentFlushSnapshotFromClient |
| | hadoop.hbase.client.TestRestoreSnapshotFromClientWithRegionReplicas |
| | hadoop.hbase.snapshot.TestSecureExportSnapshot |
| | hadoop.hbase.master.handler.TestCreateTableHandler |
| | hadoop.hbase.namespace.TestNamespaceAuditor |
| | hadoop.hbase.util.hbck.TestOfflineMetaRebuildHole |
| | hadoop.hbase.coprocessor.TestMasterObserver |
| | hadoop.hbase.client.TestCloneSnapshotFromClient |
| | hadoop.hbase.master.TestMasterFailover |
| | hadoop.hbase.snapshot.TestFlushSnapshotFromClient |
| | hadoop.hbase.snapshot.TestExportSnapshot |
| | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory |
| | hadoop.hbase.snapshot.TestExportSnapshotWithTemporaryDirectory |
| | hadoop.hbase.util.TestHBaseFsckEncryption |
| | hadoop.hbase.snapshot.TestRestoreFlushSnapshotFromClient |
| | hadoop.hbase.rsgroup.TestRSGroupsBasics |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/7/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2280 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool |
| uname | Linux 11f57313e0cc 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2280/out/precommit/personality/provided.sh |
| git revision | branch-1 / 041debd |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/7/artifact/out/diff-checkstyle-hbase-client.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/7/artifact/out/diff-checkstyle-hbase-server.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/7/artifact/out/diff-checkstyle-hbase-rsgroup.txt |
| findbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/7/artifact/out/new-findbugs-hbase-server.html |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/7/artifact/out/patch-unit-hbase-client.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/7/artifact/out/patch-unit-hbase-server.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/7/artifact/out/patch-unit-hbase-rsgroup.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/7/testReport/ |
| Max. process+thread count | 4343 (vs. ulimit of 10000) |
| modules | C: hbase-protocol hbase-client hbase-server hbase-rsgroup U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/7/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2280: HBASE-18095 branch-1 backport (WIP)
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2280:
URL: https://github.com/apache/hbase/pull/2280#issuecomment-676796895
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 36s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +1 :green_heart: | mvninstall | 10m 16s | branch-1 passed |
| +1 :green_heart: | compile | 0m 39s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 0m 45s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 1m 47s | branch-1 passed |
| +1 :green_heart: | shadedjars | 2m 59s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 50s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 0m 41s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 3m 6s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 3m 1s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 53s | the patch passed |
| +1 :green_heart: | compile | 0m 41s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javac | 0m 41s | the patch passed |
| +1 :green_heart: | compile | 0m 47s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | javac | 0m 47s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 39s | hbase-server: The patch generated 0 new + 220 unchanged - 4 fixed = 220 total (was 224) |
| +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 2m 47s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 4m 36s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | javadoc | 0m 33s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 0m 42s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 2m 54s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 124m 37s | hbase-server in the patch passed. |
| +1 :green_heart: | asflicense | 0m 38s | The patch does not generate ASF License warnings. |
| | | 166m 46s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2280 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux b0b076e274c9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2280/out/precommit/personality/provided.sh |
| git revision | branch-1 / c2e0cf9 |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/2/testReport/ |
| Max. process+thread count | 4401 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/2/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell commented on a change in pull request #2280: HBASE-18095 branch-1 umbrella PR
Posted by GitBox <gi...@apache.org>.
apurtell commented on a change in pull request #2280:
URL: https://github.com/apache/hbase/pull/2280#discussion_r487313143
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
##########
@@ -56,6 +56,7 @@
/** Set this key to {@code true} to enable metrics collection of client requests. */
public static final String CLIENT_SIDE_METRICS_ENABLED_KEY = "hbase.client.metrics.enable";
+ private static final String CNT_BASE = "rpcCount_";
Review comment:
Is this an unrelated change?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java
##########
@@ -1571,43 +1573,31 @@ boolean isMasterRunning() throws ServiceException {
* @throws KeeperException
* @throws ServiceException
*/
- private Object makeStubNoRetries() throws IOException, KeeperException, ServiceException {
- ZooKeeperKeepAliveConnection zkw;
- try {
- zkw = getKeepAliveZooKeeperWatcher();
- } catch (IOException e) {
- ExceptionUtil.rethrowIfInterrupt(e);
- throw new ZooKeeperConnectionException("Can't connect to ZooKeeper", e);
- }
- try {
- checkIfBaseNodeAvailable(zkw);
- ServerName sn = MasterAddressTracker.getMasterAddress(zkw);
- if (sn == null) {
- String msg = "ZooKeeper available but no active master location found";
- LOG.info(msg);
- throw new MasterNotRunningException(msg);
- }
- if (isDeadServer(sn)) {
- throw new MasterNotRunningException(sn + " is dead.");
+ private Object makeStubNoRetries() throws IOException, ServiceException {
+ ServerName sn = registry.getActiveMaster();
+ if (sn == null) {
+ String msg = "ZooKeeper available but no active master location found";
Review comment:
Is this still the correct exception text to emit?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterRegistry.java
##########
@@ -0,0 +1,266 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.client;
+
+import static org.apache.hadoop.hbase.util.DNS.getMasterHostname;
+import com.google.common.base.Preconditions;
+import com.google.common.base.Strings;
+import com.google.common.collect.ImmutableMap;
+import com.google.common.collect.ImmutableSet;
+import com.google.common.net.HostAndPort;
+import com.google.protobuf.Message;
+import com.google.protobuf.RpcController;
+import java.io.IOException;
+import java.net.UnknownHostException;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+import java.util.concurrent.ThreadLocalRandom;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseIOException;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.HRegionLocation;
+import org.apache.hadoop.hbase.RegionLocations;
+import org.apache.hadoop.hbase.ServerName;
+import org.apache.hadoop.hbase.classification.InterfaceAudience;
+import org.apache.hadoop.hbase.exceptions.ClientExceptionsUtil;
+import org.apache.hadoop.hbase.exceptions.MasterRegistryFetchException;
+import org.apache.hadoop.hbase.ipc.BlockingRpcCallback;
+import org.apache.hadoop.hbase.ipc.HBaseRpcController;
+import org.apache.hadoop.hbase.ipc.RpcClient;
+import org.apache.hadoop.hbase.ipc.RpcClientFactory;
+import org.apache.hadoop.hbase.ipc.RpcControllerFactory;
+import org.apache.hadoop.hbase.protobuf.ProtobufUtil;
+import org.apache.hadoop.hbase.protobuf.generated.HBaseProtos;
+import org.apache.hadoop.hbase.security.User;
+
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.ClientMetaService;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetClusterIdRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetClusterIdResponse;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMastersRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMastersResponse;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMastersResponseEntry;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMetaRegionLocationsRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMetaRegionLocationsResponse;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetNumLiveRSRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetNumLiveRSResponse;
+
+/**
+ * Master based registry implementation. Makes RPCs to the configured master addresses from config
+ * {@value org.apache.hadoop.hbase.HConstants#MASTER_ADDRS_KEY}. All the registry methods are
+ * blocking unlike implementations in other branches.
+ */
+@InterfaceAudience.Private
+public class MasterRegistry implements ConnectionRegistry {
+ private static final String MASTER_ADDRS_CONF_SEPARATOR = ",";
+
+ private volatile ImmutableMap<String, ClientMetaService.Interface> masterAddr2Stub;
+
+ // RPC client used to talk to the masters.
+ private RpcClient rpcClient;
+ private RpcControllerFactory rpcControllerFactory;
+ private int rpcTimeoutMs;
+
+ protected MasterAddressRefresher masterAddressRefresher;
+
+ @Override
+ public void init(Connection connection) throws IOException {
+ Configuration conf = connection.getConfiguration();
+ rpcTimeoutMs = (int) Math.min(Integer.MAX_VALUE,
+ conf.getLong(HConstants.HBASE_RPC_TIMEOUT_KEY, HConstants.DEFAULT_HBASE_RPC_TIMEOUT));
+ // XXX: we pass cluster id as null here since we do not have a cluster id yet, we have to fetch
Review comment:
Hmm.
Is there a planned follow up?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
##########
@@ -466,6 +468,9 @@ public void updateRpc(MethodDescriptor method, Message param, CallStats stats) {
if (callsPerServer > 0) {
concurrentCallsPerServerHist.update(callsPerServer);
}
+ // Update the counter that tracks RPCs by type.
+ final String methodName = method.getService().getName() + "_" + method.getName();
Review comment:
Can we break out this change? Metrics are special. They are a separate dimension of compatibility. Having them in a separate commit allows them to get noticed. They should have their own release note. Etc.
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
##########
@@ -466,6 +468,9 @@ public void updateRpc(MethodDescriptor method, Message param, CallStats stats) {
if (callsPerServer > 0) {
concurrentCallsPerServerHist.update(callsPerServer);
}
+ // Update the counter that tracks RPCs by type.
+ final String methodName = method.getService().getName() + "_" + method.getName();
Review comment:
Neat idea but it's coming in from some other work?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2280: HBASE-18095 branch-1 backport (WIP)
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2280:
URL: https://github.com/apache/hbase/pull/2280#issuecomment-688210678
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 34s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 2s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 37 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 53s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 8m 10s | branch-1 passed |
| +1 :green_heart: | compile | 1m 39s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 1m 43s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 13m 0s | branch-1 passed |
| +1 :green_heart: | shadedjars | 2m 59s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 47s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 5m 39s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 2m 43s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 18m 22s | branch-1 passed |
| -0 :warning: | patch | 3m 30s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 54s | the patch passed |
| +1 :green_heart: | compile | 1m 38s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | cc | 1m 38s | the patch passed |
| +1 :green_heart: | javac | 1m 38s | the patch passed |
| +1 :green_heart: | compile | 1m 42s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | cc | 1m 42s | the patch passed |
| +1 :green_heart: | javac | 1m 42s | the patch passed |
| -1 :x: | checkstyle | 0m 55s | hbase-client: The patch generated 12 new + 735 unchanged - 31 fixed = 747 total (was 766) |
| -1 :x: | checkstyle | 2m 29s | hbase-server: The patch generated 99 new + 2097 unchanged - 52 fixed = 2196 total (was 2149) |
| -1 :x: | checkstyle | 6m 22s | root: The patch generated 110 new + 2847 unchanged - 82 fixed = 2957 total (was 2929) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 0s | The patch has 1 ill-formed XML file(s). |
| +1 :green_heart: | shadedjars | 2m 46s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 4m 46s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | hbaseprotoc | 4m 17s | the patch passed |
| +1 :green_heart: | javadoc | 3m 41s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 5m 39s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 20m 17s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 156m 47s | root in the patch failed. |
| +1 :green_heart: | asflicense | 2m 45s | The patch does not generate ASF License warnings. |
| | | 286m 10s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | pom.xml |
| Failed junit tests | hadoop.hbase.regionserver.TestSplitTransactionOnCluster |
| | hadoop.hbase.client.TestMasterRegistry |
| | hadoop.hbase.client.TestFromClientSide |
| | hadoop.hbase.master.TestMasterFailover |
| | hadoop.hbase.snapshot.TestExportSnapshotWithTemporaryDirectory |
| | hadoop.hbase.regionserver.TestMasterAddressTracker |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/19/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2280 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool xml |
| uname | Linux dbe72bd05ebb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2280/out/precommit/personality/provided.sh |
| git revision | branch-1 / 76db1e1 |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/19/artifact/out/diff-checkstyle-hbase-client.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/19/artifact/out/diff-checkstyle-hbase-server.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/19/artifact/out/diff-checkstyle-root.txt |
| xml | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/19/artifact/out/xml.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/19/artifact/out/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/19/testReport/ |
| Max. process+thread count | 4194 (vs. ulimit of 10000) |
| modules | C: hbase-protocol hbase-common hbase-client hbase-server hbase-rsgroup . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/19/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2280: HBASE-18095 branch-1 backport (WIP)
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2280:
URL: https://github.com/apache/hbase/pull/2280#issuecomment-687549998
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 34s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 2s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 1s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 32 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 49s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 7m 54s | branch-1 passed |
| +1 :green_heart: | compile | 1m 37s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 1m 44s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 12m 43s | branch-1 passed |
| +1 :green_heart: | shadedjars | 2m 58s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 47s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 5m 35s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 2m 41s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 18m 10s | branch-1 passed |
| -0 :warning: | patch | 3m 26s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 52s | the patch passed |
| +1 :green_heart: | compile | 1m 40s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | cc | 1m 40s | the patch passed |
| +1 :green_heart: | javac | 1m 40s | the patch passed |
| +1 :green_heart: | compile | 1m 44s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | cc | 1m 44s | the patch passed |
| +1 :green_heart: | javac | 1m 44s | the patch passed |
| -1 :x: | checkstyle | 0m 55s | hbase-client: The patch generated 10 new + 683 unchanged - 31 fixed = 693 total (was 714) |
| -1 :x: | checkstyle | 2m 24s | hbase-server: The patch generated 96 new + 1873 unchanged - 48 fixed = 1969 total (was 1921) |
| -1 :x: | checkstyle | 6m 17s | root: The patch generated 110 new + 2566 unchanged - 83 fixed = 2676 total (was 2649) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 1s | The patch has 1 ill-formed XML file(s). |
| +1 :green_heart: | shadedjars | 2m 47s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 4m 31s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | hbaseprotoc | 4m 20s | the patch passed |
| +1 :green_heart: | javadoc | 3m 41s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 5m 40s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 19m 32s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 154m 46s | root in the patch failed. |
| +1 :green_heart: | asflicense | 2m 45s | The patch does not generate ASF License warnings. |
| | | 282m 5s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | pom.xml |
| Failed junit tests | hadoop.hbase.snapshot.TestExportSnapshotWithTemporaryDirectory |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/16/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2280 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool xml |
| uname | Linux 50dfc45d7b79 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2280/out/precommit/personality/provided.sh |
| git revision | branch-1 / 76db1e1 |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/16/artifact/out/diff-checkstyle-hbase-client.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/16/artifact/out/diff-checkstyle-hbase-server.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/16/artifact/out/diff-checkstyle-root.txt |
| xml | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/16/artifact/out/xml.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/16/artifact/out/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/16/testReport/ |
| Max. process+thread count | 4317 (vs. ulimit of 10000) |
| modules | C: hbase-protocol hbase-common hbase-client hbase-server hbase-rsgroup . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/16/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2280: HBASE-18095 branch-1 backport (WIP)
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2280:
URL: https://github.com/apache/hbase/pull/2280#issuecomment-688628157
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 36s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 2s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 37 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 50s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 7m 52s | branch-1 passed |
| +1 :green_heart: | compile | 1m 40s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 1m 45s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 13m 0s | branch-1 passed |
| +1 :green_heart: | shadedjars | 2m 59s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 48s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 5m 44s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 2m 39s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 18m 14s | branch-1 passed |
| -0 :warning: | patch | 3m 25s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 54s | the patch passed |
| +1 :green_heart: | compile | 1m 42s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | cc | 1m 42s | the patch passed |
| +1 :green_heart: | javac | 1m 42s | the patch passed |
| +1 :green_heart: | compile | 1m 45s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | cc | 1m 45s | the patch passed |
| +1 :green_heart: | javac | 1m 45s | the patch passed |
| -1 :x: | checkstyle | 0m 55s | hbase-client: The patch generated 13 new + 735 unchanged - 31 fixed = 748 total (was 766) |
| -1 :x: | checkstyle | 2m 30s | hbase-server: The patch generated 100 new + 2097 unchanged - 52 fixed = 2197 total (was 2149) |
| -1 :x: | checkstyle | 6m 22s | root: The patch generated 112 new + 2847 unchanged - 82 fixed = 2959 total (was 2929) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 0s | The patch has 1 ill-formed XML file(s). |
| +1 :green_heart: | shadedjars | 2m 50s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 4m 41s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | hbaseprotoc | 4m 19s | the patch passed |
| +1 :green_heart: | javadoc | 3m 43s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 5m 41s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 19m 33s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 155m 31s | root in the patch failed. |
| +1 :green_heart: | asflicense | 2m 48s | The patch does not generate ASF License warnings. |
| | | 284m 27s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | pom.xml |
| Failed junit tests | hadoop.hbase.client.TestFromClientSide |
| | hadoop.hbase.master.TestMasterFailover |
| | hadoop.hbase.snapshot.TestExportSnapshotWithTemporaryDirectory |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/20/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2280 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool xml |
| uname | Linux e95655680d00 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2280/out/precommit/personality/provided.sh |
| git revision | branch-1 / e5c0a94 |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/20/artifact/out/diff-checkstyle-hbase-client.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/20/artifact/out/diff-checkstyle-hbase-server.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/20/artifact/out/diff-checkstyle-root.txt |
| xml | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/20/artifact/out/xml.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/20/artifact/out/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/20/testReport/ |
| Max. process+thread count | 4250 (vs. ulimit of 10000) |
| modules | C: hbase-protocol hbase-common hbase-client hbase-server hbase-rsgroup . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/20/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2280: HBASE-18095 branch-1 backport (WIP)
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2280:
URL: https://github.com/apache/hbase/pull/2280#issuecomment-676638197
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 6m 40s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +1 :green_heart: | mvninstall | 9m 53s | branch-1 passed |
| +1 :green_heart: | compile | 0m 41s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 0m 44s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 1m 45s | branch-1 passed |
| +1 :green_heart: | shadedjars | 3m 1s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 49s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 0m 40s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 3m 6s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 3m 2s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 54s | the patch passed |
| +1 :green_heart: | compile | 0m 41s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javac | 0m 41s | the patch passed |
| +1 :green_heart: | compile | 0m 44s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | javac | 0m 44s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 33s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 2m 49s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 4m 49s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | javadoc | 0m 34s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 0m 44s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 3m 33s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 133m 20s | hbase-server in the patch passed. |
| +1 :green_heart: | asflicense | 0m 40s | The patch does not generate ASF License warnings. |
| | | 183m 6s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2280 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux ce6cb475fc49 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2280/out/precommit/personality/provided.sh |
| git revision | branch-1 / c2e0cf9 |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/1/testReport/ |
| Max. process+thread count | 4770 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/1/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2280: HBASE-18095 branch-1 backport (WIP)
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2280:
URL: https://github.com/apache/hbase/pull/2280#issuecomment-684665927
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 35s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 2s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| -1 :x: | hbaseanti | 0m 0s | The patch appears use Hadoop classification instead of HBase. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 30 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 30s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 8m 5s | branch-1 passed |
| +1 :green_heart: | compile | 1m 45s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 2m 0s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 6m 9s | branch-1 passed |
| +1 :green_heart: | shadedjars | 3m 0s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 28s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 1m 39s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 2m 38s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 7m 4s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 57s | the patch passed |
| +1 :green_heart: | compile | 1m 46s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | cc | 1m 46s | the patch passed |
| +1 :green_heart: | javac | 1m 46s | the patch passed |
| +1 :green_heart: | compile | 1m 58s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | cc | 1m 58s | the patch passed |
| +1 :green_heart: | javac | 1m 58s | the patch passed |
| -1 :x: | checkstyle | 0m 53s | hbase-client: The patch generated 4 new + 688 unchanged - 25 fixed = 692 total (was 713) |
| -1 :x: | checkstyle | 2m 21s | hbase-server: The patch generated 45 new + 1865 unchanged - 50 fixed = 1910 total (was 1915) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 2m 48s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 4m 44s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | hbaseprotoc | 2m 12s | the patch passed |
| +1 :green_heart: | javadoc | 1m 16s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 1m 38s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 7m 39s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 29s | hbase-protocol in the patch passed. |
| +1 :green_heart: | unit | 2m 44s | hbase-client in the patch passed. |
| -1 :x: | unit | 133m 21s | hbase-server in the patch failed. |
| -1 :x: | unit | 13m 0s | hbase-rsgroup in the patch failed. |
| +1 :green_heart: | asflicense | 1m 51s | The patch does not generate ASF License warnings. |
| | | 224m 50s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hbase.master.cleaner.TestSnapshotFromMaster |
| | hadoop.hbase.client.TestSnapshotCloneIndependence |
| | hadoop.hbase.client.TestSnapshotWithAcl |
| | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
| | hadoop.hbase.client.TestRestoreSnapshotFromClient |
| | hadoop.hbase.client.TestSnapshotTemporaryDirectory |
| | hadoop.hbase.namespace.TestZKLessNamespaceAuditor |
| | hadoop.hbase.master.snapshot.TestSnapshotFileCache |
| | hadoop.hbase.master.procedure.TestCreateTableProcedure2 |
| | hadoop.hbase.TestDrainingServer |
| | hadoop.hbase.client.TestSnapshotMetadata |
| | hadoop.hbase.snapshot.TestConcurrentFlushSnapshotFromClient |
| | hadoop.hbase.client.TestRestoreSnapshotFromClientWithRegionReplicas |
| | hadoop.hbase.snapshot.TestSecureExportSnapshot |
| | hadoop.hbase.master.handler.TestCreateTableHandler |
| | hadoop.hbase.namespace.TestNamespaceAuditor |
| | hadoop.hbase.coprocessor.TestMasterObserver |
| | hadoop.hbase.client.TestCloneSnapshotFromClient |
| | hadoop.hbase.master.TestMasterFailover |
| | hadoop.hbase.snapshot.TestFlushSnapshotFromClient |
| | hadoop.hbase.snapshot.TestExportSnapshot |
| | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory |
| | hadoop.hbase.snapshot.TestExportSnapshotWithTemporaryDirectory |
| | hadoop.hbase.snapshot.TestRestoreFlushSnapshotFromClient |
| | hadoop.hbase.rsgroup.TestRSGroupsBasics |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/8/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2280 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool |
| uname | Linux 807e2381961d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2280/out/precommit/personality/provided.sh |
| git revision | branch-1 / 041debd |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/8/artifact/out/diff-checkstyle-hbase-client.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/8/artifact/out/diff-checkstyle-hbase-server.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/8/artifact/out/patch-unit-hbase-server.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/8/artifact/out/patch-unit-hbase-rsgroup.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/8/testReport/ |
| Max. process+thread count | 4350 (vs. ulimit of 10000) |
| modules | C: hbase-protocol hbase-client hbase-server hbase-rsgroup U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/8/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2280: HBASE-18095 branch-1 backport (WIP)
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2280:
URL: https://github.com/apache/hbase/pull/2280#issuecomment-678091366
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 36s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 6 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 26s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 7m 57s | branch-1 passed |
| +1 :green_heart: | compile | 1m 24s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 1m 36s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 4m 57s | branch-1 passed |
| +1 :green_heart: | shadedjars | 3m 1s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 13s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 1m 17s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 2m 41s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 6m 21s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 52s | the patch passed |
| +1 :green_heart: | compile | 1m 25s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | cc | 1m 25s | the patch passed |
| +1 :green_heart: | javac | 1m 25s | the patch passed |
| +1 :green_heart: | compile | 1m 37s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | cc | 1m 37s | the patch passed |
| +1 :green_heart: | javac | 1m 37s | the patch passed |
| -1 :x: | checkstyle | 0m 42s | hbase-client: The patch generated 7 new + 281 unchanged - 1 fixed = 288 total (was 282) |
| -1 :x: | checkstyle | 1m 40s | hbase-server: The patch generated 5 new + 243 unchanged - 5 fixed = 248 total (was 248) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 2m 50s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 4m 41s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | hbaseprotoc | 1m 50s | the patch passed |
| +1 :green_heart: | javadoc | 1m 1s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 1m 18s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 6m 37s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 27s | hbase-protocol in the patch passed. |
| +1 :green_heart: | unit | 2m 44s | hbase-client in the patch passed. |
| +1 :green_heart: | unit | 125m 0s | hbase-server in the patch passed. |
| +1 :green_heart: | asflicense | 1m 6s | The patch does not generate ASF License warnings. |
| | | 192m 46s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/5/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2280 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool |
| uname | Linux a24c9dc336a0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2280/out/precommit/personality/provided.sh |
| git revision | branch-1 / c2e0cf9 |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/5/artifact/out/diff-checkstyle-hbase-client.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/5/artifact/out/diff-checkstyle-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/5/testReport/ |
| Max. process+thread count | 4358 (vs. ulimit of 10000) |
| modules | C: hbase-protocol hbase-client hbase-server U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/5/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2280: HBASE-18095 branch-1 backport (WIP)
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2280:
URL: https://github.com/apache/hbase/pull/2280#issuecomment-686207562
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 35s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 1s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 31 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 49s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 7m 49s | branch-1 passed |
| +1 :green_heart: | compile | 1m 39s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 1m 46s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 12m 13s | branch-1 passed |
| +1 :green_heart: | shadedjars | 2m 57s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 29s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 5m 17s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 2m 47s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 17m 14s | branch-1 passed |
| -0 :warning: | patch | 3m 24s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 54s | the patch passed |
| +1 :green_heart: | compile | 1m 38s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | cc | 1m 38s | the patch passed |
| +1 :green_heart: | javac | 1m 39s | the patch passed |
| +1 :green_heart: | compile | 1m 41s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | cc | 1m 41s | the patch passed |
| +1 :green_heart: | javac | 1m 41s | the patch passed |
| -1 :x: | checkstyle | 0m 52s | hbase-client: The patch generated 12 new + 682 unchanged - 32 fixed = 694 total (was 714) |
| -1 :x: | checkstyle | 2m 22s | hbase-server: The patch generated 97 new + 1860 unchanged - 49 fixed = 1957 total (was 1909) |
| -1 :x: | checkstyle | 6m 8s | root: The patch generated 105 new + 2548 unchanged - 77 fixed = 2653 total (was 2625) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 0s | The patch has 1 ill-formed XML file(s). |
| +1 :green_heart: | shadedjars | 2m 48s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 4m 42s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | hbaseprotoc | 3m 51s | the patch passed |
| +1 :green_heart: | javadoc | 3m 22s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 5m 17s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 18m 23s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 154m 25s | root in the patch failed. |
| +1 :green_heart: | asflicense | 2m 20s | The patch does not generate ASF License warnings. |
| | | 276m 12s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | pom.xml |
| Failed junit tests | hadoop.hbase.snapshot.TestExportSnapshotWithTemporaryDirectory |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/13/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2280 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool xml |
| uname | Linux 84af55fcad48 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2280/out/precommit/personality/provided.sh |
| git revision | branch-1 / 1dc75e7 |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/13/artifact/out/diff-checkstyle-hbase-client.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/13/artifact/out/diff-checkstyle-hbase-server.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/13/artifact/out/diff-checkstyle-root.txt |
| xml | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/13/artifact/out/xml.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/13/artifact/out/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/13/testReport/ |
| Max. process+thread count | 4323 (vs. ulimit of 10000) |
| modules | C: hbase-protocol hbase-client hbase-server hbase-rsgroup . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/13/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2280: HBASE-18095 branch-1 backport (WIP)
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2280:
URL: https://github.com/apache/hbase/pull/2280#issuecomment-685159284
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 36s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 2s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| -1 :x: | hbaseanti | 0m 0s | The patch appears use Hadoop classification instead of HBase. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 31 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 28s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 8m 5s | branch-1 passed |
| +1 :green_heart: | compile | 1m 55s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 2m 1s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 6m 11s | branch-1 passed |
| +1 :green_heart: | shadedjars | 3m 1s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 29s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 1m 36s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 2m 39s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 7m 5s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 53s | the patch passed |
| +1 :green_heart: | compile | 1m 44s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | cc | 1m 44s | the patch passed |
| +1 :green_heart: | javac | 1m 44s | the patch passed |
| +1 :green_heart: | compile | 2m 5s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | cc | 2m 5s | the patch passed |
| +1 :green_heart: | javac | 2m 5s | the patch passed |
| -1 :x: | checkstyle | 0m 55s | hbase-client: The patch generated 1 new + 691 unchanged - 21 fixed = 692 total (was 712) |
| -1 :x: | checkstyle | 2m 18s | hbase-server: The patch generated 34 new + 1866 unchanged - 43 fixed = 1900 total (was 1909) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 2m 49s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 4m 46s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | hbaseprotoc | 2m 13s | the patch passed |
| +1 :green_heart: | javadoc | 1m 15s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 1m 36s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 7m 51s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 28s | hbase-protocol in the patch passed. |
| +1 :green_heart: | unit | 2m 41s | hbase-client in the patch passed. |
| -1 :x: | unit | 139m 55s | hbase-server in the patch failed. |
| +1 :green_heart: | unit | 12m 29s | hbase-rsgroup in the patch passed. |
| +1 :green_heart: | asflicense | 1m 52s | The patch does not generate ASF License warnings. |
| | | 231m 20s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hbase.master.cleaner.TestSnapshotFromMaster |
| | hadoop.hbase.master.snapshot.TestSnapshotFileCache |
| | hadoop.hbase.master.procedure.TestCreateTableProcedure2 |
| | hadoop.hbase.TestDrainingServer |
| | hadoop.hbase.snapshot.TestSecureExportSnapshot |
| | hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles |
| | hadoop.hbase.master.TestMasterFailover |
| | hadoop.hbase.snapshot.TestExportSnapshot |
| | hadoop.hbase.snapshot.TestExportSnapshotWithTemporaryDirectory |
| | hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/10/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2280 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool |
| uname | Linux 0805b901d23a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2280/out/precommit/personality/provided.sh |
| git revision | branch-1 / 80ce76c |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/10/artifact/out/diff-checkstyle-hbase-client.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/10/artifact/out/diff-checkstyle-hbase-server.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/10/artifact/out/patch-unit-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/10/testReport/ |
| Max. process+thread count | 4321 (vs. ulimit of 10000) |
| modules | C: hbase-protocol hbase-client hbase-server hbase-rsgroup U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/10/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell commented on a change in pull request #2280: HBASE-18095 branch-1 umbrella PR
Posted by GitBox <gi...@apache.org>.
apurtell commented on a change in pull request #2280:
URL: https://github.com/apache/hbase/pull/2280#discussion_r487313143
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
##########
@@ -56,6 +56,7 @@
/** Set this key to {@code true} to enable metrics collection of client requests. */
public static final String CLIENT_SIDE_METRICS_ENABLED_KEY = "hbase.client.metrics.enable";
+ private static final String CNT_BASE = "rpcCount_";
Review comment:
Is this an unrelated change?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java
##########
@@ -1571,43 +1573,31 @@ boolean isMasterRunning() throws ServiceException {
* @throws KeeperException
* @throws ServiceException
*/
- private Object makeStubNoRetries() throws IOException, KeeperException, ServiceException {
- ZooKeeperKeepAliveConnection zkw;
- try {
- zkw = getKeepAliveZooKeeperWatcher();
- } catch (IOException e) {
- ExceptionUtil.rethrowIfInterrupt(e);
- throw new ZooKeeperConnectionException("Can't connect to ZooKeeper", e);
- }
- try {
- checkIfBaseNodeAvailable(zkw);
- ServerName sn = MasterAddressTracker.getMasterAddress(zkw);
- if (sn == null) {
- String msg = "ZooKeeper available but no active master location found";
- LOG.info(msg);
- throw new MasterNotRunningException(msg);
- }
- if (isDeadServer(sn)) {
- throw new MasterNotRunningException(sn + " is dead.");
+ private Object makeStubNoRetries() throws IOException, ServiceException {
+ ServerName sn = registry.getActiveMaster();
+ if (sn == null) {
+ String msg = "ZooKeeper available but no active master location found";
Review comment:
Is this still the correct exception text to emit?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterRegistry.java
##########
@@ -0,0 +1,266 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.client;
+
+import static org.apache.hadoop.hbase.util.DNS.getMasterHostname;
+import com.google.common.base.Preconditions;
+import com.google.common.base.Strings;
+import com.google.common.collect.ImmutableMap;
+import com.google.common.collect.ImmutableSet;
+import com.google.common.net.HostAndPort;
+import com.google.protobuf.Message;
+import com.google.protobuf.RpcController;
+import java.io.IOException;
+import java.net.UnknownHostException;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+import java.util.concurrent.ThreadLocalRandom;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseIOException;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.HRegionLocation;
+import org.apache.hadoop.hbase.RegionLocations;
+import org.apache.hadoop.hbase.ServerName;
+import org.apache.hadoop.hbase.classification.InterfaceAudience;
+import org.apache.hadoop.hbase.exceptions.ClientExceptionsUtil;
+import org.apache.hadoop.hbase.exceptions.MasterRegistryFetchException;
+import org.apache.hadoop.hbase.ipc.BlockingRpcCallback;
+import org.apache.hadoop.hbase.ipc.HBaseRpcController;
+import org.apache.hadoop.hbase.ipc.RpcClient;
+import org.apache.hadoop.hbase.ipc.RpcClientFactory;
+import org.apache.hadoop.hbase.ipc.RpcControllerFactory;
+import org.apache.hadoop.hbase.protobuf.ProtobufUtil;
+import org.apache.hadoop.hbase.protobuf.generated.HBaseProtos;
+import org.apache.hadoop.hbase.security.User;
+
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.ClientMetaService;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetClusterIdRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetClusterIdResponse;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMastersRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMastersResponse;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMastersResponseEntry;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMetaRegionLocationsRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMetaRegionLocationsResponse;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetNumLiveRSRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetNumLiveRSResponse;
+
+/**
+ * Master based registry implementation. Makes RPCs to the configured master addresses from config
+ * {@value org.apache.hadoop.hbase.HConstants#MASTER_ADDRS_KEY}. All the registry methods are
+ * blocking unlike implementations in other branches.
+ */
+@InterfaceAudience.Private
+public class MasterRegistry implements ConnectionRegistry {
+ private static final String MASTER_ADDRS_CONF_SEPARATOR = ",";
+
+ private volatile ImmutableMap<String, ClientMetaService.Interface> masterAddr2Stub;
+
+ // RPC client used to talk to the masters.
+ private RpcClient rpcClient;
+ private RpcControllerFactory rpcControllerFactory;
+ private int rpcTimeoutMs;
+
+ protected MasterAddressRefresher masterAddressRefresher;
+
+ @Override
+ public void init(Connection connection) throws IOException {
+ Configuration conf = connection.getConfiguration();
+ rpcTimeoutMs = (int) Math.min(Integer.MAX_VALUE,
+ conf.getLong(HConstants.HBASE_RPC_TIMEOUT_KEY, HConstants.DEFAULT_HBASE_RPC_TIMEOUT));
+ // XXX: we pass cluster id as null here since we do not have a cluster id yet, we have to fetch
Review comment:
Hmm.
Is there a planned follow up?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
##########
@@ -466,6 +468,9 @@ public void updateRpc(MethodDescriptor method, Message param, CallStats stats) {
if (callsPerServer > 0) {
concurrentCallsPerServerHist.update(callsPerServer);
}
+ // Update the counter that tracks RPCs by type.
+ final String methodName = method.getService().getName() + "_" + method.getName();
Review comment:
Can we break out this change? Metrics are special. They are a separate dimension of compatibility. Having them in a separate commit allows them to get noticed. They should have their own release note. Etc.
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
##########
@@ -466,6 +468,9 @@ public void updateRpc(MethodDescriptor method, Message param, CallStats stats) {
if (callsPerServer > 0) {
concurrentCallsPerServerHist.update(callsPerServer);
}
+ // Update the counter that tracks RPCs by type.
+ final String methodName = method.getService().getName() + "_" + method.getName();
Review comment:
Neat idea but it's coming in from some other work?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bharathv commented on a change in pull request #2280: HBASE-18095 branch-1 umbrella PR
Posted by GitBox <gi...@apache.org>.
bharathv commented on a change in pull request #2280:
URL: https://github.com/apache/hbase/pull/2280#discussion_r487440011
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
##########
@@ -56,6 +56,7 @@
/** Set this key to {@code true} to enable metrics collection of client requests. */
public static final String CLIENT_SIDE_METRICS_ENABLED_KEY = "hbase.client.metrics.enable";
+ private static final String CNT_BASE = "rpcCount_";
Review comment:
This landed as a part of #2130 (HBASE-24765). Nick suggested that we should have a way of accounting all RPCs that happen from a client perspective and this seemed like a good and clean way to me. Given this already was already clubbed with HBASE-24765 in master, you still want to separate it here?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterRegistry.java
##########
@@ -0,0 +1,266 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.client;
+
+import static org.apache.hadoop.hbase.util.DNS.getMasterHostname;
+import com.google.common.base.Preconditions;
+import com.google.common.base.Strings;
+import com.google.common.collect.ImmutableMap;
+import com.google.common.collect.ImmutableSet;
+import com.google.common.net.HostAndPort;
+import com.google.protobuf.Message;
+import com.google.protobuf.RpcController;
+import java.io.IOException;
+import java.net.UnknownHostException;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+import java.util.concurrent.ThreadLocalRandom;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseIOException;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.HRegionLocation;
+import org.apache.hadoop.hbase.RegionLocations;
+import org.apache.hadoop.hbase.ServerName;
+import org.apache.hadoop.hbase.classification.InterfaceAudience;
+import org.apache.hadoop.hbase.exceptions.ClientExceptionsUtil;
+import org.apache.hadoop.hbase.exceptions.MasterRegistryFetchException;
+import org.apache.hadoop.hbase.ipc.BlockingRpcCallback;
+import org.apache.hadoop.hbase.ipc.HBaseRpcController;
+import org.apache.hadoop.hbase.ipc.RpcClient;
+import org.apache.hadoop.hbase.ipc.RpcClientFactory;
+import org.apache.hadoop.hbase.ipc.RpcControllerFactory;
+import org.apache.hadoop.hbase.protobuf.ProtobufUtil;
+import org.apache.hadoop.hbase.protobuf.generated.HBaseProtos;
+import org.apache.hadoop.hbase.security.User;
+
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.ClientMetaService;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetClusterIdRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetClusterIdResponse;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMastersRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMastersResponse;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMastersResponseEntry;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMetaRegionLocationsRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetMetaRegionLocationsResponse;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetNumLiveRSRequest;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.GetNumLiveRSResponse;
+
+/**
+ * Master based registry implementation. Makes RPCs to the configured master addresses from config
+ * {@value org.apache.hadoop.hbase.HConstants#MASTER_ADDRS_KEY}. All the registry methods are
+ * blocking unlike implementations in other branches.
+ */
+@InterfaceAudience.Private
+public class MasterRegistry implements ConnectionRegistry {
+ private static final String MASTER_ADDRS_CONF_SEPARATOR = ",";
+
+ private volatile ImmutableMap<String, ClientMetaService.Interface> masterAddr2Stub;
+
+ // RPC client used to talk to the masters.
+ private RpcClient rpcClient;
+ private RpcControllerFactory rpcControllerFactory;
+ private int rpcTimeoutMs;
+
+ protected MasterAddressRefresher masterAddressRefresher;
+
+ @Override
+ public void init(Connection connection) throws IOException {
+ Configuration conf = connection.getConfiguration();
+ rpcTimeoutMs = (int) Math.min(Integer.MAX_VALUE,
+ conf.getLong(HConstants.HBASE_RPC_TIMEOUT_KEY, HConstants.DEFAULT_HBASE_RPC_TIMEOUT));
+ // XXX: we pass cluster id as null here since we do not have a cluster id yet, we have to fetch
Review comment:
Let me create a jira for this. It's like a chicken and egg problem at this point. I'm studying digest based auth to see if there is a way to move away from cluster ID (I don't fully understand it now). Currently this limitation exists in all branches.
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java
##########
@@ -1571,43 +1573,31 @@ boolean isMasterRunning() throws ServiceException {
* @throws KeeperException
* @throws ServiceException
*/
- private Object makeStubNoRetries() throws IOException, KeeperException, ServiceException {
- ZooKeeperKeepAliveConnection zkw;
- try {
- zkw = getKeepAliveZooKeeperWatcher();
- } catch (IOException e) {
- ExceptionUtil.rethrowIfInterrupt(e);
- throw new ZooKeeperConnectionException("Can't connect to ZooKeeper", e);
- }
- try {
- checkIfBaseNodeAvailable(zkw);
- ServerName sn = MasterAddressTracker.getMasterAddress(zkw);
- if (sn == null) {
- String msg = "ZooKeeper available but no active master location found";
- LOG.info(msg);
- throw new MasterNotRunningException(msg);
- }
- if (isDeadServer(sn)) {
- throw new MasterNotRunningException(sn + " is dead.");
+ private Object makeStubNoRetries() throws IOException, ServiceException {
+ ServerName sn = registry.getActiveMaster();
+ if (sn == null) {
+ String msg = "ZooKeeper available but no active master location found";
Review comment:
Fixed.
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
##########
@@ -466,6 +468,9 @@ public void updateRpc(MethodDescriptor method, Message param, CallStats stats) {
if (callsPerServer > 0) {
concurrentCallsPerServerHist.update(callsPerServer);
}
+ // Update the counter that tracks RPCs by type.
+ final String methodName = method.getService().getName() + "_" + method.getName();
Review comment:
Responded above. Let me know if you still think it should be a separate change, I'll do it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2280: HBASE-18095 branch-1 umbrella PR
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2280:
URL: https://github.com/apache/hbase/pull/2280#issuecomment-689151514
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 13m 3s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 37 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 46s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 8m 7s | branch-1 passed |
| +1 :green_heart: | compile | 1m 49s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 1m 55s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 13m 25s | branch-1 passed |
| +1 :green_heart: | shadedjars | 3m 20s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 54s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 6m 8s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 3m 2s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 20m 20s | branch-1 passed |
| -0 :warning: | patch | 3m 43s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 11s | the patch passed |
| +1 :green_heart: | compile | 1m 51s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | cc | 1m 51s | the patch passed |
| +1 :green_heart: | javac | 1m 51s | the patch passed |
| +1 :green_heart: | compile | 2m 3s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | cc | 2m 3s | the patch passed |
| +1 :green_heart: | javac | 2m 3s | the patch passed |
| -1 :x: | checkstyle | 0m 49s | hbase-client: The patch generated 16 new + 732 unchanged - 34 fixed = 748 total (was 766) |
| -1 :x: | checkstyle | 2m 24s | hbase-server: The patch generated 99 new + 2098 unchanged - 51 fixed = 2197 total (was 2149) |
| -1 :x: | checkstyle | 6m 57s | root: The patch generated 113 new + 2846 unchanged - 83 fixed = 2959 total (was 2929) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 0s | The patch has 1 ill-formed XML file(s). |
| +1 :green_heart: | shadedjars | 3m 17s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 5m 39s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | hbaseprotoc | 5m 5s | the patch passed |
| +1 :green_heart: | javadoc | 4m 13s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 6m 23s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 22m 20s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 201m 4s | root in the patch failed. |
| +1 :green_heart: | asflicense | 2m 24s | The patch does not generate ASF License warnings. |
| | | 352m 54s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | pom.xml |
| Failed junit tests | hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint |
| | hadoop.hbase.util.TestHBaseFsck |
| | hadoop.hbase.snapshot.TestExportSnapshotWithTemporaryDirectory |
| | hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles |
| | hadoop.hbase.security.visibility.TestVisibilityLabelsWithACL |
| | hadoop.hbase.mapreduce.TestLoadIncrementalHFiles |
| | hadoop.hbase.client.TestFromClientSide |
| | hadoop.hbase.replication.TestReplicationEndpoint |
| | hadoop.hbase.regionserver.TestSplitTransactionOnCluster |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/21/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2280 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool xml |
| uname | Linux 20bbbd3dede7 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-2280/out/precommit/personality/provided.sh |
| git revision | branch-1 / e5c0a94 |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/21/artifact/out/diff-checkstyle-hbase-client.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/21/artifact/out/diff-checkstyle-hbase-server.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/21/artifact/out/diff-checkstyle-root.txt |
| xml | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/21/artifact/out/xml.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/21/artifact/out/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/21/testReport/ |
| Max. process+thread count | 4983 (vs. ulimit of 10000) |
| modules | C: hbase-protocol hbase-common hbase-client hbase-server hbase-rsgroup . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/21/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bharathv commented on pull request #2280: HBASE-18095 branch-1 umbrella PR
Posted by GitBox <gi...@apache.org>.
bharathv commented on pull request #2280:
URL: https://github.com/apache/hbase/pull/2280#issuecomment-695078362
Rebased on the latest branch-1 tip. Will merge after the test run later today.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2280: HBASE-18095 branch-1 backport (WIP)
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2280:
URL: https://github.com/apache/hbase/pull/2280#issuecomment-687477632
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 6m 42s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 2s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 32 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 49s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 7m 49s | branch-1 passed |
| +1 :green_heart: | compile | 1m 40s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 1m 41s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 12m 40s | branch-1 passed |
| +1 :green_heart: | shadedjars | 2m 58s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 45s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 5m 38s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 2m 39s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 18m 18s | branch-1 passed |
| -0 :warning: | patch | 3m 24s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 54s | the patch passed |
| +1 :green_heart: | compile | 1m 38s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | cc | 1m 38s | the patch passed |
| +1 :green_heart: | javac | 1m 38s | the patch passed |
| +1 :green_heart: | compile | 1m 41s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | cc | 1m 41s | the patch passed |
| +1 :green_heart: | javac | 1m 41s | the patch passed |
| -1 :x: | checkstyle | 0m 54s | hbase-client: The patch generated 22 new + 680 unchanged - 34 fixed = 702 total (was 714) |
| -1 :x: | checkstyle | 2m 22s | hbase-server: The patch generated 96 new + 1873 unchanged - 48 fixed = 1969 total (was 1921) |
| -1 :x: | checkstyle | 6m 10s | root: The patch generated 115 new + 2570 unchanged - 79 fixed = 2685 total (was 2649) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 1s | The patch has 1 ill-formed XML file(s). |
| -1 :x: | shadedjars | 1m 11s | patch has 10 errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 4m 37s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | hbaseprotoc | 4m 20s | the patch passed |
| +1 :green_heart: | javadoc | 3m 38s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 5m 37s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 19m 29s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 10m 19s | root in the patch failed. |
| -1 :x: | asflicense | 1m 22s | The patch generated 1 ASF License warnings. |
| | | 140m 26s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | pom.xml |
| Failed junit tests | hadoop.hbase.TestInterfaceAudienceAnnotations |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/15/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2280 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool xml |
| uname | Linux ffe3c4ee8ff9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2280/out/precommit/personality/provided.sh |
| git revision | branch-1 / 76db1e1 |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/15/artifact/out/diff-checkstyle-hbase-client.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/15/artifact/out/diff-checkstyle-hbase-server.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/15/artifact/out/diff-checkstyle-root.txt |
| xml | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/15/artifact/out/xml.txt |
| shadedjars | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/15/artifact/out/patch-shadedjars.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/15/artifact/out/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/15/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/15/artifact/out/patch-asflicense-problems.txt |
| Max. process+thread count | 181 (vs. ulimit of 10000) |
| modules | C: hbase-protocol hbase-common hbase-client hbase-server hbase-rsgroup . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/15/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2280: HBASE-18095 branch-1 umbrella PR
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2280:
URL: https://github.com/apache/hbase/pull/2280#issuecomment-693663717
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 37s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 2s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 1s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 37 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 2m 49s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 7m 59s | branch-1 passed |
| +1 :green_heart: | compile | 1m 42s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 1m 43s | branch-1 passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 13m 0s | branch-1 passed |
| +1 :green_heart: | shadedjars | 2m 58s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 47s | branch-1 passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 5m 39s | branch-1 passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 2m 42s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 18m 24s | branch-1 passed |
| -0 :warning: | patch | 3m 27s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 53s | the patch passed |
| +1 :green_heart: | compile | 1m 44s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | cc | 1m 44s | the patch passed |
| +1 :green_heart: | javac | 1m 44s | the patch passed |
| +1 :green_heart: | compile | 1m 45s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | cc | 1m 45s | the patch passed |
| +1 :green_heart: | javac | 1m 45s | the patch passed |
| -1 :x: | checkstyle | 0m 54s | hbase-client: The patch generated 17 new + 740 unchanged - 31 fixed = 757 total (was 771) |
| -1 :x: | checkstyle | 2m 32s | hbase-server: The patch generated 100 new + 2097 unchanged - 52 fixed = 2197 total (was 2149) |
| -1 :x: | checkstyle | 6m 23s | root: The patch generated 120 new + 2848 unchanged - 86 fixed = 2968 total (was 2934) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 0s | The patch has 1 ill-formed XML file(s). |
| +1 :green_heart: | shadedjars | 2m 47s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 4m 35s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | hbaseprotoc | 4m 16s | the patch passed |
| +1 :green_heart: | javadoc | 3m 39s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 5m 35s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | findbugs | 19m 38s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 156m 38s | root in the patch failed. |
| +1 :green_heart: | asflicense | 2m 46s | The patch does not generate ASF License warnings. |
| | | 285m 12s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | pom.xml |
| Failed junit tests | hadoop.hbase.client.TestFromClientSide |
| | hadoop.hbase.util.TestHBaseFsck |
| | hadoop.hbase.snapshot.TestExportSnapshotWithTemporaryDirectory |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/22/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2280 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool xml |
| uname | Linux 1c2c4eca510b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2280/out/precommit/personality/provided.sh |
| git revision | branch-1 / 7801b45 |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/22/artifact/out/diff-checkstyle-hbase-client.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/22/artifact/out/diff-checkstyle-hbase-server.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/22/artifact/out/diff-checkstyle-root.txt |
| xml | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/22/artifact/out/xml.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/22/artifact/out/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/22/testReport/ |
| Max. process+thread count | 4273 (vs. ulimit of 10000) |
| modules | C: hbase-protocol hbase-common hbase-client hbase-server hbase-rsgroup . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/22/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bharathv commented on pull request #2280: HBASE-18095 branch-1 backport (WIP)
Posted by GitBox <gi...@apache.org>.
bharathv commented on pull request #2280:
URL: https://github.com/apache/hbase/pull/2280#issuecomment-678381679
Back ported until the commit that implements all the server side RPCs needed by the registry. The build is clean so far. Next step is to back port the registry changes. I might have to reimplement it given all the client side incompatibilities.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org