You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/06 22:15:42 UTC

[jira] [Commented] (BEAM-1903) Splittable DoFn should report watermarks via ProcessContext

    [ https://issues.apache.org/jira/browse/BEAM-1903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959881#comment-15959881 ] 

ASF GitHub Bot commented on BEAM-1903:
--------------------------------------

GitHub user jkff opened a pull request:

    https://github.com/apache/beam/pull/2455

    [BEAM-1903, BEAM-1904] Fixes SDF issues re: watermarks and stop/resume

    See detailed discussion in document:
    https://docs.google.com/document/d/1BGc8pM1GOvZhwR9SARSVte-20XEoBUxrGJ5gTWXdv3c/edit
    
    In particular, this PR:
    - Removes DoFn.ProcessContinuation and all the code and tests that handled returning resume() - from DoFnSignatures, DoFnInvokers, and SplittableParDo and runner hooks, as well as inference of UnboundedPerElement from the return value.
    - Adds ProcessContext.updateWatermark(), currently allowed to be called only from SDF. This has surprisingly little impact - basically just a "throw unsupported" implementation in SimpleDoFnRunner and DoFnTester, and a proper implementation in SDF code
    - Adds RestrictionTracker.checkDone() and unit tests
    
    Overall this looks much easier of a change than I thought, and should be pretty easy to review.
    
    R: @tgroh 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jkff/incubator-beam sdf-updates

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2455.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2455
    
----
commit 77260e65f7bbf8e9e6e8043f4a22848639843ddb
Author: Eugene Kirpichov <ki...@google.com>
Date:   2017-04-06T22:07:05Z

    Fixes SDF issues re: watermarks and stop/resume
    
    See detailed discussion in document:
    https://docs.google.com/document/d/1BGc8pM1GOvZhwR9SARSVte-20XEoBUxrGJ5gTWXdv3c/edit

----


> Splittable DoFn should report watermarks via ProcessContext
> -----------------------------------------------------------
>
>                 Key: BEAM-1903
>                 URL: https://issues.apache.org/jira/browse/BEAM-1903
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Eugene Kirpichov
>            Assignee: Eugene Kirpichov
>
> See design document:
> https://docs.google.com/document/d/1BGc8pM1GOvZhwR9SARSVte-20XEoBUxrGJ5gTWXdv3c/edit



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)