[GitHub] [yunikorn-core] wilfred-s commented on a diff in pull request #573: [YUNIKORN-1802] Add node events

["wilfred-s (via GitHub)" <gi...@apache.org>]

wilfred-s commented on code in PR #573:
URL: https://github.com/apache/yunikorn-core/pull/573#discussion_r1238552626


##########
pkg/scheduler/objects/node.go:
##########
@@ -27,6 +27,7 @@ import (
 	"go.uber.org/zap"

Review Comment:
   Placeholders: no that is just another allocation for the node. Nothing special from that side.
   Reservation: file a follow up jira to look at that. We use a reservation in different ways specially in preemption. We need to think where we report it (app or node) and how we report it.



##########
pkg/events/events.go:
##########
@@ -25,6 +25,8 @@ import (
 	"github.com/apache/yunikorn-scheduler-interface/lib/go/si"
 )
 
+const Empty = ""
+

Review Comment:
   Move to the common package



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org