You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Rohit Deshpande (Jira)" <ji...@apache.org> on 2021/03/01 07:38:00 UTC
[jira] [Commented] (KAFKA-12253) Add tests that cover all of all of
the cases for ReplicatedLog::validateOffsetAndEpoch
[ https://issues.apache.org/jira/browse/KAFKA-12253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17292687#comment-17292687 ]
Rohit Deshpande commented on KAFKA-12253:
-----------------------------------------
[~jagsancio] can I please pick this up? Do you recommend to add new test class for this?
> Add tests that cover all of all of the cases for ReplicatedLog::validateOffsetAndEpoch
> --------------------------------------------------------------------------------------
>
> Key: KAFKA-12253
> URL: https://issues.apache.org/jira/browse/KAFKA-12253
> Project: Kafka
> Issue Type: Sub-task
> Components: replication
> Reporter: Jose Armando Garcia Sancio
> Priority: Major
>
> Add tests for the cases that ReplicatedLog::validateOffsetAndEpoch needs to cover. This include:
>
> # epoch > last known epoch => return diverging(log.endOffset, log.lastFetchedEpoch)
> # epoch < oldest snapshot epoch => return snapshot(latestSnapshotId)
> # epoch == oldest snapshot epoch:
> ## offset < oldest snapshot offset => return snapshot(latestSnapshotId)
> ## offset == oldest snapshot offset => return valid
> # Now look up end offset for epoch:
> ## epoch unknown => return diverging(endOffset/epoch)
> ## found epoch; end offset < offset => return diverging(endOffset/epoch)
> ## valid
--
This message was sent by Atlassian Jira
(v8.3.4#803005)