You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2019/11/12 20:50:50 UTC

[GitHub] [helix] i3wangyi edited a comment on issue #534: Update zkBaseDataAccessor with custom serializer support

i3wangyi edited a comment on issue #534: Update zkBaseDataAccessor with custom serializer support
URL: https://github.com/apache/helix/pull/534#issuecomment-553074501
 
 
   @narendly mvn test founds out some issues (after adding the close method), I've addressed them (very minor). Please take a look. 
   
   The PR is ready to be merged into Master, approved by @narendly 
   
   commit message:
   Update zkBaseDataAccessor with custom serializer support
   - new constructor with an additional custom serializer as the parameter
   - default constructor with ZnRecord Serializer
   - added cross-validated unit tests to verify the custom/default serializer works fine

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org