You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/06/04 09:37:06 UTC

[GitHub] sijie opened a new pull request #1475: Improve precommit CI jobs on handling PRs made to branches

sijie opened a new pull request #1475:  Improve precommit CI jobs on handling PRs made to branches
URL: https://github.com/apache/bookkeeper/pull/1475
 
 
   Descriptions of the changes in this PR:
   
   *Motivation*
   
   Current precommit CI jobs uses `master` as target branch for applying the pull requests.
   However pull requests might be made against branches. e.g. #1469, precommit jobs can't run properly on those pull requests. This PR tends to address the problem. 
   
   *Solution*
   
   Use `ghprbTargetBranch` as the build branch for precommit jobs.
   
   Besides that, split the validation goals (e.g. checkstyle, apache-rat) from build/test goals (package, spotbugs), this reduces build time for different jdk versions and address problem when running checkstyle:check with other goals (e.g. deploy).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services