You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@shiro.apache.org by GitBox <gi...@apache.org> on 2021/01/08 15:27:11 UTC

[GitHub] [shiro] bdemers commented on a change in pull request #273: [SHIRO-290] Implement BCrypt (and possibly other unix crypt formats like scrypt)

bdemers commented on a change in pull request #273:
URL: https://github.com/apache/shiro/pull/273#discussion_r554009848



##########
File path: core/pom.xml
##########
@@ -101,6 +101,14 @@
             <groupId>org.apache.shiro</groupId>
             <artifactId>shiro-crypto-hash</artifactId>
         </dependency>
+        <dependency>
+            <groupId>org.apache.shiro</groupId>
+            <artifactId>shiro-crypto-support-hashes-argon2</artifactId>

Review comment:
       nit: he groupId could be `org.apache.shiro.hashes` and artifactId: `shiro-crypto-argon2`
   Or, `org.apache.shiro.crypto:shiro-hashes-argon2`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org