You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sylvain Lebresne (JIRA)" <ji...@apache.org> on 2014/01/06 17:29:51 UTC

[jira] [Commented] (CASSANDRA-6480) Custom secondary index options in CQL3

    [ https://issues.apache.org/jira/browse/CASSANDRA-6480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13863080#comment-13863080 ] 

Sylvain Lebresne commented on CASSANDRA-6480:
---------------------------------------------

Minor remarks on the validation:
* I'd reject 'class_name' as an option, instead of silently overriding.
* I'd rather let non-custom {{CREATE INDEX}} with options pass the parser but be rejected later. An antlr parse error is a lot more confusing that a clear message telling you that options are not supported for non-custom indexes (I know there is existing places where we do something similar, but there's no reason not to improve our ways :)).

Nit: I'd move the isCustom and customClass fields inside IndexPropDefs.


> Custom secondary index options in CQL3
> --------------------------------------
>
>                 Key: CASSANDRA-6480
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6480
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Andrés de la Peña
>            Assignee: Aleksey Yeschenko
>            Priority: Minor
>              Labels: cql3, index
>             Fix For: 2.0.5
>
>         Attachments: 6480-v2.txt
>
>
> The CQL3 "create index" statement syntax does not allow to specify the options map internally used by custom indexes. 



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)