[GitHub] [flink-table-store] openinx commented on a diff in pull request #117: [FLINK-27543] Hide column statistics collector inside the file format writer.

[GitBox <gi...@apache.org>]

openinx commented on code in PR #117:
URL: https://github.com/apache/flink-table-store/pull/117#discussion_r869045534


##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/data/DataFileWriter.java:
##########
@@ -55,22 +53,19 @@ public class DataFileWriter {
 
     private final RowType keyType;
     private final RowType valueType;
-    private final BulkWriter.Factory<RowData> writerFactory;
-    private final FileStatsExtractor fileStatsExtractor;
+    private final FormatWriter.Factory<RowData> writerFactory;
     private final DataFilePathFactory pathFactory;
     private final long suggestedFileSize;
 
     private DataFileWriter(
             RowType keyType,
             RowType valueType,
-            BulkWriter.Factory<RowData> writerFactory,
-            FileStatsExtractor fileStatsExtractor,
+            FormatWriter.Factory<RowData> writerFactory,

Review Comment:
   All the upper layer `DataFileWriter`, `RollingFileWriter` will just use this `FormatWriter` to write records because this FormatWriter will generate column statistics automatically in their own implementations.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org