You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/21 18:25:04 UTC
[jira] [Commented] (ARTEMIS-1127) AMQP: Match client
SenderSettleMode instead of always defaulting to MIXED
[ https://issues.apache.org/jira/browse/ARTEMIS-1127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15979183#comment-15979183 ]
ASF GitHub Bot commented on ARTEMIS-1127:
-----------------------------------------
GitHub user tabish121 opened a pull request:
https://github.com/apache/activemq-artemis/pull/1221
ARTEMIS-1127 Match remote Sender and Receiver settle modes
On link attach we currently default out SenderSettleMode to MIXED which
while legal doesn't truly reflect what the client asked for. We instead
now update the link to reflect the mode requested by the client
Also add some tests to ensure that we always return the
ReceiverSettleMode as FIRST since we don't support SECOND.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tabish121/activemq-artemis ARTEMIS-1127
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1221.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1221
----
commit 57a189614a98347a9d17df13ec373551dde63729
Author: Timothy Bish <ta...@gmail.com>
Date: 2017-04-21T18:22:09Z
ARTEMIS-1127 Match remote Sender and Receiver settle modes
On link attach we currently default out SenderSettleMode to MIXED which
while legal doesn't truly reflect what the client asked for. We instead
now update the link to reflect the mode requested by the client
Also add some tests to ensure that we always return the
ReceiverSettleMode as FIRST since we don't support SECOND.
----
> AMQP: Match client SenderSettleMode instead of always defaulting to MIXED
> -------------------------------------------------------------------------
>
> Key: ARTEMIS-1127
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1127
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: AMQP
> Affects Versions: 2.0.0
> Reporter: Timothy Bish
> Assignee: Timothy Bish
> Priority: Minor
> Fix For: 2.next
>
>
> On link attach we currently default out SenderSettleMode to MIXED which while legal doesn't truly reflect what the client asked for. We should instead update the link to reflect the mode requested by the client
> Also add some tests to ensure that we always return the ReceiverSettleMode as FIRST since we don't support SECOND.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)