You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Mark Hindess (JIRA)" <ji...@apache.org> on 2006/03/16 10:06:00 UTC
[jira] Created: (HARMONY-202) Non-ascii source file URITest
breaking eclipse compiler test build
Non-ascii source file URITest breaking eclipse compiler test build
------------------------------------------------------------------
Key: HARMONY-202
URL: http://issues.apache.org/jira/browse/HARMONY-202
Project: Harmony
Type: Improvement
Components: Classlib
Reporter: Mark Hindess
Priority: Trivial
I will attach a patch to replace the non-ascii characters with \x escape sequences.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-202) Non-ascii source file URITest
breaking eclipse compiler test build
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-202?page=all ]
Mark Hindess updated HARMONY-202:
---------------------------------
Attachment: replace.non-ascii.with.escape.sequences.diff
The patch also adds the test back to the AllTests source file.
> Non-ascii source file URITest breaking eclipse compiler test build
> ------------------------------------------------------------------
>
> Key: HARMONY-202
> URL: http://issues.apache.org/jira/browse/HARMONY-202
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Mark Hindess
> Priority: Trivial
> Attachments: replace.non-ascii.with.escape.sequences.diff
>
> I will attach a patch to replace the non-ascii characters with \x escape sequences.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-202) Non-ascii source file URITest
breaking eclipse compiler test build
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-202?page=all ]
Tim Ellison reassigned HARMONY-202:
-----------------------------------
Assign To: Tim Ellison
> Non-ascii source file URITest breaking eclipse compiler test build
> ------------------------------------------------------------------
>
> Key: HARMONY-202
> URL: http://issues.apache.org/jira/browse/HARMONY-202
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Mark Hindess
> Assignee: Tim Ellison
> Priority: Trivial
> Attachments: replace.non-ascii.with.escape.sequences.diff
>
> I will attach a patch to replace the non-ascii characters with \x escape sequences.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-202) Non-ascii source file URITest
breaking eclipse compiler test build
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-202?page=all ]
Tim Ellison resolved HARMONY-202:
---------------------------------
Resolution: Fixed
Mark,
The patch contained wierd escape sequences, so fixed it with unicode escape sequences (\u0000).
Fixed in LUNI module tests.api.java.net.URITest and tests.api.java.net.AllTests at repo revision 386319.
Please check that this fully resolves your problem.
> Non-ascii source file URITest breaking eclipse compiler test build
> ------------------------------------------------------------------
>
> Key: HARMONY-202
> URL: http://issues.apache.org/jira/browse/HARMONY-202
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Mark Hindess
> Assignee: Tim Ellison
> Priority: Trivial
> Attachments: replace.non-ascii.with.escape.sequences.diff
>
> I will attach a patch to replace the non-ascii characters with \x escape sequences.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Commented: (HARMONY-202) Non-ascii source file URITest
breaking eclipse compiler test build
Posted by Richard Liang <ri...@gmail.com>.
Tim Ellison wrote:
> Richard Liang wrote:
> <snip>
>
>> Do we have any mandatory requirement about Harmony source file encoding?
>> or only US-ASCII is allowed. If yes, we shall document this requirement.
>> Any comments?
>>
>
> In this case the Eclipse compiler running on the build machine failed to
> parse a particular source file encoding. We could fix it using the
> "-encoding <name>" argument, but it would be good for all our source
> files to be generally readable by simple text editors, etc.
>
> I would think the safest option is to use ASCII (and escape other
> characters).
>
>
I will agree with Tim. So we will set Window -> Preferences -> General
-> Workspace -> Text file encoding as US-ASCII.
> Regards,
> Tim
>
>
--
Richard Liang
China Software Development Lab, IBM
Re: [jira] Commented: (HARMONY-202) Non-ascii source file URITest
breaking eclipse compiler test build
Posted by Tim Ellison <t....@gmail.com>.
Richard Liang wrote:
<snip>
> Do we have any mandatory requirement about Harmony source file encoding?
> or only US-ASCII is allowed. If yes, we shall document this requirement.
> Any comments?
In this case the Eclipse compiler running on the build machine failed to
parse a particular source file encoding. We could fix it using the
"-encoding <name>" argument, but it would be good for all our source
files to be generally readable by simple text editors, etc.
I would think the safest option is to use ASCII (and escape other
characters).
Regards,
Tim
--
Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.
Re: [jira] Commented: (HARMONY-202) Non-ascii source file URITest
breaking eclipse compiler test build
Posted by Richard Liang <ri...@gmail.com>.
Mark Hindess (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/HARMONY-202?page=comments#action_12370684 ]
>
> Mark Hindess commented on HARMONY-202:
> --------------------------------------
>
> Looks good. All tests pass for me now. Thanks.
>
>
>
>
>> Non-ascii source file URITest breaking eclipse compiler test build
>> ------------------------------------------------------------------
>>
>> Key: HARMONY-202
>> URL: http://issues.apache.org/jira/browse/HARMONY-202
>> Project: Harmony
>> Type: Improvement
>> Components: Classlib
>> Reporter: Mark Hindess
>> Assignee: Tim Ellison
>> Priority: Trivial
>> Attachments: replace.non-ascii.with.escape.sequences.diff
>>
>> I will attach a patch to replace the non-ascii characters with \x escape sequences.
>>
>
>
Hello Tim & Mark,
Do we have any mandatory requirement about Harmony source file encoding?
or only US-ASCII is allowed. If yes, we shall document this requirement.
Any comments?
Thanks a lot.
--
Richard Liang
China Software Development Lab, IBM
[jira] Commented: (HARMONY-202) Non-ascii source file URITest
breaking eclipse compiler test build
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-202?page=comments#action_12370684 ]
Mark Hindess commented on HARMONY-202:
--------------------------------------
Looks good. All tests pass for me now. Thanks.
> Non-ascii source file URITest breaking eclipse compiler test build
> ------------------------------------------------------------------
>
> Key: HARMONY-202
> URL: http://issues.apache.org/jira/browse/HARMONY-202
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Mark Hindess
> Assignee: Tim Ellison
> Priority: Trivial
> Attachments: replace.non-ascii.with.escape.sequences.diff
>
> I will attach a patch to replace the non-ascii characters with \x escape sequences.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-202) Non-ascii source file URITest breaking
eclipse compiler test build
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-202?page=all ]
Tim Ellison closed HARMONY-202:
-------------------------------
Verified by Mark
> Non-ascii source file URITest breaking eclipse compiler test build
> ------------------------------------------------------------------
>
> Key: HARMONY-202
> URL: http://issues.apache.org/jira/browse/HARMONY-202
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Mark Hindess
> Assignee: Tim Ellison
> Priority: Trivial
> Attachments: replace.non-ascii.with.escape.sequences.diff
>
> I will attach a patch to replace the non-ascii characters with \x escape sequences.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira