You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/21 10:07:01 UTC

[GitHub] [flink] twalthr opened a new pull request #14714: [FLINK-21050][examples-table] Add some advanced function examples

twalthr opened a new pull request #14714:
URL: https://github.com/apache/flink/pull/14714


   ## What is the purpose of the change
   
   ```
   /**
    * Example for implementing more complex {@link UserDefinedFunction}s.
    *
    * <p>In many use cases, function signatures can be reflectively extracted from a UDF class. The
    * annotations {@link DataTypeHint} and {@link FunctionHint} help if reflective information is not
    * enough and needs to be enriched with further logical details. Check the website documentation as
    * well as the docs of {@link ScalarFunction}, {@link TableFunction}, and {@link AggregateFunction}
    * for more information.
    *
    * <p>Both reflective extraction and annotations are suitable for function signatures with fixed
    * input and output types. However, for advanced use cases it might be required to derive an output
    * type from one of the argument types or perform stricter validation.
    *
    * <p>This example demonstrates various UDF implementations. We are executing multiple Flink jobs
    * where the result is written to stdout.
    */
   ```
   
   ## Brief change log
   
   - `LastDatedValueFunction` aggregate function added
   - `InternalRowMergerFunction` function added
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:  `AdvancedFunctionsExampleITCase`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? JavaDocs
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14714: [FLINK-21050][examples-table] Add some advanced function examples

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #14714:
URL: https://github.com/apache/flink/pull/14714#issuecomment-764548835






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14714: [FLINK-21050][examples-table] Add some advanced function examples

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #14714:
URL: https://github.com/apache/flink/pull/14714#issuecomment-764548835


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "eeefce1e58c46972900cffc6d16eaeb2b18bd83a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "eeefce1e58c46972900cffc6d16eaeb2b18bd83a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * eeefce1e58c46972900cffc6d16eaeb2b18bd83a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] twalthr commented on pull request #14714: [FLINK-21050][examples-table] Add some advanced function examples

Posted by GitBox <gi...@apache.org>.

twalthr commented on pull request #14714:
URL: https://github.com/apache/flink/pull/14714#issuecomment-765637047


   Thanks for the review @sjwiesman. I agree general UDF blog post would be nice. Better examples are just the beginning ;)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14714: [FLINK-21050][examples-table] Add some advanced function examples

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #14714:
URL: https://github.com/apache/flink/pull/14714#issuecomment-764548835


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "eeefce1e58c46972900cffc6d16eaeb2b18bd83a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12325",
       "triggerID" : "eeefce1e58c46972900cffc6d16eaeb2b18bd83a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * eeefce1e58c46972900cffc6d16eaeb2b18bd83a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12325) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] sjwiesman commented on a change in pull request #14714: [FLINK-21050][examples-table] Add some advanced function examples

Posted by GitBox <gi...@apache.org>.

sjwiesman commented on a change in pull request #14714:
URL: https://github.com/apache/flink/pull/14714#discussion_r562686148



##########
File path: docs/dev/table/functions/udfs.md
##########
@@ -551,6 +551,9 @@ public static class LiteralFunction extends ScalarFunction {
 
 </div>
 
+For more examples of custom type inference, see also the `flink-examples-table` module with [advanced
+function implementations](https://github.com/apache/flink/tree/master/flink-examples/flink-examples-table/src/main/java/org/apache/flink/table/examples/java/functions).

Review comment:
       ```suggestion
   function implementations]({% gh_link /flink-examples/flink-examples-table/src/main/java/org/apache/flink/table/examples/java/functions %}).
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14714: [FLINK-21050][examples-table] Add some advanced function examples

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #14714:
URL: https://github.com/apache/flink/pull/14714#issuecomment-764526169

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit eeefce1e58c46972900cffc6d16eaeb2b18bd83a (Fri May 28 07:12:40 UTC 2021)

**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.

Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:

- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14714: [FLINK-21050][examples-table] Add some advanced function examples

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #14714:
URL: https://github.com/apache/flink/pull/14714#issuecomment-764548835


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "eeefce1e58c46972900cffc6d16eaeb2b18bd83a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12325",
       "triggerID" : "eeefce1e58c46972900cffc6d16eaeb2b18bd83a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * eeefce1e58c46972900cffc6d16eaeb2b18bd83a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12325) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14714: [FLINK-21050][examples-table] Add some advanced function examples

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #14714:
URL: https://github.com/apache/flink/pull/14714#issuecomment-764526169






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14714: [FLINK-21050][examples-table] Add some advanced function examples

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #14714:
URL: https://github.com/apache/flink/pull/14714#issuecomment-764526169

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit eeefce1e58c46972900cffc6d16eaeb2b18bd83a (Thu Jan 21 10:08:51 UTC 2021)

**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* Documentation files were touched, but no `.zh.md` files: Update Chinese documentation or file Jira ticket.

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] twalthr closed pull request #14714: [FLINK-21050][examples-table] Add some advanced function examples

Posted by GitBox <gi...@apache.org>.

twalthr closed pull request #14714:
URL: https://github.com/apache/flink/pull/14714


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org