You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "cserwen (via GitHub)" <gi...@apache.org> on 2023/06/08 02:28:50 UTC
[GitHub] [rocketmq-exporter] cserwen opened a new pull request, #141: Revert "metrics bugfix: switch getTps() to getSum()"
cserwen opened a new pull request, #141:
URL: https://github.com/apache/rocketmq-exporter/pull/141
This reverts commit 767612c1958ba8cbb29cfb734132878b71e9185b.
## What is the purpose of the change
rever #108
fix #128、#123、#123、#114
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert "metrics bugfix: switch getTps() to getSum()" [rocketmq-exporter]
Posted by "cserwen (via GitHub)" <gi...@apache.org>.
cserwen commented on PR #141:
URL: https://github.com/apache/rocketmq-exporter/pull/141#issuecomment-1871897708
> What is the reason for changing to sum before? Is it necessary?
最早的版本就是 TPS，使用的getTps()，https://github.com/apache/rocketmq-exporter/pull/108 改成了 getSum，理论上应该增加个指标叫 tpm，而不是在原本的基础上改 @ferrirW
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert "metrics bugfix: switch getTps() to getSum()" [rocketmq-exporter]
Posted by "cserwen (via GitHub)" <gi...@apache.org>.
cserwen merged PR #141:
URL: https://github.com/apache/rocketmq-exporter/pull/141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert "metrics bugfix: switch getTps() to getSum()" [rocketmq-exporter]
Posted by "ferrirW (via GitHub)" <gi...@apache.org>.
ferrirW commented on PR #141:
URL: https://github.com/apache/rocketmq-exporter/pull/141#issuecomment-1870796609
What is the reason for changing to sum before? Is it necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org