[GitHub] [cassandra] yifan-c commented on a change in pull request #748: CASSANDRA-16120 - Add ability for jvm-dtest to grep instance logs

[GitBox <gi...@apache.org>]

yifan-c commented on a change in pull request #748:
URL: https://github.com/apache/cassandra/pull/748#discussion_r486541315



##########
File path: test/distributed/org/apache/cassandra/distributed/impl/Instance.java
##########
@@ -339,6 +359,12 @@ public void forceCompact(String keyspace, String table)
         });
     }
 
+    @Override
+    public List<Throwable> getUncaughtExceptions()

Review comment:
       FYI, there is an unmerged commit https://github.com/krummas/cassandra/commit/7cec7bd563fac3089e45fec89ac3f493683f0a85 that implements the new interface. (whoever merges later needs to do a rebase)

##########
File path: test/conf/logback-dtest.xml
##########
@@ -70,7 +53,7 @@
   <logger name="org.apache.hadoop" level="WARN"/>
 
   <root level="DEBUG">
-    <appender-ref ref="INSTANCEASYNCFILE" />
+    <appender-ref ref="INSTANCEFILE" /> <!-- use blocking to avoid race conditions with appending and searching -->

Review comment:
       👍  
   Make sense. The log volume should be small from a jvm dtest. Async is not necessary. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org