You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by keypointt <gi...@git.apache.org> on 2016/07/14 03:57:13 UTC
[GitHub] spark pull request #14193: [Minor][Build] Remove empty tags in parent pom.xm...
GitHub user keypointt opened a pull request:
https://github.com/apache/spark/pull/14193
[Minor][Build] Remove empty tags in parent pom.xml
## What changes were proposed in this pull request?
Remove empty tags in parent pom.xml
When I was working on another ticket and scanning code files randomly, I found these empty tags. I'm not sure if it is needed, or these empty tags are left on purpose.
If this is not a valid PR, please just let me know and I'll close it.
## How was this patch tested?
Tested by re-building the project on my local machine.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/keypointt/spark emptyTag
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/14193.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14193
----
commit 534f8c677244fe09a25b103bc0bb8ae3de059f7e
Author: Xin Ren <ia...@126.com>
Date: 2016-07-14T03:52:31Z
remove emtpy tags in parent pom.xml
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14193: [Minor][Build] Remove empty tags in parent pom.xml
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14193
No, I don't think any of these can be removed. Why would you assume an empty tag is meaningless? that's not true in any XML format.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14193: [Minor][Build] Remove empty tags in parent pom.xml
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14193
**[Test build #62294 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62294/consoleFull)** for PR 14193 at commit [`534f8c6`](https://github.com/apache/spark/commit/534f8c677244fe09a25b103bc0bb8ae3de059f7e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14193: [Minor][Build] Remove empty tags in parent pom.xml
Posted by keypointt <gi...@git.apache.org>.
Github user keypointt commented on the issue:
https://github.com/apache/spark/pull/14193
I get it now, thank you Sean for explaining this \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14193: [Minor][Build] Remove empty tags in parent pom.xml
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14193
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14193: [Minor][Build] Remove empty tags in parent pom.xml
Posted by keypointt <gi...@git.apache.org>.
Github user keypointt commented on the issue:
https://github.com/apache/spark/pull/14193
Hi Sean do you mind to explain a bit the meaning of the empty tags?
Is it mean these empty paras can be set via command line like `mvn compile -paraA -paraB`?
I googled around and didn't find a satisfying answer. Thanks a lot
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14193: [Minor][Build] Remove empty tags in parent pom.xml
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14193
The first one sets a property with an empty value. I think this is necessary to refer to it in the Maven build even if it doesn't have a default value. The rest -- refer to the plugin docs for that they mean. Empty tags are perfectly meaningful in XML.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14193: [Minor][Build] Remove empty tags in parent pom.xml
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14193
**[Test build #62294 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62294/consoleFull)** for PR 14193 at commit [`534f8c6`](https://github.com/apache/spark/commit/534f8c677244fe09a25b103bc0bb8ae3de059f7e).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14193: [Minor][Build] Remove empty tags in parent pom.xml
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14193
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62294/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14193: [Minor][Build] Remove empty tags in parent pom.xm...
Posted by keypointt <gi...@git.apache.org>.
Github user keypointt closed the pull request at:
https://github.com/apache/spark/pull/14193
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org