You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/21 14:06:47 UTC

[GitHub] [airflow] potiuk opened a new pull request #7485: [AIRFLOW-6866] Fix wrong export for Mac on Breeze

potiuk opened a new pull request #7485: [AIRFLOW-6866] Fix wrong export for Mac on Breeze
URL: https://github.com/apache/airflow/pull/7485
 
 
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on a change in pull request #7485: [AIRFLOW-6866] Fix wrong export for Mac on Breeze

Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7485: [AIRFLOW-6866] Fix wrong export for Mac on Breeze
URL: https://github.com/apache/airflow/pull/7485#discussion_r382670110
 
 

 ##########
 File path: breeze
 ##########
 @@ -629,7 +629,7 @@ function parse_arguments() {
         -k|--stop-environment)
           COMMAND_TO_RUN="run_docker_compose"
           DOCKER_COMPOSE_COMMAND="down"
-          export EXTRA_DC_OPTIONS+=("--remove-orphans")
 
 Review comment:
   in bash 3 export can only work with assignment not with +=.. It considers + as part of variable name in this case....
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil merged pull request #7485: [AIRFLOW-6866] Fix wrong export for Mac on Breeze

Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #7485: [AIRFLOW-6866] Fix wrong export for Mac on Breeze
URL: https://github.com/apache/airflow/pull/7485
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on a change in pull request #7485: [AIRFLOW-6866] Fix wrong export for Mac on Breeze

Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7485: [AIRFLOW-6866] Fix wrong export for Mac on Breeze
URL: https://github.com/apache/airflow/pull/7485#discussion_r382669653
 
 

 ##########
 File path: breeze
 ##########
 @@ -629,7 +629,7 @@ function parse_arguments() {
         -k|--stop-environment)
           COMMAND_TO_RUN="run_docker_compose"
           DOCKER_COMPOSE_COMMAND="down"
-          export EXTRA_DC_OPTIONS+=("--remove-orphans")
 
 Review comment:
   Not by default. MacOS comes with bundled 3.* series of bash (the current version is 5.*) due to bash moving from GPL2 to GPL3. Now they switched to zsh in catalina as default shell but default bash remains 3.* . it has a number of missing new syntax from modern bash :(

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] nuclearpinguin commented on issue #7485: [AIRFLOW-6866] Fix wrong export for Mac on Breeze

Posted by GitBox <gi...@apache.org>.
nuclearpinguin commented on issue #7485: [AIRFLOW-6866] Fix wrong export for Mac on Breeze
URL: https://github.com/apache/airflow/pull/7485#issuecomment-589677410
 
 
   Checked, works like a charm :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on a change in pull request #7485: [AIRFLOW-6866] Fix wrong export for Mac on Breeze

Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7485: [AIRFLOW-6866] Fix wrong export for Mac on Breeze
URL: https://github.com/apache/airflow/pull/7485#discussion_r382652974
 
 

 ##########
 File path: breeze
 ##########
 @@ -629,7 +629,7 @@ function parse_arguments() {
         -k|--stop-environment)
           COMMAND_TO_RUN="run_docker_compose"
           DOCKER_COMPOSE_COMMAND="down"
-          export EXTRA_DC_OPTIONS+=("--remove-orphans")
 
 Review comment:
   shouldn't it work for Mac too ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services