You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "shubhamvishu (via GitHub)" <gi...@apache.org> on 2023/11/10 18:02:49 UTC

[PR] Minor change to IndexOrDocValuesQuery#toString [lucene]

shubhamvishu opened a new pull request, #12791:
URL: https://github.com/apache/lucene/pull/12791

   ### Description
   
   Adds doc value query to the `IndexOrDocValuesQuery#toString`
   <!--
   If this is your first contribution to Lucene, please make sure you have reviewed the contribution guide.
   https://github.com/apache/lucene/blob/main/CONTRIBUTING.md
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

Re: [PR] Minor change to IndexOrDocValuesQuery#toString [lucene]

Posted by "shubhamvishu (via GitHub)" <gi...@apache.org>.
shubhamvishu commented on PR #12791:
URL: https://github.com/apache/lucene/pull/12791#issuecomment-1814515539

   > I assume this is because this is a DoubleDocValuesField which encodes the double using NumericUtils.doubleToSortableLong
   
   @mikemccand Is it possible to fix `NumericUtils.doubleToSortableLong` somehow in a way that its fully invertible?
   
   &nbsp;
   >  it's another datapoint showing that apps should not assume if you run any Query.toString through your favorite QueryParser that you'll get your query back: the process it not guaranteed to be fully invertible, but sometimes it is.
   
   Nice....I didn't knew this before!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

Re: [PR] Minor change to IndexOrDocValuesQuery#toString [lucene]

Posted by "mikemccand (via GitHub)" <gi...@apache.org>.
mikemccand merged PR #12791:
URL: https://github.com/apache/lucene/pull/12791


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

Re: [PR] Minor change to IndexOrDocValuesQuery#toString [lucene]

Posted by "mikemccand (via GitHub)" <gi...@apache.org>.
mikemccand commented on PR #12791:
URL: https://github.com/apache/lucene/pull/12791#issuecomment-1812469386

   Nightly sparse (NYC taxis) benchy was a bit unhappy with this change because it (weirdly) relies on `Query.toString` (I tried to fix the benchy [here](https://github.com/mikemccand/luceneutil/commit/b9b4bcbc6d4b04a78be38ee13ca888777304539c)), but what was interesting is how heinous the `dvQuery` part of the query becomes:
   
   ```
      IndexOrDocValuesQuery(indexQuery=pickup_latitude:[40.75 TO 40.9], dvQuery=pickup_latitude:[4630931869959979008 TO 4630952980583232307])
   ```
   
   I assume this is because this is a `DoubleDocValuesField` which encodes the double using `NumericUtils.doubleToSortableLong`.  I don't think there's much we can do (Lucene doesn't have the knowledge that this `long` doc values field is "really" a double), and it's another datapoint showing that apps should not assume if you run any `Query.toString` through your favorite `QueryParser` that you'll get your query back: the process it not guaranteed to be fully invertible, but sometimes it is.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org