You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/07/21 11:45:36 UTC

[GitHub] [hive] kasakrisz opened a new pull request #1287: HIVE-23888: Simplify special_character_in_tabnames_1.q

kasakrisz opened a new pull request #1287:
URL: https://github.com/apache/hive/pull/1287


   Testing done:
   ```
   mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestMiniLlapLocalCliDriver -Dqfile=special_character_in_tabnames_quotes_1.q,special_character_in_tabnames_1.q -pl itests/qtest -Pitests
   ```
   
   http://ci.hive.apache.org/job/hive-flaky-check/76/
   http://ci.hive.apache.org/job/hive-flaky-check/77/


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] jcamachor edited a comment on pull request #1287: HIVE-23888: Simplify special_character_in_tabnames_1.q

Posted by GitBox <gi...@apache.org>.
jcamachor edited a comment on pull request #1287:
URL: https://github.com/apache/hive/pull/1287#issuecomment-662120690


   Just a nit. End-to-end testing could still be useful in some cases to make sure that we are reading the data correctly with special characters in the table/column names. But could definitely be simpler than what we had. Maybe we can add a few simple examples in a quick follow-up.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] jcamachor merged pull request #1287: HIVE-23888: Simplify special_character_in_tabnames_1.q

Posted by GitBox <gi...@apache.org>.
jcamachor merged pull request #1287:
URL: https://github.com/apache/hive/pull/1287


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] jcamachor commented on pull request #1287: HIVE-23888: Simplify special_character_in_tabnames_1.q

Posted by GitBox <gi...@apache.org>.
jcamachor commented on pull request #1287:
URL: https://github.com/apache/hive/pull/1287#issuecomment-662120690


   Just a nit. End-to-end testing could still be useful in some cases to make sure that we are reading the data correctly with special characters in the table/column names. But could definitely be simpler than what we had.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org