[jira] [Updated] (LUCENE-6240) ban @Seed in tests.

["Robert Muir (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LUCENE-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-6240:
--------------------------------
    Attachment: LUCENE-6240.patch

Patch. You can still use this annotation when debugging, but just don't commit it.

precommit / jenkins will fail like this:
{noformat}
[forbidden-apis] Forbidden class/interface/annotation use: com.carrotsearch.randomizedtesting.annotations.Seed [Don't commit hardcoded seeds]
[forbidden-apis]   in org.apache.lucene.TestDemo (TestDemo.java, annotation on class declaration)
[forbidden-apis] Scanned 1118 (and 910 related) class file(s) for forbidden API invocations (in 0.42s), 1 error(s).

BUILD FAILED
{noformat}

> ban @Seed in tests.
> -------------------
>
>                 Key: LUCENE-6240
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6240
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-6240.patch
>
>
> If someone is debugging, they can easily accidentally commit \@Seed annotation, hurting the quality of the test. We should detect this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org