[GitHub] [superset] villebro commented on a change in pull request #19156: test: fix TimezoneSelector tests on daylight saving time

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #19156:
URL: https://github.com/apache/superset/pull/19156#discussion_r828463828



##########
File path: superset-frontend/src/components/TimezoneSelector/TimezoneSelector.test.tsx
##########
@@ -55,49 +77,65 @@ it('use the default timezone when an invalid timezone is provided', async () =>
   expect(onTimezoneChange).toHaveBeenLastCalledWith('Africa/Abidjan');
 });
 
-it.skip('can select a timezone values and returns canonical value', async () => {
+test('render timezones in correct oder for standard time', async () => {

Review comment:
       nit (if you happen to need to push more changes):
   ```suggestion
   test('render timezones in correct order for standard time', async () => {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org