You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/29 13:32:30 UTC

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5901: power: unify lock sates and move pm_auto_update to outer dir

pkarashchenko commented on a change in pull request #5901:
URL: https://github.com/apache/incubator-nuttx/pull/5901#discussion_r837480266



##########
File path: drivers/power/pm_register.c
##########
@@ -56,20 +56,24 @@
 
 int pm_register(FAR struct pm_callback_s *callbacks)
 {
-  int ret;
-
   DEBUGASSERT(callbacks);
 
   /* Add the new entry to the end of the list of registered callbacks */
 
-  ret = pm_lock();
-  if (ret == OK)
+  if (OSINIT_OS_READY())

Review comment:
       I think this completely contradicts to https://github.com/apache/incubator-nuttx/pull/5849
   @GUIDINGLI could you please review this change?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org