You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by robpaveza <gi...@git.apache.org> on 2015/06/26 00:15:21 UTC
[GitHub] cordova-windows pull request: CB-9252: Migrate WinJS to an NPM dep...
GitHub user robpaveza opened a pull request:
https://github.com/apache/cordova-windows/pull/93
CB-9252: Migrate WinJS to an NPM dependency
This change puts the current WinJS NPM package into the node_modules
directory as well as package.json (for "npm install" support). It then
modifies the create step to copy WinJS into the platform template
directory.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-windows CB-9252
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/93.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #93
----
commit 7d43388990f57500d4ef929e9f2006dcdd602065
Author: Rob Paveza <ro...@microsoft.com>
Date: 2015-06-25T22:13:22Z
CB-9252: Migrate WinJS to an NPM dependency
This change puts the current WinJS NPM package into the node_modules
directory as well as package.json (for "npm install" support). It then
modifies the create step to copy WinJS into the platform template
directory.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9252: Migrate WinJS to an NPM dep...
Posted by TimBarham <gi...@git.apache.org>.
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/93#discussion_r33372216
--- Diff: bin/lib/create.js ---
@@ -98,6 +106,16 @@ module.exports.run = function (argv) {
return Q.resolve();
};
+function recursiveCreateDirectory(targetPath) {
+ var parent = path.join(targetPath, '..');
+ if (!fs.existsSync(parent)) {
+ recursiveCreateDirectory(parent);
+ }
+
+ console.log('Creating directory "' + targetPath + '"');
--- End diff --
Heh... Do we really want to be notified about each directory we're creating in the path? If we need any notification, I'd prefer just a single one (so at the call point rather than here).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9252: Migrate WinJS to an NPM dep...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/93
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org