You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2017/01/06 01:48:41 UTC
[GitHub] zeppelin pull request #1852: [ZEPPELIN-1910] fix: Multiple dialog when don't...
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/1852
[ZEPPELIN-1910] fix: Multiple dialog when don't have permission for run all para
### What is this PR for?
See multiple same dialog when user doesn't have permission for **Run all paragraphs** inside a note
#### Implementation details
- Introduce new websocket message `RUN_ALL_PARAGRAPHS` since we need to broadcast *bringing dialog* message only once
- Refactor `NotebookServer.runParagraph` to avoid duplication
- Add necessary functions to backend and frontend
### What type of PR is it?
[Bug Fix]
### Todos
Fixed at once
### What is the Jira issue?
[ZEPPELIN-1910](https://issues.apache.org/jira/browse/ZEPPELIN-1910)
### How should this be tested?
1. Set permission to a note
2. Enable shiro and login as an user **who doens't have write permission**
3. Click *Run all paragraphs* button
### Screenshots (if appropriate)
#### 1. Before
#### 2. After
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-1910/run-all-para-bring-multi-dialog
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1852.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1852
----
commit 02f325d18581e1d0bf129306b8dfb10408881706
Author: 1ambda <1a...@gmail.com>
Date: 2017-01-06T01:41:22Z
fix: Multiple dialog when don't have permission for run all para
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1852: [ZEPPELIN-1910] DON'T show the same dialogs mul...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1852
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1852: [ZEPPELIN-1910] DON'T show the same dialogs multiple t...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1852
Thanks @1ambda for the fix.
LGTM and merge if no more comments!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---