You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/05/18 12:53:42 UTC

[GitHub] [james-project] chibenwa commented on a change in pull request #291: JAMES-3500 Fasten tests with reuseForks

chibenwa commented on a change in pull request #291:
URL: https://github.com/apache/james-project/pull/291#discussion_r634347878



##########
File path: backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/DockerCassandra.java
##########
@@ -115,6 +116,18 @@ private void grantPermissionToTestingUser(Cluster privilegedCluster, String keys
         DockerfileBuilder applyStep(DockerfileBuilder builder);
     }
 
+    /**
+     * @return a string to append to image names in order to avoid conflict with concurrent builds
+     */

Review comment:
       I noticed the same. Maybe we should have an env variable dedicated to turn on that "unique C* docker image" on the CI.
   
   What would you think about it @jeantil ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org