You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by ni...@apache.org on 2020/02/26 07:16:57 UTC

[kylin] branch master updated: KYLIN-4384 Disable create table via spark by default

This is an automated email from the ASF dual-hosted git repository.

nic pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kylin.git


The following commit(s) were added to refs/heads/master by this push:
     new f22ee4d  KYLIN-4384 Disable create table via spark by default
f22ee4d is described below

commit f22ee4d361e562edb4c3db846b067804cd337428
Author: XiaoxiangYu <hi...@126.com>
AuthorDate: Sat Feb 22 21:11:15 2020 +0800

    KYLIN-4384 Disable create table via spark by default
---
 .../src/main/java/org/apache/kylin/common/KylinConfigBase.java    | 4 ++++
 .../src/main/java/org/apache/kylin/source/hive/HiveInputBase.java | 8 ++++++--
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java b/core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
index db82443..7d5cda8 100644
--- a/core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
+++ b/core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
@@ -1583,6 +1583,10 @@ public abstract class KylinConfigBase implements Serializable {
         return Boolean.parseBoolean(getOptional("kylin.engine.flink.sanity-check-enabled", FALSE));
     }
 
+    public boolean isSparCreateHiveTableViaSparkEnable() {
+        return Boolean.parseBoolean(getOptional("kylin.engine.spark-create-table-enabled", "false"));
+    }
+
     // ============================================================================
     // ENGINE.LIVY
     // ============================================================================
diff --git a/source-hive/src/main/java/org/apache/kylin/source/hive/HiveInputBase.java b/source-hive/src/main/java/org/apache/kylin/source/hive/HiveInputBase.java
index 881c8d5..de7319e 100644
--- a/source-hive/src/main/java/org/apache/kylin/source/hive/HiveInputBase.java
+++ b/source-hive/src/main/java/org/apache/kylin/source/hive/HiveInputBase.java
@@ -265,8 +265,12 @@ public class HiveInputBase {
                     jobFlow.addTask(createFlatHiveTableByLivyStep(hiveInitStatements,
                             jobWorkingDir, cubeName, flatDesc));
                 } else {
-                    jobFlow.addTask(createFlatHiveTableBySparkSql(hiveInitStatements,
-                            jobWorkingDir, cubeName, flatDesc));
+                    if (kylinConfig.isSparCreateHiveTableViaSparkEnable()) {
+                        jobFlow.addTask(createFlatHiveTableBySparkSql(hiveInitStatements,
+                                jobWorkingDir, cubeName, flatDesc));
+                    } else {
+                        jobFlow.addTask(createFlatHiveTableStep(hiveInitStatements, jobWorkingDir, cubeName, flatDesc));
+                    }
                 }
             } else {
                 jobFlow.addTask(createFlatHiveTableStep(hiveInitStatements, jobWorkingDir, cubeName, flatDesc));