[GitHub] [airflow] uranusjr commented on a diff in pull request #28697: Allow to specify `pip` version via github URL in Docker/CI workflow

[GitBox <gi...@apache.org>]

uranusjr commented on code in PR #28697:
URL: https://github.com/apache/airflow/pull/28697#discussion_r1061641932


##########
Dockerfile:
##########
@@ -445,6 +436,18 @@ function common::show_pip_version_and_location() {
    echo "pip on path: $(which pip)"
    echo "Using pip: $(pip --version)"
 }
+
+function common::install_pip_version() {
+    echo
+    echo "${COLOR_BLUE}Installing pip version ${AIRFLOW_PIP_VERSION}${COLOR_RESET}"
+    echo
+    if [[ ${AIRFLOW_PIP_VERSION} =~ .*https.* ]]; then
+        pip install --disable-pip-version-check --no-cache-dir ${AIRFLOW_PIP_VERSION}

Review Comment:
   ```suggestion
           pip install --disable-pip-version-check --no-cache-dir "pip @ ${AIRFLOW_PIP_VERSION}"
   ```
   
   Slightly more error-proof.
   
   Otherwise looks fine to me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org