[jira] [Commented] (OOZIE-1828) Introduce counters JobStatus terminal states metrics

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-1828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014913#comment-14014913 ] 

Hadoop QA commented on OOZIE-1828:
----------------------------------

Testing JIRA OOZIE-1828

Cleaning local git workspace

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 132
.    {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.    {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
.    {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.    Tests run: 1459
.    Tests failed: 2
.    Tests errors: 1

.    The patch failed the following testcases:

.      testConcurrencyReachedAndChooseNextEligible(org.apache.oozie.service.TestCallableQueueService)
.      testActionInputCheckLatestActionCreationTime(org.apache.oozie.command.coord.TestCoordActionInputCheckXCommandNonUTC)

{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/1283/

> Introduce counters JobStatus terminal states metrics
> ----------------------------------------------------
>
>                 Key: OOZIE-1828
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1828
>             Project: Oozie
>          Issue Type: Bug
>          Components: monitoring
>    Affects Versions: 4.0.0
>            Reporter: Gilad Wolff
>            Assignee: Robert Kanter
>         Attachments: OOZIE-1828.patch, OOZIE-1828.patch, OOZIE-1828.patch
>
>
> Currently the Oozie server exposes job status metrics from the 'variables' group. These include metrics for jobs in terminal states: 'SUCCEEDED', 'FAILED', 'KILLED'. The way Oozie compute the metrics is by querying the database for all jobs in each and every state. This means that when a purge happens these "apparent" counters' values are going to change (if anything was purged). This renders these counters as not very useful.
> It would be better if real counters for jobs in terminal states can be exposed from the oozie server. One way to do this would be to initialize an in-memory counters and a timestamp count the jobs that finished between the timestamp and 'now' (and keep updating timestamp to avoid it falling out of the retention period). This means that each Oozie server may have its own counter but that is okay as the count itself is not very important what is important is the rate-of-change.



--
This message was sent by Atlassian JIRA
(v6.2#6252)