You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by hmcc <gi...@git.apache.org> on 2017/09/12 10:45:59 UTC
[GitHub] storm pull request #2323: STORM-2736: fix o.a.s.b.BlobStoreUtils [ERROR] "Co...
GitHub user hmcc opened a pull request:
https://github.com/apache/storm/pull/2323
STORM-2736: fix o.a.s.b.BlobStoreUtils [ERROR] "Could not update the blob with key"
`master` version of https://github.com/apache/storm/pull/2320, connected to https://issues.apache.org/jira/browse/STORM-2736.
Check for empty nimbus info list before attempting to update the blobstore.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hmcc/storm STORM-2736-master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2323.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2323
----
commit 1000434b3d8b198e91819759d2004363466d967b
Author: Heather McCartney <he...@idioplatform.com>
Date: 2017-09-12T09:43:48Z
Check for empty nimbus info list before attempting to update the blobstore.
----
---
[GitHub] storm issue #2323: STORM-2736: fix o.a.s.b.BlobStoreUtils [ERROR] "Could not...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2323
+1
---
[GitHub] storm issue #2323: STORM-2736: fix o.a.s.b.BlobStoreUtils [ERROR] "Could not...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2323
We now need to wait for the required 24 hours from when the pull request went up to give others time to review if they want to.
---
[GitHub] storm pull request #2323: STORM-2736: fix o.a.s.b.BlobStoreUtils [ERROR] "Co...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2323
---
[GitHub] storm pull request #2323: STORM-2736: fix o.a.s.b.BlobStoreUtils [ERROR] "Co...
Posted by hmcc <gi...@git.apache.org>.
Github user hmcc commented on a diff in the pull request:
https://github.com/apache/storm/pull/2323#discussion_r138312797
--- Diff: storm-server/src/main/java/org/apache/storm/blobstore/BlobStoreUtils.java ---
@@ -17,6 +17,18 @@
*/
package org.apache.storm.blobstore;
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.HashSet;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+
+import javax.security.auth.Subject;
+
+import org.apache.commons.collections.CollectionUtils;
+import org.apache.curator.framework.CuratorFramework;
--- End diff --
I re-ordered these because adding `import org.apache.commons.collections.CollectionUtils` nudged us over the checkstyle violations threshold.
---
[GitHub] storm issue #2323: STORM-2736: fix o.a.s.b.BlobStoreUtils [ERROR] "Could not...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2323
Still +1
---
[GitHub] storm issue #2323: STORM-2736: fix o.a.s.b.BlobStoreUtils [ERROR] "Could not...
Posted by hmcc <gi...@git.apache.org>.
Github user hmcc commented on the issue:
https://github.com/apache/storm/pull/2323
Rebased & squashed.
---