You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Ioannis Canellos <no...@github.com> on 2013/12/02 12:43:27 UTC
[jclouds] [JCLOUDS-392] Remove dependency from Maps2. Make
jclouds-core packages optionally imported from jclouds-scriptbuilder. (#219)
...
You can merge this Pull Request by running:
git pull https://github.com/iocanel/jclouds JCLOUDS-392
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/219
-- Commit Summary --
* [JCLOUDS-392] Remove dependency from Maps2. Make jclouds-core packages optionally imported from jclouds-scriptbuilder.
-- File Changes --
M scriptbuilder/pom.xml (10)
M scriptbuilder/src/main/java/org/jclouds/scriptbuilder/util/Utils.java (24)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/219.patch
https://github.com/jclouds/jclouds/pull/219.diff
Re: [jclouds] [JCLOUDS-392] Remove dependency from Maps2. Make
jclouds-core packages optionally imported from jclouds-scriptbuilder. (#219)
Posted by Ignasi Barrera <no...@github.com>.
Just a quick ping on this. Can we add the comment and merge it?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/219#issuecomment-43721421
Re: [jclouds] [JCLOUDS-392] Remove dependency from Maps2. Make
jclouds-core packages optionally imported from jclouds-scriptbuilder. (#219)
Posted by Ignasi Barrera <no...@github.com>.
Added the comment and pushed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commitdiff;h=2e942072d7f321a1b18f7d39fd824b02c9eb9938).
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/219#issuecomment-44250453
Re: [jclouds] [JCLOUDS-392] Remove dependency from Maps2. Make
jclouds-core packages optionally imported from jclouds-scriptbuilder. (#219)
Posted by Andrew Phillips <no...@github.com>.
> Added the comment and pushed to master.
Thanks, @nacx! @iocanel Hope [this](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commitdiff;h=2e942072d7f321a1b18f7d39fd824b02c9eb9938) looks OK to you..?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/219#issuecomment-44269103
Re: [jclouds] [JCLOUDS-392] Remove dependency from Maps2. Make
jclouds-core packages optionally imported from jclouds-scriptbuilder. (#219)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #890](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/890/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/219#issuecomment-29612467
Re: [jclouds] [JCLOUDS-392] Remove dependency from Maps2. Make
jclouds-core packages optionally imported from jclouds-scriptbuilder. (#219)
Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds #658](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/658/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/219#issuecomment-29613892
Re: [jclouds] [JCLOUDS-392] Remove dependency from Maps2. Make
jclouds-core packages optionally imported from jclouds-scriptbuilder. (#219)
Posted by Andrew Phillips <no...@github.com>.
@iocanel: Any chance of adding a short comment in the POM to explain what you explained in the review comments? Then hopefully we can get this in for 1.7.0?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/219#issuecomment-30169890
Re: [jclouds] [JCLOUDS-392] Remove dependency from Maps2. Make
jclouds-core packages optionally imported from jclouds-scriptbuilder. (#219)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #427](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/427/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/219#issuecomment-29612392
Re: [jclouds] [JCLOUDS-392] Remove dependency from Maps2. Make
jclouds-core packages optionally imported from jclouds-scriptbuilder. (#219)
Posted by Ioannis Canellos <no...@github.com>.
> @@ -34,8 +34,14 @@
> <jclouds.test.listener />
>
> <jclouds.osgi.activator>org.jclouds.scriptbuilder.functionloader.osgi.Activator</jclouds.osgi.activator>
> - <jclouds.osgi.export>org.jclouds.scriptbuilder*;version="${project.version}"</jclouds.osgi.export>
> - <jclouds.osgi.import>org.jclouds*;version="${project.version}",*</jclouds.osgi.import>
> + <jclouds.osgi.export>org.jclouds.scriptbuilder*;version="${project.version}";-noimport:=true</jclouds.osgi.export>
> + <jclouds.osgi.import>
> + javax.inject*;resolution:=optional,
> + org.jclouds.domain*;version="${project.version}";resolution:=optional,
> + org.jclouds.javax.annotation*;version="${project.version}";resolution:=optional,
The following classes are only needed when using chef or other compute stuff:
i) org.jclouds.javax.annotation.Nullable
ii) org.jclouds.domain.Credentials
iii) java.inject.Inject
So we are just saying here that we consider those optional, so at runtime we can use jclouds-scriptbuilder (as long as we don't use compute specific stuff).
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/219/files#r8089614
Re: [jclouds] [JCLOUDS-392] Remove dependency from Maps2. Make
jclouds-core packages optionally imported from jclouds-scriptbuilder. (#219)
Posted by Andrew Phillips <no...@github.com>.
> @@ -34,8 +34,14 @@
> <jclouds.test.listener />
>
> <jclouds.osgi.activator>org.jclouds.scriptbuilder.functionloader.osgi.Activator</jclouds.osgi.activator>
> - <jclouds.osgi.export>org.jclouds.scriptbuilder*;version="${project.version}"</jclouds.osgi.export>
> - <jclouds.osgi.import>org.jclouds*;version="${project.version}",*</jclouds.osgi.import>
> + <jclouds.osgi.export>org.jclouds.scriptbuilder*;version="${project.version}";-noimport:=true</jclouds.osgi.export>
> + <jclouds.osgi.import>
> + javax.inject*;resolution:=optional,
> + org.jclouds.domain*;version="${project.version}";resolution:=optional,
> + org.jclouds.javax.annotation*;version="${project.version}";resolution:=optional,
Thanks for explaining! Comment in the code to mention this?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/219/files#r8098327
Re: [jclouds] [JCLOUDS-392] Remove dependency from Maps2. Make
jclouds-core packages optionally imported from jclouds-scriptbuilder. (#219)
Posted by Ioannis Canellos <no...@github.com>.
> @@ -34,8 +34,14 @@
> <jclouds.test.listener />
>
> <jclouds.osgi.activator>org.jclouds.scriptbuilder.functionloader.osgi.Activator</jclouds.osgi.activator>
> - <jclouds.osgi.export>org.jclouds.scriptbuilder*;version="${project.version}"</jclouds.osgi.export>
> - <jclouds.osgi.import>org.jclouds*;version="${project.version}",*</jclouds.osgi.import>
> + <jclouds.osgi.export>org.jclouds.scriptbuilder*;version="${project.version}";-noimport:=true</jclouds.osgi.export>
Just to tell it to not import the packages we are exporting.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/219/files#r8089581
Re: [jclouds] [JCLOUDS-392] Remove dependency from Maps2. Make
jclouds-core packages optionally imported from jclouds-scriptbuilder. (#219)
Posted by Andrew Phillips <no...@github.com>.
> @@ -34,8 +34,14 @@
> <jclouds.test.listener />
>
> <jclouds.osgi.activator>org.jclouds.scriptbuilder.functionloader.osgi.Activator</jclouds.osgi.activator>
> - <jclouds.osgi.export>org.jclouds.scriptbuilder*;version="${project.version}"</jclouds.osgi.export>
> - <jclouds.osgi.import>org.jclouds*;version="${project.version}",*</jclouds.osgi.import>
> + <jclouds.osgi.export>org.jclouds.scriptbuilder*;version="${project.version}";-noimport:=true</jclouds.osgi.export>
> + <jclouds.osgi.import>
> + javax.inject*;resolution:=optional,
> + org.jclouds.domain*;version="${project.version}";resolution:=optional,
> + org.jclouds.javax.annotation*;version="${project.version}";resolution:=optional,
Which classes actually need these three? I'm guessing they can be optional because the classes that need them will not be loaded when you're only using this from Chef..?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/219/files#r8054022
Re: [jclouds] [JCLOUDS-392] Remove dependency from Maps2. Make
jclouds-core packages optionally imported from jclouds-scriptbuilder. (#219)
Posted by Andrew Phillips <no...@github.com>.
> @@ -34,8 +34,14 @@
> <jclouds.test.listener />
>
> <jclouds.osgi.activator>org.jclouds.scriptbuilder.functionloader.osgi.Activator</jclouds.osgi.activator>
> - <jclouds.osgi.export>org.jclouds.scriptbuilder*;version="${project.version}"</jclouds.osgi.export>
> - <jclouds.osgi.import>org.jclouds*;version="${project.version}",*</jclouds.osgi.import>
> + <jclouds.osgi.export>org.jclouds.scriptbuilder*;version="${project.version}";-noimport:=true</jclouds.osgi.export>
Is that required for this change or is that an unrelated improvement?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/219/files#r8098347
Re: [jclouds] [JCLOUDS-392] Remove dependency from Maps2. Make
jclouds-core packages optionally imported from jclouds-scriptbuilder. (#219)
Posted by Andrew Phillips <no...@github.com>.
> @@ -34,8 +34,14 @@
> <jclouds.test.listener />
>
> <jclouds.osgi.activator>org.jclouds.scriptbuilder.functionloader.osgi.Activator</jclouds.osgi.activator>
> - <jclouds.osgi.export>org.jclouds.scriptbuilder*;version="${project.version}"</jclouds.osgi.export>
> - <jclouds.osgi.import>org.jclouds*;version="${project.version}",*</jclouds.osgi.import>
> + <jclouds.osgi.export>org.jclouds.scriptbuilder*;version="${project.version}";-noimport:=true</jclouds.osgi.export>
Noob question: could you explain what `-noimport:=true` is needed for?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/219/files#r8053996
Re: [jclouds] [JCLOUDS-392] Remove dependency from Maps2. Make
jclouds-core packages optionally imported from jclouds-scriptbuilder. (#219)
Posted by Andrew Phillips <no...@github.com>.
> Can we add the comment and merge it?
Feel free to simply add the comment to the patch before merging, if you would like to get this in.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/219#issuecomment-44230832
Re: [jclouds] [JCLOUDS-392] Remove dependency from Maps2. Make
jclouds-core packages optionally imported from jclouds-scriptbuilder. (#219)
Posted by Ignasi Barrera <no...@github.com>.
Closed #219.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/219#event-125003154