You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/10/29 13:10:45 UTC
[GitHub] [druid] cryptoe commented on a diff in pull request #13282: MSQ: Fix task lock checking during publish, fix lock priority.
cryptoe commented on code in PR #13282:
URL: https://github.com/apache/druid/pull/13282#discussion_r1008698587
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQControllerTask.java:
##########
@@ -204,6 +204,12 @@ public void stopGracefully(final TaskConfig taskConfig)
}
}
+ @Override
+ public int getPriority()
+ {
+ return getContextValue(Tasks.PRIORITY_KEY, Tasks.DEFAULT_BATCH_INDEX_TASK_PRIORITY);
Review Comment:
Nit: should we document this here https://druid.apache.org/docs/24.0.0/ingestion/tasks.html#lock-priority ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org