[jira] [Commented] (FLINK-3952) Bump Netty to 4.1

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503037#comment-16503037 ] 

ASF GitHub Bot commented on FLINK-3952:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6071#discussion_r193345578
  
    --- Diff: pom.xml ---
    @@ -300,15 +300,7 @@ under the License.
     			<dependency>
     				<groupId>org.apache.flink</groupId>
     				<artifactId>flink-shaded-netty</artifactId>
    -				<!-- Don't upgrade for now. Netty versions >= 4.0.28.Final
    -				contain an improvement by Netty, which slices a Netty buffer
    -				instead of doing a memory copy [1] in the
    -				LengthFieldBasedFrameDecoder. In some situations, this
    -				interacts badly with our Netty pipeline leading to OutOfMemory
    -				errors.
    -
    -				[1] https://github.com/netty/netty/issues/3704 -->
    -				<version>4.0.27.Final-${flink.shaded.version}</version>
    +				<version>4.1.24.Final-${flink.shaded.version}</version>
    --- End diff --
    
    I've opened #6128 to bump the remaining version so this PR can stay focused on netty.


> Bump Netty to 4.1
> -----------------
>
>                 Key: FLINK-3952
>                 URL: https://issues.apache.org/jira/browse/FLINK-3952
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core, Network
>            Reporter: rektide de la fey
>            Assignee: Piotr Nowojski
>            Priority: Major
>              Labels: netty
>
> Netty 4.1 is about to release final. This release has [a number of significant enhancements|http://netty.io/wiki/new-and-noteworthy-in-4.1.html], and in particular I find HTTP/2 codecs to be incredibly desirable to have. 
> Additionally, hopefully, the [Hadoop patches for Netty 4.1|https://issues.apache.org/jira/browse/HADOOP-11716] get some tests and get merged, & I believe if/when that happens it'll be important for Flink to also be using the new Netty minor version.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)