You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by dp...@apache.org on 2017/07/27 15:42:32 UTC
[7/7] logging-log4net git commit: Refactor: fixed all comments in
RollingFileAppender.cs to match `// [a-zA-Z]`
Refactor: fixed all comments in RollingFileAppender.cs to match `// [a-zA-Z]`
Project: http://git-wip-us.apache.org/repos/asf/logging-log4net/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4net/commit/aefe91af
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4net/tree/aefe91af
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4net/diff/aefe91af
Branch: refs/heads/develop
Commit: aefe91afd550811a1b26f9ce9414388874ae598a
Parents: ae65cb8
Author: Dominik Psenner <dp...@apache.org>
Authored: Thu Jul 27 17:41:10 2017 +0200
Committer: Dominik Psenner <dp...@apache.org>
Committed: Thu Jul 27 17:41:10 2017 +0200
----------------------------------------------------------------------
src/Appender/RollingFileAppender.cs | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/logging-log4net/blob/aefe91af/src/Appender/RollingFileAppender.cs
----------------------------------------------------------------------
diff --git a/src/Appender/RollingFileAppender.cs b/src/Appender/RollingFileAppender.cs
index 2963db6..1bcf0e0 100644
--- a/src/Appender/RollingFileAppender.cs
+++ b/src/Appender/RollingFileAppender.cs
@@ -984,8 +984,8 @@ namespace log4net.Appender
}
catch(FormatException)
{
- //this happens when file.log -> file.log.yyyy-MM-dd which is normal
- //when staticLogFileName == false
+ // This happens when file.log -> file.log.yyyy-MM-dd which is normal
+ // when staticLogFileName == false
LogLog.Debug(declaringType, "Encountered a backup file not ending in .x ["+curFileName+"]");
}
}
@@ -1206,9 +1206,9 @@ namespace log4net.Appender
return;
}
- //is the new file name equivalent to the 'current' one
- //something has gone wrong if we hit this -- we should only
- //roll over if the new file will be different from the old
+ // is the new file name equivalent to the 'current' one
+ // something has gone wrong if we hit this -- we should only
+ // roll over if the new file will be different from the old
string dateFormat = m_now.ToString(m_datePattern, System.Globalization.DateTimeFormatInfo.InvariantInfo);
if (m_scheduledFilename.Equals(CombinePath(File, dateFormat)))
{
@@ -1222,7 +1222,7 @@ namespace log4net.Appender
this.CloseFile();
}
- //we may have to roll over a large number of backups here
+ // we may have to roll over a large number of backups here
for (int i = 1; i <= m_curSizeRollBackups; i++)
{
string from = CombinePath(File, "." + i);
@@ -1233,10 +1233,10 @@ namespace log4net.Appender
RollFile(File, m_scheduledFilename);
}
- //We've cleared out the old date and are ready for the new
+ // We've cleared out the old date and are ready for the new
m_curSizeRollBackups = 0;
- //new scheduled name
+ // new scheduled name
m_scheduledFilename = CombinePath(File, m_now.ToString(m_datePattern, System.Globalization.DateTimeFormatInfo.InvariantInfo));
if (fileIsOpen)
@@ -1463,10 +1463,10 @@ namespace log4net.Appender
}
else
{
- //countDirection >= 0
+ // countDirection >= 0
if (m_curSizeRollBackups >= m_maxSizeRollBackups && m_maxSizeRollBackups > 0)
{
- //delete the first and keep counting up.
+ // delete the first and keep counting up.
int oldestFileIndex = m_curSizeRollBackups - m_maxSizeRollBackups;
// If static then there is 1 file without a number, therefore 1 less archive