You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@roller.apache.org by GitBox <gi...@apache.org> on 2020/12/30 23:15:53 UTC

[GitHub] [roller] snoopdave opened a new pull request #72: Update selenium tests

snoopdave opened a new pull request #72:
URL: https://github.com/apache/roller/pull/72


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [roller] snoopdave commented on a change in pull request #72: Upgrade to Jetty 11 maven plugin

Posted by GitBox <gi...@apache.org>.
snoopdave commented on a change in pull request #72:
URL: https://github.com/apache/roller/pull/72#discussion_r550529622



##########
File path: pom.xml
##########
@@ -25,10 +25,6 @@ limitations under the License.
     <version>6.1.0-SNAPSHOT</version>
     <packaging>pom</packaging>
 
-    <prerequisites>

Review comment:
       This prerequisites tag is only to be used with Maven Plugin project POMs, not plain old modules like Roller's.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [roller] snoopdave commented on a change in pull request #72: Upgrade to Jetty 10 maven plugin

Posted by GitBox <gi...@apache.org>.
snoopdave commented on a change in pull request #72:
URL: https://github.com/apache/roller/pull/72#discussion_r550881322



##########
File path: app/pom.xml
##########
@@ -55,7 +55,6 @@ limitations under the License.
         <maven-antrun.version>1.0b3</maven-antrun.version>
         <rome.version>1.13.1</rome.version>
         <slf4j.version>1.7.30</slf4j.version>
-        <spring.version>5.2.7.RELEASE</spring.version>

Review comment:
       I was trying to use dependencyManagement in the parent POM to force all Spring deps to the same version, but I don't think it really helped with all those warnings you see when Jetty starts in app or it-selenium. 
   
   I'm going to back this change out.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [roller] mbien commented on pull request #72: Upgrade to Jetty 11 maven plugin

Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #72:
URL: https://github.com/apache/roller/pull/72#issuecomment-753458462


   @snoopdave did you mean Jetty 10? Jetty 11 runs Jakarta EE 9 and most dependencies are not ready for that yet.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [roller] mbien commented on a change in pull request #72: Upgrade to Jetty 11 maven plugin

Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #72:
URL: https://github.com/apache/roller/pull/72#discussion_r550870341



##########
File path: app/pom.xml
##########
@@ -55,7 +55,6 @@ limitations under the License.
         <maven-antrun.version>1.0b3</maven-antrun.version>
         <rome.version>1.13.1</rome.version>
         <slf4j.version>1.7.30</slf4j.version>
-        <spring.version>5.2.7.RELEASE</spring.version>

Review comment:
       was this intended? spring and spring sec are now defined in two different poms. (asking before i rebase)
   
   does this help to reduce selenium warnings or has it other reasons?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [roller] snoopdave commented on pull request #72: Upgrade to Jetty 10 maven plugin

Posted by GitBox <gi...@apache.org>.
snoopdave commented on pull request #72:
URL: https://github.com/apache/roller/pull/72#issuecomment-753472196


   > @snoopdave did you mean Jetty 10? Jetty 11 runs Jakarta EE 9 and most dependencies are not ready for that yet.
   
   Yes. Thanks! I edited the title to fix that.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [roller] snoopdave merged pull request #72: Upgrade to Jetty 11 maven plugin

Posted by GitBox <gi...@apache.org>.
snoopdave merged pull request #72:
URL: https://github.com/apache/roller/pull/72


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org