[GitHub] john-bodley opened a new pull request #3847: [flake8] Resolving Q??? errors

[GitBox <gi...@apache.org>]

john-bodley opened a new pull request #3847: [flake8] Resolving Q??? errors
URL: https://github.com/apache/incubator-superset/pull/3847
 
 
   This is the final PR related to remedying the flake8 errors.  This resolves the flake8 Q??? violation errors which enforces single quotes for strings. 
   
   Previously there was a large mix of single and double quotes used for strings, and per PEP8, 
   
   > In Python, single-quoted strings and double-quoted strings are the same. This PEP does not make a recommendation for this. Pick a rule and stick to it. When a string contains single or double quote characters, however, use the other one to avoid backslashes in the string. It improves readability.
   > 
   > For triple-quoted strings, always use double quote characters to be consistent with the docstring convention in PEP 257.
   > 
   it mentions to pick a rule and stick to it. Given that the majoring of strings were single-quoted I used that as the default. Note some strings include `'` which I've escaped as opposed to using the other to avoid backslashes. I'm happy to remedy this if necessary. 
   
   to: @mistercrunch 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services