You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by bt...@apache.org on 2019/11/15 02:41:22 UTC

[james-project] 13/30: [Refactoring] Moving tests in mailbox.acl to JUnit 5

This is an automated email from the ASF dual-hosted git repository.

btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git

commit 6520ebd500bca03fa01ca2465cd58f3200b64fda
Author: Rene Cordier <rc...@linagora.com>
AuthorDate: Mon Nov 11 16:21:36 2019 +0700

    [Refactoring] Moving tests in mailbox.acl to JUnit 5
---
 .../org/apache/james/mailbox/acl/ACLDiffTest.java  | 34 ++++++++--------
 .../mailbox/acl/PositiveUserACLChangedTest.java    |  6 +--
 .../james/mailbox/acl/PositiveUserACLDiffTest.java | 46 +++++++++++-----------
 .../acl/SimpleGroupMembershipResolverTest.java     | 18 ++++-----
 .../mailbox/acl/UnionMailboxACLResolverTest.java   | 26 ++++++------
 5 files changed, 65 insertions(+), 65 deletions(-)

diff --git a/mailbox/api/src/test/java/org/apache/james/mailbox/acl/ACLDiffTest.java b/mailbox/api/src/test/java/org/apache/james/mailbox/acl/ACLDiffTest.java
index a983d9f..4cd679f 100644
--- a/mailbox/api/src/test/java/org/apache/james/mailbox/acl/ACLDiffTest.java
+++ b/mailbox/api/src/test/java/org/apache/james/mailbox/acl/ACLDiffTest.java
@@ -23,14 +23,14 @@ import static org.assertj.core.api.Assertions.assertThat;
 
 import org.apache.james.mailbox.exception.UnsupportedRightException;
 import org.apache.james.mailbox.model.MailboxACL;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
-public class ACLDiffTest {
+class ACLDiffTest {
     private static final MailboxACL.EntryKey ENTRY_KEY = MailboxACL.EntryKey.createGroupEntryKey("any", false);
     private static final MailboxACL.Rfc4314Rights RIGHTS = new MailboxACL.Rfc4314Rights(MailboxACL.Right.Administer);
 
     @Test
-    public void addedEntriesShouldReturnEmptyWhenSameACL() {
+    void addedEntriesShouldReturnEmptyWhenSameACL() {
         ACLDiff aclDiff = ACLDiff.computeDiff(
             MailboxACL.EMPTY,
             MailboxACL.EMPTY);
@@ -39,7 +39,7 @@ public class ACLDiffTest {
     }
 
     @Test
-    public void addedEntriesShouldReturnEmptyWhenSameNonEmptyACL() throws UnsupportedRightException {
+    void addedEntriesShouldReturnEmptyWhenSameNonEmptyACL() throws UnsupportedRightException {
         MailboxACL mailboxACL = MailboxACL.EMPTY.apply(
             MailboxACL.command()
                 .key(ENTRY_KEY)
@@ -52,7 +52,7 @@ public class ACLDiffTest {
     }
 
     @Test
-    public void removedEntriesShouldReturnEmptyWhenSameACL() {
+    void removedEntriesShouldReturnEmptyWhenSameACL() {
         ACLDiff aclDiff = ACLDiff.computeDiff(
             MailboxACL.EMPTY,
             MailboxACL.EMPTY);
@@ -61,7 +61,7 @@ public class ACLDiffTest {
     }
 
     @Test
-    public void removedEntriesShouldReturnEmptyWhenSameNonEmptyACL() throws UnsupportedRightException {
+    void removedEntriesShouldReturnEmptyWhenSameNonEmptyACL() throws UnsupportedRightException {
         MailboxACL mailboxACL = MailboxACL.EMPTY.apply(
             MailboxACL.command()
                 .key(ENTRY_KEY)
@@ -74,7 +74,7 @@ public class ACLDiffTest {
     }
 
     @Test
-    public void changedEntriesShouldReturnEmptyWhenSameACL() {
+    void changedEntriesShouldReturnEmptyWhenSameACL() {
         ACLDiff aclDiff = ACLDiff.computeDiff(
             MailboxACL.EMPTY,
             MailboxACL.EMPTY);
@@ -83,7 +83,7 @@ public class ACLDiffTest {
     }
 
     @Test
-    public void changedEntriesShouldReturnEmptyWhenSameNonEmptyACL() throws UnsupportedRightException {
+    void changedEntriesShouldReturnEmptyWhenSameNonEmptyACL() throws UnsupportedRightException {
         MailboxACL mailboxACL = MailboxACL.EMPTY.apply(
             MailboxACL.command()
                 .key(ENTRY_KEY)
@@ -96,7 +96,7 @@ public class ACLDiffTest {
     }
     
     @Test
-    public void addedEntriesShouldReturnNewEntryWhenAddedEntry() throws Exception {
+    void addedEntriesShouldReturnNewEntryWhenAddedEntry() throws Exception {
         ACLDiff aclDiff = ACLDiff.computeDiff(
             MailboxACL.EMPTY,
             MailboxACL.EMPTY.apply(
@@ -110,7 +110,7 @@ public class ACLDiffTest {
     }
 
     @Test
-    public void changedEntriesShouldReturnEmptyWhenAddedEntry() throws Exception {
+    void changedEntriesShouldReturnEmptyWhenAddedEntry() throws Exception {
         ACLDiff aclDiff = ACLDiff.computeDiff(
             MailboxACL.EMPTY,
             MailboxACL.EMPTY.apply(
@@ -124,7 +124,7 @@ public class ACLDiffTest {
     }
 
     @Test
-    public void removedEntriesShouldReturnEmptyWhenAddedEntry() throws Exception {
+    void removedEntriesShouldReturnEmptyWhenAddedEntry() throws Exception {
         ACLDiff aclDiff = ACLDiff.computeDiff(
             MailboxACL.EMPTY,
             MailboxACL.EMPTY.apply(
@@ -138,7 +138,7 @@ public class ACLDiffTest {
     }
 
     @Test
-    public void addedEntriesShouldReturnEmptyWhenRemovedEntry() throws Exception {
+    void addedEntriesShouldReturnEmptyWhenRemovedEntry() throws Exception {
         ACLDiff aclDiff = ACLDiff.computeDiff(
             MailboxACL.EMPTY.apply(
                 MailboxACL.command()
@@ -152,7 +152,7 @@ public class ACLDiffTest {
     }
 
     @Test
-    public void changedEntriesShouldReturnEmptyWhenRemovedEntry() throws Exception {
+    void changedEntriesShouldReturnEmptyWhenRemovedEntry() throws Exception {
         ACLDiff aclDiff = ACLDiff.computeDiff(
             MailboxACL.EMPTY.apply(
                 MailboxACL.command()
@@ -166,7 +166,7 @@ public class ACLDiffTest {
     }
 
     @Test
-    public void removedEntriesShouldReturnEntryWhenRemovedEntry() throws Exception {
+    void removedEntriesShouldReturnEntryWhenRemovedEntry() throws Exception {
         ACLDiff aclDiff = ACLDiff.computeDiff(
             MailboxACL.EMPTY.apply(
                 MailboxACL.command()
@@ -180,7 +180,7 @@ public class ACLDiffTest {
     }
 
     @Test
-    public void removedEntriesShouldReturnEmptyWhenChangedEntry() throws Exception {
+    void removedEntriesShouldReturnEmptyWhenChangedEntry() throws Exception {
         ACLDiff aclDiff = ACLDiff.computeDiff(
             MailboxACL.EMPTY.apply(
                 MailboxACL.command()
@@ -198,7 +198,7 @@ public class ACLDiffTest {
     }
 
     @Test
-    public void addedEntriesShouldReturnEmptyWhenChangedEntry() throws Exception {
+    void addedEntriesShouldReturnEmptyWhenChangedEntry() throws Exception {
         ACLDiff aclDiff = ACLDiff.computeDiff(
             MailboxACL.EMPTY.apply(
                 MailboxACL.command()
@@ -216,7 +216,7 @@ public class ACLDiffTest {
     }
 
     @Test
-    public void changedEntriesShouldReturnEntryWhenChangedEntry() throws Exception {
+    void changedEntriesShouldReturnEntryWhenChangedEntry() throws Exception {
         ACLDiff aclDiff = ACLDiff.computeDiff(
             MailboxACL.EMPTY.apply(
                 MailboxACL.command()
diff --git a/mailbox/api/src/test/java/org/apache/james/mailbox/acl/PositiveUserACLChangedTest.java b/mailbox/api/src/test/java/org/apache/james/mailbox/acl/PositiveUserACLChangedTest.java
index 70a5ee7..c391e2d 100644
--- a/mailbox/api/src/test/java/org/apache/james/mailbox/acl/PositiveUserACLChangedTest.java
+++ b/mailbox/api/src/test/java/org/apache/james/mailbox/acl/PositiveUserACLChangedTest.java
@@ -19,14 +19,14 @@
 
 package org.apache.james.mailbox.acl;
 
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
 import nl.jqno.equalsverifier.EqualsVerifier;
 
-public class PositiveUserACLChangedTest {
+class PositiveUserACLChangedTest {
 
     @Test
-    public void shouldMatchBeanContact() {
+    void shouldMatchBeanContact() {
         EqualsVerifier.forClass(PositiveUserACLChanged.class)
             .verify();
     }
diff --git a/mailbox/api/src/test/java/org/apache/james/mailbox/acl/PositiveUserACLDiffTest.java b/mailbox/api/src/test/java/org/apache/james/mailbox/acl/PositiveUserACLDiffTest.java
index 999f8c4..257a1a6 100644
--- a/mailbox/api/src/test/java/org/apache/james/mailbox/acl/PositiveUserACLDiffTest.java
+++ b/mailbox/api/src/test/java/org/apache/james/mailbox/acl/PositiveUserACLDiffTest.java
@@ -26,9 +26,9 @@ import org.apache.james.mailbox.model.MailboxACL.Entry;
 import org.apache.james.mailbox.model.MailboxACL.EntryKey;
 import org.apache.james.mailbox.model.MailboxACL.Rfc4314Rights;
 import org.apache.james.mailbox.model.MailboxACL.Right;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
-public class PositiveUserACLDiffTest {
+class PositiveUserACLDiffTest {
 
     private static final EntryKey USER_ENTRY_KEY = EntryKey.createUserEntryKey("user");
     private static final EntryKey NEGATIVE_USER_ENTRY_KEY = EntryKey.createUserEntryKey("user", true);
@@ -36,7 +36,7 @@ public class PositiveUserACLDiffTest {
     private static final Rfc4314Rights RIGHTS = new Rfc4314Rights(Right.Administer);
 
     @Test
-    public void addedEntriesShouldReturnEmptyWhenSameACL() {
+    void addedEntriesShouldReturnEmptyWhenSameACL() {
         PositiveUserACLDiff positiveUserAclDiff = PositiveUserACLDiff.computeDiff(
             MailboxACL.EMPTY,
             MailboxACL.EMPTY);
@@ -45,7 +45,7 @@ public class PositiveUserACLDiffTest {
     }
 
     @Test
-    public void addedEntriesShouldReturnEmptyWhenSameNonEmptyACL() throws UnsupportedRightException {
+    void addedEntriesShouldReturnEmptyWhenSameNonEmptyACL() throws UnsupportedRightException {
         MailboxACL mailboxACL = MailboxACL.EMPTY.apply(
             MailboxACL.command()
                 .key(USER_ENTRY_KEY)
@@ -58,7 +58,7 @@ public class PositiveUserACLDiffTest {
     }
 
     @Test
-    public void removedEntriesShouldReturnEmptyWhenSameACL() {
+    void removedEntriesShouldReturnEmptyWhenSameACL() {
         PositiveUserACLDiff positiveUserAclDiff = PositiveUserACLDiff.computeDiff(
             MailboxACL.EMPTY,
             MailboxACL.EMPTY);
@@ -67,7 +67,7 @@ public class PositiveUserACLDiffTest {
     }
 
     @Test
-    public void removedEntriesShouldReturnEmptyWhenSameNonEmptyACL() throws UnsupportedRightException {
+    void removedEntriesShouldReturnEmptyWhenSameNonEmptyACL() throws UnsupportedRightException {
         MailboxACL mailboxACL = MailboxACL.EMPTY.apply(
             MailboxACL.command()
                 .key(USER_ENTRY_KEY)
@@ -80,7 +80,7 @@ public class PositiveUserACLDiffTest {
     }
 
     @Test
-    public void changedEntriesShouldReturnEmptyWhenSameACL() {
+    void changedEntriesShouldReturnEmptyWhenSameACL() {
         PositiveUserACLDiff positiveUserAclDiff = PositiveUserACLDiff.computeDiff(
             MailboxACL.EMPTY,
             MailboxACL.EMPTY);
@@ -89,7 +89,7 @@ public class PositiveUserACLDiffTest {
     }
 
     @Test
-    public void changedEntriesShouldReturnEmptyWhenSameNonEmptyACL() throws UnsupportedRightException {
+    void changedEntriesShouldReturnEmptyWhenSameNonEmptyACL() throws UnsupportedRightException {
         MailboxACL mailboxACL = MailboxACL.EMPTY.apply(
             MailboxACL.command()
                 .key(USER_ENTRY_KEY)
@@ -102,7 +102,7 @@ public class PositiveUserACLDiffTest {
     }
 
     @Test
-    public void addedEntriesShouldReturnNewEntryWhenAddedEntry() throws Exception {
+    void addedEntriesShouldReturnNewEntryWhenAddedEntry() throws Exception {
         PositiveUserACLDiff positiveUserAclDiff = PositiveUserACLDiff.computeDiff(
             MailboxACL.EMPTY,
             MailboxACL.EMPTY.apply(
@@ -116,7 +116,7 @@ public class PositiveUserACLDiffTest {
     }
 
     @Test
-    public void addedEntriesShouldFilterNonUserEntryKey() throws Exception {
+    void addedEntriesShouldFilterNonUserEntryKey() throws Exception {
         PositiveUserACLDiff positiveUserAclDiff = PositiveUserACLDiff.computeDiff(
             MailboxACL.EMPTY,
             MailboxACL.EMPTY.apply(
@@ -130,7 +130,7 @@ public class PositiveUserACLDiffTest {
     }
 
     @Test
-    public void addedEntriesShouldFilterNegativeUserEntryKey() throws Exception {
+    void addedEntriesShouldFilterNegativeUserEntryKey() throws Exception {
         PositiveUserACLDiff positiveUserAclDiff = PositiveUserACLDiff.computeDiff(
             MailboxACL.EMPTY,
             MailboxACL.EMPTY.apply(
@@ -144,7 +144,7 @@ public class PositiveUserACLDiffTest {
     }
 
     @Test
-    public void changedEntriesShouldReturnEmptyWhenAddedEntry() throws Exception {
+    void changedEntriesShouldReturnEmptyWhenAddedEntry() throws Exception {
         PositiveUserACLDiff positiveUserAclDiff = PositiveUserACLDiff.computeDiff(
             MailboxACL.EMPTY,
             MailboxACL.EMPTY.apply(
@@ -158,7 +158,7 @@ public class PositiveUserACLDiffTest {
     }
 
     @Test
-    public void removedEntriesShouldReturnEmptyWhenAddedEntry() throws Exception {
+    void removedEntriesShouldReturnEmptyWhenAddedEntry() throws Exception {
         PositiveUserACLDiff positiveUserAclDiff = PositiveUserACLDiff.computeDiff(
             MailboxACL.EMPTY,
             MailboxACL.EMPTY.apply(
@@ -172,7 +172,7 @@ public class PositiveUserACLDiffTest {
     }
 
     @Test
-    public void addedEntriesShouldReturnEmptyWhenRemovedEntry() throws Exception {
+    void addedEntriesShouldReturnEmptyWhenRemovedEntry() throws Exception {
         PositiveUserACLDiff positiveUserAclDiff = PositiveUserACLDiff.computeDiff(
             MailboxACL.EMPTY.apply(
                 MailboxACL.command()
@@ -186,7 +186,7 @@ public class PositiveUserACLDiffTest {
     }
 
     @Test
-    public void changedEntriesShouldReturnEmptyWhenRemovedEntry() throws Exception {
+    void changedEntriesShouldReturnEmptyWhenRemovedEntry() throws Exception {
         PositiveUserACLDiff positiveUserAclDiff = PositiveUserACLDiff.computeDiff(
             MailboxACL.EMPTY.apply(
                 MailboxACL.command()
@@ -200,7 +200,7 @@ public class PositiveUserACLDiffTest {
     }
 
     @Test
-    public void removedEntriesShouldReturnEntryWhenRemovedEntry() throws Exception {
+    void removedEntriesShouldReturnEntryWhenRemovedEntry() throws Exception {
         PositiveUserACLDiff positiveUserAclDiff = PositiveUserACLDiff.computeDiff(
             MailboxACL.EMPTY.apply(
                 MailboxACL.command()
@@ -214,7 +214,7 @@ public class PositiveUserACLDiffTest {
     }
 
     @Test
-    public void removedEntriesShouldFilterNonUserEntry() throws Exception {
+    void removedEntriesShouldFilterNonUserEntry() throws Exception {
         PositiveUserACLDiff positiveUserAclDiff = PositiveUserACLDiff.computeDiff(
             MailboxACL.EMPTY.apply(
                 MailboxACL.command()
@@ -228,7 +228,7 @@ public class PositiveUserACLDiffTest {
     }
 
     @Test
-    public void removedEntriesShouldFilterNegativeUserEntry() throws Exception {
+    void removedEntriesShouldFilterNegativeUserEntry() throws Exception {
         PositiveUserACLDiff positiveUserAclDiff = PositiveUserACLDiff.computeDiff(
             MailboxACL.EMPTY.apply(
                 MailboxACL.command()
@@ -242,7 +242,7 @@ public class PositiveUserACLDiffTest {
     }
 
     @Test
-    public void removedEntriesShouldReturnEmptyWhenChangedEntry() throws Exception {
+    void removedEntriesShouldReturnEmptyWhenChangedEntry() throws Exception {
         PositiveUserACLDiff positiveUserAclDiff = PositiveUserACLDiff.computeDiff(
             MailboxACL.EMPTY.apply(
                 MailboxACL.command()
@@ -260,7 +260,7 @@ public class PositiveUserACLDiffTest {
     }
 
     @Test
-    public void addedEntriesShouldReturnEmptyWhenChangedEntry() throws Exception {
+    void addedEntriesShouldReturnEmptyWhenChangedEntry() throws Exception {
         PositiveUserACLDiff positiveUserAclDiff = PositiveUserACLDiff.computeDiff(
             MailboxACL.EMPTY.apply(
                 MailboxACL.command()
@@ -278,7 +278,7 @@ public class PositiveUserACLDiffTest {
     }
 
     @Test
-    public void changedEntriesShouldReturnEntryWhenChangedEntry() throws Exception {
+    void changedEntriesShouldReturnEntryWhenChangedEntry() throws Exception {
         PositiveUserACLDiff positiveUserAclDiff = PositiveUserACLDiff.computeDiff(
             MailboxACL.EMPTY.apply(
                 MailboxACL.command()
@@ -296,7 +296,7 @@ public class PositiveUserACLDiffTest {
     }
 
     @Test
-    public void changedEntriesShouldFilterNonUserEntry() throws Exception {
+    void changedEntriesShouldFilterNonUserEntry() throws Exception {
         PositiveUserACLDiff positiveUserAclDiff = PositiveUserACLDiff.computeDiff(
             MailboxACL.EMPTY.apply(
                 MailboxACL.command()
@@ -314,7 +314,7 @@ public class PositiveUserACLDiffTest {
     }
 
     @Test
-    public void changedEntriesShouldFilterNegativeUserEntry() throws Exception {
+    void changedEntriesShouldFilterNegativeUserEntry() throws Exception {
         PositiveUserACLDiff positiveUserAclDiff = PositiveUserACLDiff.computeDiff(
             MailboxACL.EMPTY.apply(
                 MailboxACL.command()
diff --git a/mailbox/api/src/test/java/org/apache/james/mailbox/acl/SimpleGroupMembershipResolverTest.java b/mailbox/api/src/test/java/org/apache/james/mailbox/acl/SimpleGroupMembershipResolverTest.java
index f77dbbb..ece7ff9 100644
--- a/mailbox/api/src/test/java/org/apache/james/mailbox/acl/SimpleGroupMembershipResolverTest.java
+++ b/mailbox/api/src/test/java/org/apache/james/mailbox/acl/SimpleGroupMembershipResolverTest.java
@@ -22,20 +22,20 @@ package org.apache.james.mailbox.acl;
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-import org.junit.Before;
-import org.junit.Test;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
 
-public class SimpleGroupMembershipResolverTest {
+class SimpleGroupMembershipResolverTest {
 
     private SimpleGroupMembershipResolver simpleGroupMembershipResolver;
 
-    @Before
-    public void setUp() {
+    @BeforeEach
+    void setUp() {
        simpleGroupMembershipResolver = new SimpleGroupMembershipResolver();
     }
 
     @Test
-    public void isMemberShouldReturnFalseWhenEmptyResolver() throws Exception {
+    void isMemberShouldReturnFalseWhenEmptyResolver() {
         //When
         boolean actual = simpleGroupMembershipResolver.isMember("user", "group");
         //Then
@@ -43,7 +43,7 @@ public class SimpleGroupMembershipResolverTest {
     }
 
     @Test
-    public void isMemberShouldReturnTrueWhenTheSearchedMembershipIsPresent() throws Exception {
+    void isMemberShouldReturnTrueWhenTheSearchedMembershipIsPresent() {
         //Given
         simpleGroupMembershipResolver.addMembership("group", "user");
         //When
@@ -53,7 +53,7 @@ public class SimpleGroupMembershipResolverTest {
     }
 
     @Test
-    public void addMembershipShouldAddAMembershipWhenNonNullUser() throws Exception {
+    void addMembershipShouldAddAMembershipWhenNonNullUser() {
         //When
         simpleGroupMembershipResolver.addMembership("group", "user");
         boolean actual = simpleGroupMembershipResolver.isMember("user", "group");
@@ -62,7 +62,7 @@ public class SimpleGroupMembershipResolverTest {
     }
 
     @Test
-    public void addMembershipShouldAddAMembershipWithANullUser() throws Exception {
+    void addMembershipShouldAddAMembershipWithANullUser() {
         //Given
         String userAdded = null;
         //When
diff --git a/mailbox/api/src/test/java/org/apache/james/mailbox/acl/UnionMailboxACLResolverTest.java b/mailbox/api/src/test/java/org/apache/james/mailbox/acl/UnionMailboxACLResolverTest.java
index 9d34634..b133994 100644
--- a/mailbox/api/src/test/java/org/apache/james/mailbox/acl/UnionMailboxACLResolverTest.java
+++ b/mailbox/api/src/test/java/org/apache/james/mailbox/acl/UnionMailboxACLResolverTest.java
@@ -28,10 +28,10 @@ import org.apache.james.mailbox.model.MailboxACL.Entry;
 import org.apache.james.mailbox.model.MailboxACL.EntryKey;
 import org.apache.james.mailbox.model.MailboxACL.NameType;
 import org.apache.james.mailbox.model.MailboxACL.Rfc4314Rights;
-import org.junit.Before;
-import org.junit.Test;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
 
-public class UnionMailboxACLResolverTest {
+class UnionMailboxACLResolverTest {
 
     private static final String GROUP_1 = "group1";
     private static final String GROUP_2 = "group2";
@@ -60,8 +60,8 @@ public class UnionMailboxACLResolverTest {
     private EntryKey group1Key;
     private EntryKey group2Key;
 
-    @Before
-    public void setUp() throws Exception {
+    @BeforeEach
+    void setUp() throws Exception {
         user1Key = EntryKey.createUserEntryKey(USER_1);
         user2Key = EntryKey.createUserEntryKey(USER_2);
         group1Key = EntryKey.createGroupEntryKey(GROUP_1);
@@ -99,7 +99,7 @@ public class UnionMailboxACLResolverTest {
     }
 
     @Test
-    public void testAppliesNullUser() throws UnsupportedRightException {
+    void testAppliesNullUser() throws UnsupportedRightException {
 
         assertThat(UnionMailboxACLResolver.applies(user1Key, null, groupMembershipResolver, USER_1, false)).isFalse();
         assertThat(UnionMailboxACLResolver.applies(user2Key, null, groupMembershipResolver, USER_1, false)).isFalse();
@@ -111,7 +111,7 @@ public class UnionMailboxACLResolverTest {
     }
 
     @Test
-    public void testAppliesUser() throws UnsupportedRightException {
+    void testAppliesUser() throws UnsupportedRightException {
         /* requester is the resource owner */
         assertThat(UnionMailboxACLResolver.applies(user1Key, user1Key, groupMembershipResolver, USER_1, false)).isTrue();
         assertThat(UnionMailboxACLResolver.applies(user2Key, user1Key, groupMembershipResolver, USER_1, false)).isFalse();
@@ -160,7 +160,7 @@ public class UnionMailboxACLResolverTest {
     }
 
     @Test
-    public void testResolveRightsNullUser() throws UnsupportedRightException {
+    void testResolveRightsNullUser() throws UnsupportedRightException {
 
         assertThat(
             anyoneReadListGlobal.resolveRights(null, groupMembershipResolver, user1Read, USER_1, false)
@@ -399,7 +399,7 @@ public class UnionMailboxACLResolverTest {
     }
 
     @Test
-    public void testResolveRightsNullUserGlobals() throws UnsupportedRightException {
+    void testResolveRightsNullUserGlobals() throws UnsupportedRightException {
         assertThat(
             anyoneReadListGlobal.resolveRights(null, groupMembershipResolver, user1Read, USER_2, false)
                 .contains(MailboxACL.Right.Read))
@@ -424,7 +424,7 @@ public class UnionMailboxACLResolverTest {
 
 
     @Test
-    public void testResolveRightsUserSelfOwner() throws UnsupportedRightException {
+    void testResolveRightsUserSelfOwner() throws UnsupportedRightException {
 
         assertThat(
             anyoneReadListGlobal.resolveRights(USER_1, groupMembershipResolver, user1Read, USER_1, false)
@@ -659,7 +659,7 @@ public class UnionMailboxACLResolverTest {
 
 
     @Test
-    public void testResolveRightsUserNotOwner() throws UnsupportedRightException {
+    void testResolveRightsUserNotOwner() throws UnsupportedRightException {
 
         assertThat(
             anyoneReadListGlobal.resolveRights(USER_1, groupMembershipResolver, user1Read, USER_2, false)
@@ -893,7 +893,7 @@ public class UnionMailboxACLResolverTest {
     }
 
     @Test
-    public void testResolveRightsUserMemberOfOwnerGroup() throws UnsupportedRightException {
+    void testResolveRightsUserMemberOfOwnerGroup() throws UnsupportedRightException {
 
         assertThat(
             anyoneReadListGlobal.resolveRights(USER_1, groupMembershipResolver, user1Read, GROUP_1, true)
@@ -1128,7 +1128,7 @@ public class UnionMailboxACLResolverTest {
 
 
     @Test
-    public void testResolveRightsUserNotMemberOfOwnerGroup() throws UnsupportedRightException {
+    void testResolveRightsUserNotMemberOfOwnerGroup() throws UnsupportedRightException {
 
         assertThat(
             anyoneReadListGlobal.resolveRights(USER_1, groupMembershipResolver, user1Read, GROUP_2, true)


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org