Re: [PR] feat (Synchronizer): forward realm-context header on all Polaris requests [polaris-tools]

["dimas-b (via GitHub)" <gi...@apache.org>]

dimas-b commented on code in PR #262:
URL: https://github.com/apache/polaris-tools/pull/262#discussion_r3739788150


##########
polaris-synchronizer/api/src/main/java/org/apache/polaris/tools/sync/polaris/catalog/PolarisCatalog.java:
##########
@@ -117,6 +117,13 @@ public Table loadTable(TableIdentifier ident, String etag) {
 
     this.authenticationSession.getSessionHeaders().forEach(requestBuilder::header);
 
+    // this manual HTTP path bypasses RESTSessionCatalog's "header.<name>" property convention,
+    // so the realm-context header must be attached explicitly here as well
+    String realm = this.properties.get("realm");
+    if (realm != null) {
+      requestBuilder.header(this.properties.getOrDefault("realm-header-name", "Polaris-Realm"), realm);

Review Comment:
   This code fragment is repeated... Could we handle the realm header in a shared utility class?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org