You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2015/09/22 03:16:01 UTC

Review Request 38586: Ranger Database related property values should be recommended by stack advisor

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38586/
-----------------------------------------------------------

Review request for Ambari, Srimanth Gunturi, Sumit Gupta, and Yusaku Sako.


Bugs: AMBARI-13175
    https://issues.apache.org/jira/browse/AMBARI-13175


Repository: ambari


Description
-------

Recommendation API should be called whenever admin-properties/DB_FLAVOR is changed.

Also changing of ${admin-properties/db_host} and ${admin-properties/db_name} should change ranger-admin-site/ranger.jpa.jdbc.url for HDP-2.3 stack.
Please see https://issues.apache.org/jira/browse/AMBARI-13175 for further description details


Diffs
-----

  ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/admin-properties.xml 5fdb1b9 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 5568e60 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml 43be765 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/themes/theme.json PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py d7ea10f 
  ambari-web/app/data/db_properties_info.js d48dc98 
  ambari-web/app/views/common/controls_view.js a7bf5a0 

Diff: https://reviews.apache.org/r/38586/diff/


Testing
-------

Tested the patch on a cluster.

Verified that all ambari-web unit tests passes:
9602 tests complete (12 seconds)
94 tests pending

Also verified that ambari-server python unit tests are passing successfully:
----------------------------------------------------------------------
Ran 231 tests in 6.860s
OK
----------------------------------------------------------------------
Total run:795
Total errors:0
Total failures:0
OK
Process finished with exit code 0


Thanks,

Jaimin Jetly


Re: Review Request 38586: Ranger Database related property values should be recommended by stack advisor

Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38586/#review99897
-----------------------------------------------------------

Ship it!


Ship It!

- Yusaku Sako


On Sept. 22, 2015, 1:17 a.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38586/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2015, 1:17 a.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi, Sumit Gupta, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-13175
>     https://issues.apache.org/jira/browse/AMBARI-13175
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Recommendation API should be called whenever admin-properties/DB_FLAVOR is changed.
> 
> Also changing of ${admin-properties/db_host} and ${admin-properties/db_name} should change ranger-admin-site/ranger.jpa.jdbc.url for HDP-2.3 stack.
> Please see https://issues.apache.org/jira/browse/AMBARI-13175 for further description details
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/admin-properties.xml 5fdb1b9 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 5568e60 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml 43be765 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py d7ea10f 
>   ambari-web/app/data/db_properties_info.js d48dc98 
>   ambari-web/app/views/common/controls_view.js a7bf5a0 
> 
> Diff: https://reviews.apache.org/r/38586/diff/
> 
> 
> Testing
> -------
> 
> Tested the patch on a cluster.
> 
> Verified that all ambari-web unit tests passes:
> 9602 tests complete (12 seconds)
> 94 tests pending
> 
> Also verified that ambari-server python unit tests are passing successfully:
> ----------------------------------------------------------------------
> Ran 231 tests in 6.860s
> OK
> ----------------------------------------------------------------------
> Total run:795
> Total errors:0
> Total failures:0
> OK
> Process finished with exit code 0
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>


Re: Review Request 38586: Ranger Database related property values should be recommended by stack advisor

Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38586/
-----------------------------------------------------------

(Updated Sept. 22, 2015, 1:17 a.m.)


Review request for Ambari, Srimanth Gunturi, Sumit Gupta, and Yusaku Sako.


Bugs: AMBARI-13175
    https://issues.apache.org/jira/browse/AMBARI-13175


Repository: ambari


Description
-------

Recommendation API should be called whenever admin-properties/DB_FLAVOR is changed.

Also changing of ${admin-properties/db_host} and ${admin-properties/db_name} should change ranger-admin-site/ranger.jpa.jdbc.url for HDP-2.3 stack.
Please see https://issues.apache.org/jira/browse/AMBARI-13175 for further description details


Diffs (updated)
-----

  ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/admin-properties.xml 5fdb1b9 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 5568e60 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml 43be765 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py d7ea10f 
  ambari-web/app/data/db_properties_info.js d48dc98 
  ambari-web/app/views/common/controls_view.js a7bf5a0 

Diff: https://reviews.apache.org/r/38586/diff/


Testing
-------

Tested the patch on a cluster.

Verified that all ambari-web unit tests passes:
9602 tests complete (12 seconds)
94 tests pending

Also verified that ambari-server python unit tests are passing successfully:
----------------------------------------------------------------------
Ran 231 tests in 6.860s
OK
----------------------------------------------------------------------
Total run:795
Total errors:0
Total failures:0
OK
Process finished with exit code 0


Thanks,

Jaimin Jetly